-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graceful node shutdown #2000
Comments
/sig node |
@bobbypage Do you want this in 1.20 or 1.21? If so I added a comment here: #2001 (review) Since you will need to: Update the related Issue to get it in the milestone, add graduation criteria (alpha, beta, etc) and mark this as implementable. by Enhancements Freeze October 6th |
I'd like to target 1.20 if possible, I've updated the KEP and issue as such, please see the corresponding comment there: #2001 (comment) Please let me know if anything else is missing. Thanks for your help! |
Hi @bobbypage ! KEP will need graduation criteria for alpha and in the kep.yaml update to show 1.20 as being alpha. After that you're good to go =) |
Thanks @kikisdeliveryservice -- I updated the KEP with that info |
Hi @bobbypage The KEP seems to be missing graduation criteria for alpha:https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2000-graceful-node-shutdown#graduation-criteria Please update and merge by October 6th |
That was fast! The KEP is done & good to go for 1.20 👍 |
Hi @bobbypage 😄 Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them. Thanks! |
Hello @bobbypage 👋 , 1.20 Docs lead here. Does this enhancement work planned for 1.20 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
Hi @bobbypage The docs placeholder deadline is this Friday. Please make sure to create a placeholder PR against the Also, please keep in mind the important upcoming dates:
As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track. |
Hi @annajung I've created a placeholder PR here: kubernetes/website#24918 The PR for this is still in flight, so I'm not completely sure if it'll make the timeline for 1.20 cut, but will try :). Otherwise, we'll have to target this for 1.21. |
Thanks for the update! No worries, you still have a few more days before the code freeze. |
Hey @bobbypage I see that kubernetes/kubernetes#96129 is still open and in active review. Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required. Best, |
Looks like the PR merged! 🥳 |
What is preventing this from GA-ing? It is entering the perma-beta state, and we try not to do it. |
Should we provide Windows support for handling node shutdown gracefully? |
@SergeyKanzhelev @mrunalp will this still be a target for GA-ing in v1.30? Thank you |
There are still outstanding issues that need to be resolved before GA-ing, like kubernetes/kubernetes#122912 |
I really want to have a clearer picture of the current status of this feature. As to my knowledge: the major issues that are currently blocking the GA are
and we have an upcoming Declarative Node Maintenance that will have some overlap with GracefulNodeShutdown Is this correct? |
There are a few more relevant issues, please see the Motivation section of the Declarative Node Maintenance #4213, but I am not sure about the severity. |
@smarterclayton Are you planning on working on the endpoint issue with graceful node shutdown in 1.32? |
/milestone v1.32 |
/assign kwilczynski |
/unassign mvortizr |
Hello @kwilczynski @bobbypage 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
@tjons, thank you for a friendly poke. We will do our best to meet the deadline. |
@haircommander, after talking with @mrunalp recently, I believe we will keep this feature as Beta in 1.32, too. Additionally, @atiratree has also expressed concerns about a potential promotion of Graceful Node Shutdown in 1.32, especially from the SIG Apps point of view. @tjons, we probably won't be pursuing 1.32 further here, but let's wait for some consensus about it. |
/milestone clear |
Enhancement Description
k/enhancements
) update PR(s):k/k
) update PR(s): Implement Graceful Node Shutdown in Kubelet kubernetes#96129k/website
) update(s): Graceful node shutdown (alpha 1.20 feature) docs [KEP: 2000] website#24918k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s): add 1.21 graceful node shutdown blog post website#27335k/enhancements
) update PR(s):shutdown -h now
systemd version compatibility #4640k/k
) update PR(s): some test and bugfix after betak/website
) update(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: