Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forensic Container Checkpointing #2008

Open
adrianreber opened this issue Sep 23, 2020 · 37 comments
Open

Forensic Container Checkpointing #2008

adrianreber opened this issue Sep 23, 2020 · 37 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@adrianreber
Copy link
Contributor

adrianreber commented Sep 23, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 23, 2020
@adrianreber
Copy link
Contributor Author

adrianreber commented Sep 23, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 23, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 23, 2020

Discussion Link: N/A (or... at multiple conferences during the last years when presenting CRIU and container migration, there was always the question when will we see container migration in Kubernetes)

Responsible SIGs: maybe node

We recommend actively socializing your KEP with the appropriate sig to gain visibility, consensus and also for scheduling. Also as you are not sure of what SIG will sponsor this, reaching out to the SIGs to get clarity on that will be helpful to move your KEP forward.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 27, 2020

Hi @adrianreber

Any updates on whether this will be included in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have an issue in the milestone

Best,
Kirsten

@adrianreber
Copy link
Contributor Author

adrianreber commented Sep 28, 2020

Hello @kikisdeliveryservice

Any updates on whether this will be included in 1.20?

Sorry, but how would I decide this? There has not been a lot of feedback on the corresponding KEP which makes it really difficult for me to answer that question. On the other hand, maybe the missing feedback is a good sign that it will take some more time. So probably this will not be included in 1.20.

@kikisdeliveryservice kikisdeliveryservice added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 28, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 28, 2020

Normally the sig would give a clear signal that it would be included. That would be by : reviewing the KEP, agreeing to the milestone proposals in the KEP etc.. I'd encourage you to keep in touch with them and start the 1.21 conversation early if this does not end up getting reviewed/merged properly by October 6th.

Best,
Kirsten

@adrianreber
Copy link
Contributor Author

adrianreber commented Sep 28, 2020

@kikisdeliveryservice Thanks for the guidance. Will do.

@fejta-bot
Copy link

fejta-bot commented Dec 27, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2020
@fejta-bot
Copy link

fejta-bot commented Jan 26, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 26, 2021
@fejta-bot
Copy link

fejta-bot commented Feb 25, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 25, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adrianreber
Copy link
Contributor Author

adrianreber commented Feb 25, 2021

/reopen
/remove-lifecycle rotten

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 25, 2021

@adrianreber: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 25, 2021
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 25, 2021
@fejta-bot
Copy link

fejta-bot commented May 26, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2021
@adrianreber
Copy link
Contributor Author

adrianreber commented May 27, 2021

/remove-lifecycle stale

Still working on it.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 25, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@adrianreber
Copy link
Contributor Author

adrianreber commented Feb 15, 2022

@nate-double-u documentation PR available at kubernetes/website#31753

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Mar 6, 2022
@gracenng gracenng added this to the v1.24 milestone Mar 6, 2022
@valaparthvi
Copy link

valaparthvi commented Mar 21, 2022

Hi @adrianreber 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@rhockenbury
Copy link

rhockenbury commented Mar 22, 2022

Hi @adrianreber

I'm checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this KEP, it looks like just k/k#104907 needs to be merged. Are there any other PRs that you think we should be tracking that would be subject to the 1.24 code freeze?

Let me know if you have any questions.

@adrianreber
Copy link
Contributor Author

adrianreber commented Mar 22, 2022

@rhockenbury There are no other PRs that need to be tracked.

@rhockenbury
Copy link

rhockenbury commented Mar 29, 2022

Friendly reminder to try to merge k/k#104907 before code freeze at 01:00 UTC Wednesday 30th March 2022.

@adrianreber
Copy link
Contributor Author

adrianreber commented Apr 26, 2022

KEP update PR for 1.25 #3264

@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@dchen1107 dchen1107 added this to the v1.25 milestone Jun 9, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 10, 2022
@parul5sahoo
Copy link
Member

parul5sahoo commented Jun 10, 2022

Hello @adrianreber👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@adrianreber
Copy link
Contributor Author

adrianreber commented Jun 17, 2022

@parul5sahoo see #3406 for the updated test plan

@parul5sahoo
Copy link
Member

parul5sahoo commented Jun 17, 2022

Hello @adrianreber 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place, this enhancement is all good for the upcoming enhancements freeze once that PR gets merged. 🚀

For note, the status of this enhancement is marked as at risk and will be marked as tracked as soon as the PR gets merged. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@parul5sahoo
Copy link
Member

parul5sahoo commented Jun 20, 2022

Hello @adrianreber , the KEP is marked tracked and is ready for Enhacements freeze 🚀

@adrianreber
Copy link
Contributor Author

adrianreber commented Jul 11, 2022

Opened docs PR at kubernetes/website#34940

@rhockenbury
Copy link

rhockenbury commented Jul 21, 2022

👋 Hey @adrianreber,

Enhancements team checking in as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed by code freeze:
[ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
[x] All PRs are fully merged by the code freeze deadline.

Looks like there is one merged PR in k/k. Let me know if I missed any other PRs that need to be tracked.

As always, we are here to help should questions come up. Thanks!!

@adrianreber
Copy link
Contributor Author

adrianreber commented Jul 22, 2022

@rhockenbury kubernetes/kubernetes#104907 is the only PR and it is merged.

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@sftim
Copy link
Contributor

sftim commented Oct 21, 2022

I think it'd be useful if the kubelet annotated Pods with the timestamp of their last checkpoint.

If we add native support for restores, we could additionally manage a Pod annotation with the timestamp of the last restore, and perhaps with some details of the checkpoint data that was restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests