Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet CRI support #2040

Open
mrunalp opened this issue Sep 30, 2020 · 43 comments
Open

Kubelet CRI support #2040

mrunalp opened this issue Sep 30, 2020 · 43 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@mrunalp
Copy link
Contributor

mrunalp commented Sep 30, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 30, 2020
@mrunalp
Copy link
Contributor Author

mrunalp commented Sep 30, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2020
@kikisdeliveryservice kikisdeliveryservice added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 30, 2020
@kikisdeliveryservice kikisdeliveryservice added this to the v1.20 milestone Sep 30, 2020
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 1, 2020

thanks @mrunalp .

The CRI project started around version 1.4.
see: kubernetes/kubernetes@08dc661

As a result, it pre-dates many of the processes that the project follows today.

Let's use this issue to not just track the API from alpha->beta but beta->stable.

As a result, I am retitling the issue and updating the milestones.

/retitle Kubelet CRI support

@k8s-ci-robot k8s-ci-robot changed the title Promote CRI API to beta Kubelet CRI support Oct 1, 2020
@derekwaynecarr derekwaynecarr added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Oct 1, 2020
@kikisdeliveryservice kikisdeliveryservice removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Oct 1, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 2, 2020

PR merged, you're good! 👍

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 11, 2020

Hey @mrunalp 👋

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks!
Kirsten 😸

@somtochiama
Copy link
Member

somtochiama commented Oct 21, 2020

Hello @mrunalp, 1.20 Docs shadow here 👋🏽.
Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@mrunalp
Copy link
Contributor Author

mrunalp commented Oct 27, 2020

@kikisdeliveryservice @somtochiama Thanks! I will open a PR.

@mrunalp
Copy link
Contributor Author

mrunalp commented Oct 27, 2020

@kikisdeliveryservice @somtochiama I have opened kubernetes/website#24757

@mrunalp
Copy link
Contributor Author

mrunalp commented Oct 27, 2020

There is currently one PR open for this enhancement https://github.com/kubernetes/kubernetes/pull/95876/files. After that is merged
I will open a PR to update the version.

@annajung
Copy link
Member

annajung commented Nov 1, 2020

Hi @mrunalp

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 10, 2020

Hey @mrunalp

kubernetes/kubernetes#96325 & kubernetes/kubernetes#96364 are both still open.

Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Best,
Kirsten

@mrunalp
Copy link
Contributor Author

mrunalp commented Nov 12, 2020

Because of a chicken-and-egg situation, we are going to land kubernetes/kubernetes#96387 in 1.20 and follow up with the rest in 1.21. This comment captures the decision in sig-node kubernetes/kubernetes#96325 (comment)

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Thanks @mrunalp

I will mark this as done for 1.20 but update that this is staying in alpha.

@kikisdeliveryservice kikisdeliveryservice added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Nov 12, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Also, the docs moving this to beta in 1.20 are not needed at this time @annajung

@annajung
Copy link
Member

annajung commented Nov 12, 2020

Thanks @kikisdeliveryservice @mrunalp for the update.

@mrunalp If docs changes are not needed for the two prs that were merged kubernetes/kubernetes#95876, kubernetes/kubernetes#96387, please feel free to close out the kubernetes/website#24757.

@salaxander
Copy link

salaxander commented Sep 7, 2021

Hi @mrunalp! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09. Here's where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

I see there's an open PR for the kep.yaml. Once that merges we're all good to go for enhancements freeze.

Thanks!

@salaxander
Copy link

salaxander commented Sep 7, 2021

/stage beta

@jlbutler
Copy link

jlbutler commented Sep 17, 2021

Hi @mrunalp 👋 1.23 Docs lead here. This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed please take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@ehashman
Copy link
Member

ehashman commented Oct 12, 2021

PR for beta: kubernetes/kubernetes#104575

@salaxander
Copy link

salaxander commented Nov 8, 2021

Hi @ehashman 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

@salaxander
Copy link

salaxander commented Nov 16, 2021

Hi @ehashman - Just want to confirm since code freeze is today. Have all k/k PRs associated with this KEP merged?

@ehashman
Copy link
Member

ehashman commented Nov 17, 2021

@salaxander we moved to another implementation and it just missed due to timezone issues/confusion over a unit test update. I am picking up the implementation and opening an exception request.

@reylejano
Copy link
Member

reylejano commented Nov 17, 2021

We APPROVE the exception request to the 1.23 Code Freeze, please have k/k PR and follow-up PR approved and merged by Friday.

@mrunalp
Copy link
Contributor Author

mrunalp commented Nov 18, 2021

Docs placeholder PR - kubernetes/website#30557

@gracenng gracenng removed this from the v1.23 milestone Jan 9, 2022
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Apr 9, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 9, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jun 8, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 8, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ehashman
Copy link
Member

ehashman commented Nov 1, 2022

I don't think this is fully stable and graduated yet?

/reopen
/remove-lifecycle rotten

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 1, 2022

@ehashman: Reopened this issue.

In response to this:

I don't think this is fully stable and graduated yet?

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Nov 1, 2022
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 1, 2022
@ehashman
Copy link
Member

ehashman commented Nov 1, 2022

ping @mrunalp for graduation status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests