Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the kubeadm master node-role label and taint #2067

Open
neolit123 opened this issue Oct 3, 2020 · 40 comments
Open

rename the kubeadm master node-role label and taint #2067

neolit123 opened this issue Oct 3, 2020 · 40 comments
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@neolit123
Copy link
Member

neolit123 commented Oct 3, 2020

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 3, 2020
@neolit123
Copy link
Member Author

neolit123 commented Oct 3, 2020

/milestone v1.20
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 3, 2020
@neolit123 neolit123 added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Oct 3, 2020
@neolit123
Copy link
Member Author

neolit123 commented Oct 3, 2020

created the KEP PR here:
#2068

the plan for 1.20 is agreed on, so we can merge this as "implementable" on Tuesday next week and amend for other stages later.

@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 5, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 5, 2020

hi @neolit123 !

as a reminder your PR (#2068 ) needs to merge by EOD PST tomorrow October 6th to be included in the 1.20 Release. After that time you will need to request an exception.

@kikisdeliveryservice kikisdeliveryservice changed the title rename the kubeadm "master" node-role label and taint rename the kubeadm master node-role label and taint Oct 5, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 5, 2020

(note: i had to remove the quotes around master in the title of this issue as they broke our spreadsheet tooling)

@neolit123
Copy link
Member Author

neolit123 commented Oct 6, 2020

@kikisdeliveryservice #2068 merged.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 6, 2020

Thanks for the update @neolit123 ! I updated in the tracking sheet 👍

@eagleusb
Copy link
Member

eagleusb commented Oct 22, 2020

Hello @neolit123 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@eagleusb
Copy link
Member

eagleusb commented Nov 2, 2020

Hi @neolit123 👋

The docs placeholder deadline is almost here.

Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

Thanks !

@neolit123
Copy link
Member Author

neolit123 commented Nov 5, 2020

docs placeholder PR:
kubernetes/website#24907

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 10, 2020

Hey @neolit123 !

I see that kubernetes/kubernetes#95382 is still open.

Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks!
Kirsten

@neolit123
Copy link
Member Author

neolit123 commented Nov 10, 2020

@kikisdeliveryservice noted, thanks.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Looks like that PR has merged. Excellent! 👍

@neolit123
Copy link
Member Author

neolit123 commented Nov 12, 2020

docs placeholder PR:
kubernetes/website#24907

note, we dropped the idea to add mentions about this change in the docs for 1.20
kubernetes/website#24907 is now a placeholder for something else.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Gotcha - thanks!

cc: @annajung

@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
@annajung
Copy link
Member

annajung commented Jan 7, 2021

Hi @neolit123 1.21 Enhancement Lead here.

I believe this issue can close now. Before closing, can you update the kep.yaml to reflect a status of implemented:

Once that merges, we can close out this issue.

@neolit123
Copy link
Member Author

neolit123 commented Jan 7, 2021

hi @annajung we need to keep this open until around 1.24+. this is mentioned in the OP here and the KEP.

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@neolit123
Copy link
Member Author

neolit123 commented Jan 12, 2022

Hi, @gracenng. The Alpha, Beta, GA stages don't really apply for this "enchancement", but given this is stage 2/4, i'd say it's more of a Beta.

@rhockenbury
Copy link

rhockenbury commented Jan 20, 2022

Hi @neolit123 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting "beta" for 1.24 (using beta as the rough equivalent of stage 2/4).

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria. - N/A
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is at risk. Thanks!

@neolit123
Copy link
Member Author

neolit123 commented Jan 20, 2022

hi @rhockenbury as i've mentioned above:
#2067 (comment)

this change does not follow the alpha-beta-GA process. also currently if we add latest-milestone: 1.24 it will start requiring a PRR (mechanical problem with the YAML) and a PRR is not needed for this change or kubeadm changes in general.
you can confirm that with the release team and the PRR reviewers.

@rhockenbury
Copy link

rhockenbury commented Jan 20, 2022

Hi @neolit123 - It does not require a PRR but it still requires someone from the PRR team to rubberstamp it. This was confirmed by the PRR team in this Slack thread.

@neolit123
Copy link
Member Author

neolit123 commented Jan 21, 2022

kubeadm has been considered as "not core" and PRR has been claimed as not needed for it.
in reality, we already carefully review our self how the tool changes with production in mind.

PRR rubberstamping feels like a bureaucracy complication that is pointless.
we put files in https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-cluster-lifecycle and a PRR is not even done for these.

this has been a recurring topic every release, and i'm inclined to send a PR for this repository to remove the existing files from https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-cluster-lifecycle and also apply a test rule to not validate https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/*.

i can also mention this in the enhancements role book:
https://github.com/kubernetes/sig-release/tree/master/release-team/role-handbooks/enhancements#collection-monitoring-and-triage-week-1-2

if the release team / PRR reviewers would like to still insist on the rubberstamp, i suggest we remove the kubeadm proposals:
#2915
#2067 (this proposal)
for tracking in 1.24.

@neolit123
Copy link
Member Author

neolit123 commented Jan 21, 2022

sent the following PRs to exclude kubeadm from PRR in documentation / tools:
#3171
kubernetes/sig-release#1831

@rhockenbury
Copy link

rhockenbury commented Jan 27, 2022

From the Slack thread, it feels like there is general agreement with not requiring a PRR for kubeadm. I'll mark this as tracked for enhancement freeze.

@jiahuif
Copy link
Member

jiahuif commented Jan 28, 2022

Hello @neolit123 👋, 1.24 Enhancements team here.
Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

This enhancement looks great! Thank you for the effort.

@rhockenbury
Copy link

rhockenbury commented Jan 31, 2022

Hi @neolit123 - my prior comment is a miscommunication. The comment here from the PRR team summarizes the expectations. Let me know if you plan to update to include the PRR reviewer, or if you would like to remove this KEP from the 1.24 milestone.

@neolit123
Copy link
Member Author

neolit123 commented Jan 31, 2022

hi, i have removed this KEP from the enhancement tracking sheet:
https://docs.google.com/spreadsheets/d/1T21mUTvPh70NB2eseHjCyD4LgRjyxWI9Bd1SoP8zAwA/edit#gid=1954476102
please remove the label "tracked/yes" and the milestone 1.24 from this ticket.
thank you.

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 1, 2022
@gracenng gracenng removed this from the v1.24 milestone Feb 1, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 2, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2022
@neolit123
Copy link
Member Author

neolit123 commented May 2, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 31, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2022
@neolit123
Copy link
Member Author

neolit123 commented Jul 31, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 29, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2022
@neolit123 neolit123 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
No open projects
Development

No branches or pull requests

10 participants