Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Internal Traffic Policy #2086

Open
andrewsykim opened this issue Oct 7, 2020 · 70 comments · Fixed by kubernetes/kubernetes#96600
Open

Service Internal Traffic Policy #2086

andrewsykim opened this issue Oct 7, 2020 · 70 comments · Fixed by kubernetes/kubernetes#96600
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Oct 7, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Introduce a new field spec.internalTrafficPolicy in Service that will allow clusterIP routing to be node local.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 7, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Oct 7, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 7, 2020
@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Oct 9, 2020
@rmanyari
Copy link

rmanyari commented Nov 12, 2020

Hi Andrew - I'm pretty interested in this feature and started looking at what needs to change following keps/sig-network/2086

I'll try to get a PR up in the next few days, it will be my first contribution to k8s so I'm probably going to be make blunders here and there :)

Let me know if this works for you, unless you already had planned working on this. Thanks!

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 12, 2020

@rmanyari thanks for reaching out, I had actually started some work on this feature already which I have checked in a local branch. I would love and appreciate help reviewing the upcoming PR though

@rmanyari
Copy link

rmanyari commented Nov 12, 2020

Fantastic! Just pushed a commit to my remote with the API changes: rmanyari/kubernetes@11cbdf5

Will keep poking at the actual change later tonight and I still need to read the contributions guidelines and sign the CLA and all that good stuff.

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 12, 2020

Sorry in case I didn't make my last comment clear, I meant that I started to work on this already and I'm planning to open a PR soon. But I would appreciate your help reviewing my upcoming PR :)

@rmanyari
Copy link

rmanyari commented Nov 12, 2020

Ah, got it! Sure, I can help reviewing/testing. I'll continue with my little experiment anyway just to see how far/right I would've implemented this.

@annajung annajung added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 26, 2021
@annajung annajung added this to the v1.21 milestone Jan 26, 2021
@annajung
Copy link
Member

annajung commented Jan 28, 2021

Hi @andrewsykim, 1.21 Enhancements Lead here.

For the enhancement to be included in the milestone, it must meet the following criteria:

  • [DONE] The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • The KEP must have a production readiness review

Looks like KEP does include the questionnaires, but it also requires a file under https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-network. Please make sure to create one before the enhancements freeze.

Thank you!

@annajung
Copy link
Member

annajung commented Feb 8, 2021

Hi @andrewsykim

Enhancements Freeze is tomorrow, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2166 [Update] based on #2086 (comment) PR #2441). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [DONE] The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

@maplain
Copy link

maplain commented Feb 8, 2021

@annajung KEP update proposed in #2166 is adopted in the implementation: kubernetes/kubernetes#96600

#2441 adds the PRR.

@annajung
Copy link
Member

annajung commented Feb 9, 2021

With PR #2441 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

@annajung
Copy link
Member

annajung commented Feb 16, 2021

Hi @andrewsykim

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@annajung
Copy link
Member

annajung commented Mar 1, 2021

Hi @andrewsykim

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@annajung
Copy link
Member

annajung commented Mar 4, 2021

Hey @andrewsykim

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@thockin
Copy link
Member

thockin commented Mar 4, 2021

PR for this is being discusses and reviewed. Not dead yet.

kubernetes/kubernetes#96600

@annajung
Copy link
Member

annajung commented Mar 8, 2021

Reopening the issue since all enhancement issues must be left open until enhancement graduates to stable and KEP is marked as implemented.

Also will mark this as code complete for the upcoming code freeze. If this is a mistake, please link other code PRs and ping me to notify. thank you!

@annajung annajung reopened this Mar 8, 2021
@reylejano
Copy link
Member

reylejano commented Mar 12, 2021

Hello @andrewsykim , 1.21 Docs lead here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@reylejano
Copy link
Member

reylejano commented Mar 16, 2021

Hi @andrewsykim, today is the Doc Placeholder PR deadline for the 1.21 release. If this enhancement needs new or updated docs for the 1.21 release, please make a PR to the dev-1.21 branch in the k/website repo. The PR can be a placeholder.

@thockin thockin modified the milestones: v1.25, v1.26 Jun 23, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 24, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 22, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2022
@wojtek-t
Copy link
Member

wojtek-t commented Sep 22, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 27, 2022

/label lead-opted-in
/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added lead-opted-in Denotes that an issue has been opted in to a release tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 27, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 27, 2022

Hello @andrewsykim 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to do the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@thockin
Copy link
Member

thockin commented Sep 29, 2022

Candidate for GA in 1.26

@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

Quick reminder - Enhancement freeze is about a week away. If you are still looking to get this enhancement into v1.26, please plan to get #3509 merged up.

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

With #3509 merged up, this is all set for enhancements freeze. Thanks!

@mickeyboxell
Copy link

mickeyboxell commented Oct 20, 2022

@andrewsykim Are docs required for this KEP? If so, who will be opening the docs PR for k/website?

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 1, 2022

Hi @andrewsykim @maplain @MaxRenaud 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any open k/k PRs. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked for code freeze.

As always, we are here to help should questions come up. Thanks!

@mickeyboxell
Copy link

mickeyboxell commented Nov 2, 2022

Hi @andrewsykim @maplain @MaxRenaud 👋 This enhancement is marked as Needs Docs for 1.26 release. Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time. It must be created by November 9. For more information, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in SIG-Network KEPs Nov 3, 2022
@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 7, 2022

Hey @andrewsykim @maplain @MaxRenaud,

As the Code freeze is just a day away, just wanted to confirm if there are no open PRs in the K/K repo or any repo in general for this enhancement? So that the enhancement can be marked tracked.

@MaxRenaud
Copy link

MaxRenaud commented Nov 7, 2022

I synced with Andrew and we are good to mark as tracked.

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 8, 2022

I synced with Andrew and we are good to mark as tracked.

Marked as tracked.

@mickeyboxell
Copy link

mickeyboxell commented Nov 8, 2022

Hey @andrewsykim, @maplain, and @MaxRenaud, this is a reminder to open a PR against dev-1.26 branch in the k/website repo by November 9. This PR can be just a placeholder at this time.

@mickeyboxell
Copy link

mickeyboxell commented Nov 10, 2022

Hey again @andrewsykim, @maplain, and @MaxRenaud 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday, November 15th, 2022. Thank you!

@mickeyboxell
Copy link

mickeyboxell commented Nov 14, 2022

Hey @andrewsykim, @maplain, and @MaxRenaud 👋 The k/website PR deadline is tomorrow, Tuesday, November 15th, 2022. For information about creating the PR, please take a look at Documenting for a release - PR Ready for Review. Thanks!

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 14, 2022

Thanks for the poke, I will check out the docs later today. IIRC most of the docs were written for Beta so it may be just a matter of updating the milstones in the docs from Beta -> GA

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 15, 2022

doc: kubernetes/website#37912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
SIG-Network KEPs
GA (merged, gate not removed)
Development

Successfully merging a pull request may close this issue.