Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Internal Traffic Policy #2086

Closed
andrewsykim opened this issue Oct 7, 2020 · 75 comments · Fixed by kubernetes/kubernetes#96600
Closed

Service Internal Traffic Policy #2086

andrewsykim opened this issue Oct 7, 2020 · 75 comments · Fixed by kubernetes/kubernetes#96600
Assignees
@maplain @MaxRenaud
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone
v1.28

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Oct 7, 2020 •
edited by thockin
Loading

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Introduce a new field spec.internalTrafficPolicy in Service that will allow clusterIP routing to be node local.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 7, 2020
@andrewsykim
Copy link
Member Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 7, 2020
@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Oct 9, 2020
@rmanyari
Copy link

Hi Andrew - I'm pretty interested in this feature and started looking at what needs to change following keps/sig-network/2086

I'll try to get a PR up in the next few days, it will be my first contribution to k8s so I'm probably going to be make blunders here and there :)

Let me know if this works for you, unless you already had planned working on this. Thanks!

@andrewsykim
Copy link
Member Author

@rmanyari thanks for reaching out, I had actually started some work on this feature already which I have checked in a local branch. I would love and appreciate help reviewing the upcoming PR though

@rmanyari
Copy link

Fantastic! Just pushed a commit to my remote with the API changes: rmanyari/kubernetes@11cbdf5

Will keep poking at the actual change later tonight and I still need to read the contributions guidelines and sign the CLA and all that good stuff.

@andrewsykim
Copy link
Member Author

Sorry in case I didn't make my last comment clear, I meant that I started to work on this already and I'm planning to open a PR soon. But I would appreciate your help reviewing my upcoming PR :)

@rmanyari
Copy link

Ah, got it! Sure, I can help reviewing/testing. I'll continue with my little experiment anyway just to see how far/right I would've implemented this.

@maplain maplain mentioned this issue Nov 16, 2020
Merged
@annajung annajung added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 26, 2021
@annajung annajung added this to the v1.21 milestone Jan 26, 2021
@annajung
Copy link
Contributor

Hi @andrewsykim, 1.21 Enhancements Lead here.

For the enhancement to be included in the milestone, it must meet the following criteria:

  • [DONE] The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • The KEP must have a production readiness review

Looks like KEP does include the questionnaires, but it also requires a file under https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-network. Please make sure to create one before the enhancements freeze.

Thank you!

@annajung annajung mentioned this issue Feb 3, 2021
Closed
@annajung
Copy link
Contributor

annajung commented Feb 8, 2021 •
edited
Loading

Hi @andrewsykim

Enhancements Freeze is tomorrow, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2166 [Update] based on #2086 (comment) PR #2441). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [DONE] The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

@maplain
Copy link

maplain commented Feb 8, 2021

@annajung KEP update proposed in #2166 is adopted in the implementation: kubernetes/kubernetes#96600

#2441 adds the PRR.

@annajung
Copy link
Contributor

annajung commented Feb 9, 2021

With PR #2441 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

@annajung
Copy link
Contributor

Hi @andrewsykim

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@annajung
Copy link
Contributor

annajung commented Mar 1, 2021

Hi @andrewsykim

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@annajung
Copy link
Contributor

annajung commented Mar 4, 2021

Hey @andrewsykim

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@thockin
Copy link
Member

thockin commented Mar 4, 2021

PR for this is being discusses and reviewed. Not dead yet.

kubernetes/kubernetes#96600

@annajung
Copy link
Contributor

annajung commented Mar 8, 2021

Reopening the issue since all enhancement issues must be left open until enhancement graduates to stable and KEP is marked as implemented.

Also will mark this as code complete for the upcoming code freeze. If this is a mistake, please link other code PRs and ping me to notify. thank you!

@annajung annajung reopened this Mar 8, 2021
@reylejano
Copy link
Member

Hello @andrewsykim , 1.21 Docs lead here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@reylejano
Copy link
Member

Hi @andrewsykim, today is the Doc Placeholder PR deadline for the 1.21 release. If this enhancement needs new or updated docs for the 1.21 release, please make a PR to the dev-1.21 branch in the k/website repo. The PR can be a placeholder.

@maplain maplain mentioned this issue Mar 17, 2021
Merged
@parul5sahoo
Copy link

parul5sahoo commented Nov 7, 2022 •
edited
Loading

Hey @andrewsykim @maplain @MaxRenaud,

As the Code freeze is just a day away, just wanted to confirm if there are no open PRs in the K/K repo or any repo in general for this enhancement? So that the enhancement can be marked tracked.

@MaxRenaud
Copy link

I synced with Andrew and we are good to mark as tracked.

@parul5sahoo
Copy link

I synced with Andrew and we are good to mark as tracked.

Marked as tracked.

@mickeyboxell
Copy link

Hey @andrewsykim, @maplain, and @MaxRenaud, this is a reminder to open a PR against dev-1.26 branch in the k/website repo by November 9. This PR can be just a placeholder at this time.

@mickeyboxell
Copy link

Hey again @andrewsykim, @maplain, and @MaxRenaud 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday, November 15th, 2022. Thank you!

@mickeyboxell
Copy link

Hey @andrewsykim, @maplain, and @MaxRenaud 👋 The k/website PR deadline is tomorrow, Tuesday, November 15th, 2022. For information about creating the PR, please take a look at Documenting for a release - PR Ready for Review. Thanks!

@andrewsykim
Copy link
Member Author

Thanks for the poke, I will check out the docs later today. IIRC most of the docs were written for Beta so it may be just a matter of updating the milstones in the docs from Beta -> GA

@andrewsykim andrewsykim mentioned this issue Nov 15, 2022
Merged
@andrewsykim
Copy link
Member Author

doc: kubernetes/website#37912

@marosset
Copy link
Contributor

Hi @andrewsykim - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/2086-service-internal-traffic-policy/kep.yaml setting the status to implemented and then close this issue.
Thanks!

@marosset marosset removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Dec 13, 2022
@thockin thockin moved this to net in KEPs I am tracking Dec 20, 2022
@thockin thockin modified the milestones: v1.26, v1.28 Jan 5, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2023
@thockin
Copy link
Member

thockin commented Apr 5, 2023

@andrewsykim can you update the main issue here with release numbers?

@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2023
@thockin
Copy link
Member

thockin commented Apr 27, 2023

NEXT: Remove gate in 1.28

@thockin thockin mentioned this issue Apr 27, 2023
Merged
@thockin
Copy link
Member

thockin commented Apr 28, 2023

DONE

@thockin thockin closed this as completed Apr 28, 2023
@thockin thockin moved this to Done in SIG Network KEPs Jun 14, 2023
@phillebaba phillebaba mentioned this issue Jun 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maplain maplain

@MaxRenaud MaxRenaud

Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
(Test board) Kubernetes 1.26 Enhancements Tracking
Status: New New
1.26 Enhancements Tracking
Status: Graduating
SIG Network KEPs
Status: Done
Milestone
v1.28
Development

Successfully merging a pull request may close this issue.

Service Internal Traffic Policy maplain/kubernetes