Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Credential Provider #2133

Open
3 of 4 tasks
andrewsykim opened this issue Nov 6, 2020 · 78 comments
Open
3 of 4 tasks

Kubelet Credential Provider #2133

andrewsykim opened this issue Nov 6, 2020 · 78 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Milestone

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Nov 6, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Support exec plugins to retrieve image pull credentials for the kubelet.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 6, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 6, 2020

/sig cloud-provider

(but involves SIG node and SIG auth as well)

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2020
@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Nov 9, 2020
@kikisdeliveryservice kikisdeliveryservice added this to the v1.20 milestone Nov 9, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 9, 2020

Hi @andrewsykim

This was an exception that was conditionally approved on Nov6 (https://groups.google.com/g/kubernetes-sig-release/c/rYXqvvt4aDI/m/t1vL3HbsAwAJ) on updating the KEP the the new format. Please link once the PR is open.

Also please link all related PRs to this issue so that we can track it.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 13, 2020

PR addressing requested updates as per exception: #2151

@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 7, 2021
@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@andrewsykim
Copy link
Member Author

andrewsykim commented Jan 15, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 15, 2021
@andrewsykim andrewsykim added this to the v1.21 milestone Jan 20, 2021
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 3, 2021
@annajung
Copy link
Member

annajung commented Feb 3, 2021

Hi @andrewsykim,

For the enhancement to be included in the milestone, it must meet the following criteria:

  • [DONE] The KEP must be merged in an implementable state
  • The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • The KEP must have a production readiness review

The test plan for beta is missing in the KEP, so please remember to update to include that.

Also starting 1.21, all KEP must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include answers to the questionnaires required for beta and a file under https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-node.

Thank you!

@annajung
Copy link
Member

annajung commented Feb 7, 2021

Hi @andrewsykim

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is NOT tracking any open PR for a KEP update. Please make sure to work on missing requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the KEP requirements by the freeze will require an exception.

@ehashman
Copy link
Member

ehashman commented Feb 8, 2021

#2457

@annajung
Copy link
Member

annajung commented Feb 9, 2021

With PR #2457 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

@annajung
Copy link
Member

annajung commented Feb 16, 2021

Hi @andrewsykim

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@annajung
Copy link
Member

annajung commented Mar 1, 2021

Hi @andrewsykim

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@annajung
Copy link
Member

annajung commented Mar 4, 2021

Hey @andrewsykim

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@annajung
Copy link
Member

annajung commented Mar 10, 2021

Hi @andrewsykim, with code freeze now in effect, we are removing this enhancement from 1.21 release due to no code PR being tracked for this enhancement.

If needed, feel free to file an exception to add this back into the release. thanks!

@annajung annajung removed this from the v1.21 milestone Mar 10, 2021
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 3, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 27, 2022

/label lead-opted-in
/milestone v1.26
/label tracked/yes
/remove-label tracked/no
/stage stable

@k8s-ci-robot k8s-ci-robot added lead-opted-in Denotes that an issue has been opted in to a release stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 27, 2022
@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 27, 2022
@parul5sahoo
Copy link
Member

parul5sahoo commented Sep 28, 2022

Hello @ruiwen-zhao 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following before enhancements freeze:

  • Update the milestone in kep.yaml to 1.26. which I see an open PR for so will be checked once it get merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. And let us know if you have any queries.
Thank you!

@ruiwen-zhao
Copy link
Contributor

ruiwen-zhao commented Sep 28, 2022

Hi @parul5sahoo , i believe the current README [1] is using the latest template and has detailed test plan section. Can you elaborate what's missing there?

[1] https://github.com/kubernetes/enhancements/blob/5d140818264fe0ade8ba326dc659ffae88e5f629/keps/sig-node/2133-kubelet-credential-providers/README.md

@parul5sahoo
Copy link
Member

parul5sahoo commented Sep 29, 2022

@ruiwen-zhao I probably missed the checked agreement on line 340. Sorry, my bad. So we will mark the enhancement tracked once the open PR for updating the milestone is merged.

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 4, 2022

Hello @ruiwen-zhao 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 1, 2022

Hi @adisky, @andrewsykim and @ruiwen-zhao 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any open k/k PRs. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked for code freeze.

As always, we are here to help should questions come up. Thanks!

@katmutua
Copy link

katmutua commented Nov 1, 2022

Hello @andrewsykim ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 1, 2022

Updated the enhancement issue description with the merged PRs

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 7, 2022

Hey @andrewsykim ,

As the Code freeze is just a day away, just wanted to confirm that there are no open PRs in the K/K repo or any repo in general for this enhancement other than the ones outlined in the issue description? So that the enhancement can be marked tracked.

@ruiwen-zhao
Copy link
Contributor

ruiwen-zhao commented Nov 7, 2022

@parul5sahoo there are no open PRs for this enhancement other than the doc updates.

For GCP credential provider (https://github.com/kubernetes/cloud-provider-gcp ) we might need to update the api version used, but that is not in the scope of this enhancement.

@krol3
Copy link

krol3 commented Nov 10, 2022

Hello @andrewsykim and @ruiwen-zhao 👋, 1.26 Docs Lead here.
Today is the 1.26 Docs Placeholder PR Deadline.
If this enhancement requires any new docs or modification to existing docs, please follows the steps here to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before the end of today.
Thank you

@ruiwen-zhao
Copy link
Contributor

ruiwen-zhao commented Nov 10, 2022

I believe @andrewsykim has created a PR already: kubernetes/website#37647

@krol3
Copy link

krol3 commented Nov 15, 2022

Hi @ruiwen-zhao and @andrewsykim the PR about documentation. Related to Feature gates for Alpha or Beta features table:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

cc: @katmutua

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 16, 2022

Doc update: kubernetes/website#37920

@krol3
Copy link

krol3 commented Dec 2, 2022

@andrewsykim is this PR kubernetes/website#38139 the doc related 1.26 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
SIG Auth
In Review
Development

No branches or pull requests