Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply for client-go's typed clients #2155

Closed
4 tasks done
jpbetz opened this issue Nov 17, 2020 · 19 comments
Closed
4 tasks done

Apply for client-go's typed clients #2155

jpbetz opened this issue Nov 17, 2020 · 19 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/api-expression Categorizes an issue or PR as relevant to WG API Expression.
Milestone

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Nov 17, 2020

Apply for client-go's typed clients

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig api-machinery
/wg api-expression
/cc @jennybuckley @apelisse @kwiesmueller @DirectXMan12

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. wg/api-expression Categorizes an issue or PR as relevant to WG API Expression. labels Nov 17, 2020
@deads2k
Copy link
Contributor

deads2k commented Feb 5, 2021

/milestone 1.21
/stage stable

This is a sub-kep of #555

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 5, 2021

@deads2k: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.21
/stage stable

This is a sub-kep of #555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Feb 5, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 5, 2021
@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 5, 2021
@annajung
Copy link
Member

annajung commented Feb 7, 2021

Hi @jpbetz

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2419). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 8, 2021

Thanks @annajung The KEP is now merged. The merge includes PRR review and graduation criteria. I'll update this PR description with a link to the merged KEP.

@annajung
Copy link
Member

annajung commented Feb 9, 2021

With PR #2419 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 19, 2021

Hi @jpbetz,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@JamesLaverack
Copy link
Member

JamesLaverack commented Mar 6, 2021

Hi @jpbetz,

A friendly reminder that Code freeze is 3 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 8, 2021

Quick update: The primary PRs to add this feature have merged. The two smaller PRs are under review and we expect them to make it in for the March 9th code freeze.

@annajung
Copy link
Member

annajung commented Mar 11, 2021

Hi @jpbetz, with the following PRs merged in, we will mark this as code complete for 1.21 release.

@reylejano
Copy link
Member

reylejano commented Mar 12, 2021

Hello @jpbetz, 1.21 Docs lead here.
I saw that new documentation is needed for 1.21 in kubernetes/website#25785
Just a reminder to make a PR (which can be a placeholder) against the dev-1.21 branch in the k/website repo by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 15, 2021

Thanks @reylejano. A couple updates:

  • Since the and we're deferring GA of Server Side Apply to 1.22. I've changed this from "stable" to "beta" for this release.
  • We only link to client libraries from the main kubernetes documentation (https://kubernetes.io/docs/reference/using-api/client-libraries). I'm reviewing the client-go documentation but I don't think there are any immediate changes I need to make, so I'm marking documentation done for this issue.

@annajung annajung added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Apr 8, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 26, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021
@jpbetz
Copy link
Contributor Author

jpbetz commented Jul 27, 2021

Server-side apply is going to GA in 1.22 (it didn't quite make the 1.21 release), and this change will go GA as part of SSA. We should probably update the milestone to match (I don't have permissions for that).

@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 26, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 26, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 25, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 25, 2021

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apelisse
Copy link
Member

apelisse commented Sep 28, 2021

I guess we should keep this closed, but the milestone doesn't really reflect the situation. Not sure I'm willing to care for that.

@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 29, 2021

I guess we should keep this closed, but the milestone doesn't really reflect the situation. Not sure I'm willing to care for that.

There are some comments clarifying (for anyone that bothers to read down to them). I'm okay with leaving this as-is..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/api-expression Categorizes an issue or PR as relevant to WG API Expression.
Projects
None yet
Development

No branches or pull requests

8 participants