Apply for client-go's typed clients

[jpbetz]

Apply for client-go's typed clients

• One-line enhancement description (can be used as a release note): Add typesafe Apply support to client-go's typed clients.

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/2155-clientgo-apply

• Discussion Link: discussion at kubebuilder/controller-tools meeting, discussion at sig-api-machinery meeting

• Primary contact (assignee): jpbetz@

• Responsible SIGs: sig-api-machinery, wg-api-expression,

• Enhancement target (which target equals to which milestone):

  • As a subproject of Server Side Apply, and as a pre-requisite of Server Side Apply graduating to GA, this enhancement will have the same stability level as Server Side Apply. It will not have a separately tracked stability level. Since Server Side Apply is currently Beta, this enhancement currently focuses on achieving what is required to go to GA.

• Beta

  • KEP (k/enhancements) update PR(s): Provisional KEP: Apply for client-go's typed clients #2156, Apply for client-go's typed clients #2155
  • Code (k/k) update PR(s): Apply Builders for client-go's typed client kubernetes#99012, Add Apply to client-go's typed client kubernetes#99214, Add Extract support to client-go apply builders kubernetes#99759, Migrate cluster role aggregator to apply kubernetes#99462
  • Docs (k/website) update(s): Changes are isolated to client-go, which is not documented on the kubernetes website

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig api-machinery
/wg api-expression
/cc @jennybuckley @apelisse @kwiesmueller @DirectXMan12

[deads2k]

/milestone 1.21
/stage stable

This is a sub-kep of #555

[k8s-ci-robot]

@deads2k: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.21
/stage stable

This is a sub-kep of #555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deads2k]

/milestone v1.21

[annajung]

Hi @jpbetz

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2419). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

• [IN PROGRESS] The KEP must be merged in an implementable state
• [DONE] The KEP must have test plans
• [IN PROGRESS] The KEP must have graduation criteria
• [IN PROGRESS] The KEP must have a production readiness review

[jpbetz]

Thanks @annajung The KEP is now merged. The merge includes PRR review and graduation criteria. I'll update this PR description with a link to the merged KEP.

[annajung]

With PR #2419 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

[JamesLaverack]

Hi @jpbetz,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

• Tuesday, March 9th: Week 9 — Code Freeze
• Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
  • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

[JamesLaverack]

Hi @jpbetz,

A friendly reminder that Code freeze is 3 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

[jpbetz]

Quick update: The primary PRs to add this feature have merged. The two smaller PRs are under review and we expect them to make it in for the March 9th code freeze.

[annajung]

Hi @jpbetz, with the following PRs merged in, we will mark this as code complete for 1.21 release.

• Apply Builders for client-go's typed client kubernetes#99012
• Add Apply to client-go's typed client kubernetes#99214
• Add Extract support to client-go apply builders kubernetes#99759
• Migrate cluster role aggregator to apply kubernetes#99462

[reylejano]

Hello @jpbetz, 1.21 Docs lead here.
I saw that new documentation is needed for 1.21 in kubernetes/website#25785
Just a reminder to make a PR (which can be a placeholder) against the dev-1.21 branch in the k/website repo by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[jpbetz]

Thanks @reylejano. A couple updates:

• Since the and we're deferring GA of Server Side Apply to 1.22. I've changed this from "stable" to "beta" for this release.
• We only link to client libraries from the main kubernetes documentation (https://kubernetes.io/docs/reference/using-api/client-libraries). I'm reviewing the client-go documentation but I don't think there are any immediate changes I need to make, so I'm marking documentation done for this issue.

[k8s-triage-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[jpbetz]

Server-side apply is going to GA in 1.22 (it didn't quite make the 1.21 release), and this change will go GA as part of SSA. We should probably update the milestone to match (I don't have permissions for that).

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[apelisse]

I guess we should keep this closed, but the milestone doesn't really reflect the situation. Not sure I'm willing to care for that.

[jpbetz]

I guess we should keep this closed, but the milestone doesn't really reflect the situation. Not sure I'm willing to care for that.

There are some comments clarifying (for anyone that bothers to read down to them). I'm okay with leaving this as-is..