Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic "metadata.name" labels for all Namespaces #2161

Closed
4 tasks
jayunit100 opened this issue Nov 22, 2020 · 26 comments · Fixed by #2162
Closed
4 tasks

Automatic "metadata.name" labels for all Namespaces #2161

jayunit100 opened this issue Nov 22, 2020 · 26 comments · Fixed by #2162
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@jayunit100
Copy link
Member

jayunit100 commented Nov 22, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 22, 2020
@jayunit100
Copy link
Member Author

jayunit100 commented Nov 22, 2020

/sig apimachinery

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2020

@jayunit100: The label(s) sig/apimachinery cannot be applied, because the repository doesn't have them

In response to this:

/sig apimachinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jayunit100
Copy link
Member Author

jayunit100 commented Nov 22, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2020
@rikatz
Copy link
Contributor

rikatz commented Nov 22, 2020

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 22, 2020
@jayunit100
Copy link
Member Author

jayunit100 commented Nov 22, 2020

https://hackmd.io/Yc9TyoQOQ0e8KgDLK8m2Eg <-- on the kep here w/ @rikatz

@jayunit100
Copy link
Member Author

jayunit100 commented Jan 21, 2021

wait i think this cant be closed until the entire kep is completed, right?

@jayunit100 jayunit100 reopened this Jan 21, 2021
@deads2k deads2k added this to the v1.21 milestone Feb 9, 2021
@deads2k deads2k added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Feb 9, 2021
@deads2k
Copy link
Contributor

deads2k commented Feb 9, 2021

/milestone v1.21
/stage beta

@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 9, 2021
@annajung
Copy link
Member

annajung commented Feb 9, 2021

With PR #2284 merged, this enhancement meets all the criteria for the Enhancements freeze 👍

@arunmk
Copy link

arunmk commented Feb 20, 2021

Hi @jayunit100,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@arunmk
Copy link

arunmk commented Mar 2, 2021

Hi @jayunit100,

Enhancements team does not have a linked PR to track for the upcoming code freeze. Could you please link a PR to this KEP so that we may track it.

We are currently marking this KEP as 'At Risk' for the upcoming code freeze on 3/9.

Thanks

@arunmk
Copy link

arunmk commented Mar 6, 2021

Hi @jayunit100,

A friendly reminder that Code freeze is 4 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@annajung
Copy link
Member

annajung commented Mar 9, 2021

Hi @jayunit100, with kubernetes/kubernetes#96968 merged, we will mark this as code complete for the upcoming code freeze.

@PI-Victor
Copy link
Member

PI-Victor commented Mar 10, 2021

Hello @jayunit100, 1.21 Docs shadow here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@rikatz
Copy link
Contributor

rikatz commented Mar 10, 2021

Hi @PI-Victor :)

I've added the missing docs.

Thanks!

@aojea aojea added this to Beta in SIG-Network KEPs Apr 17, 2021
@JamesLaverack JamesLaverack added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Apr 25, 2021
@thockin thockin changed the title APIServer defaulted labels for all Namespaces Automatic "metadata.name" labels for all Namespaces Apr 30, 2021
@JamesLaverack JamesLaverack added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 13, 2021
@JamesLaverack JamesLaverack modified the milestones: v1.21, v1.22 May 13, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 13, 2021

Hey @jayunit100, 1.22 Enhancements Lead here.

Just a couple of questions about this enhancement ahead of enhancements freeze:

  • What is your graduation criteria for stable? Your KEP only mentions "This feature being enabled by default at least one release." was that for beta? What specificly needs to be permitted for stable?
  • We require an approved production readiness review, but I don't see one at the stable stage. Have you reached out to the PRR team about this graduation?
  • You have SIG Network listed as an associated SIG. Do SIG Network need to do anything for this graduation, and if so are they signed on to doing that in 1.22?

Please let me know if you have any questions.

@JamesLaverack
Copy link
Member

JamesLaverack commented May 13, 2021

With #2736 and #2651 merged, this enhancement is complete for enhancements freeze.

@jayunit100 Can you clarify if SIG Network need to do anything?

@chrisnegus
Copy link

chrisnegus commented May 19, 2021

Hi @jayunit100 ! I'm @chrisnegus , a Docs Shadow for release 1.22.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@thockin thockin moved this from Beta (merged) to GA (merged, gate not removed) in SIG-Network KEPs May 22, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented Jun 21, 2021

Hey @jayunit100, can you confirm if kubernetes/kubernetes#101342 is the only k/k PR required for this enhancement in 1.22?

@JamesLaverack
Copy link
Member

JamesLaverack commented Jul 3, 2021

Hey again @jayunit100. Can I quickly ask you to confirm if kubernetes/kubernetes#101342 is the only k/k PR required for this enhancement in v1.22? If it isn't then as a reminder the deadline for code freeze is in five days on Thursday 8th July at 18:00 PDT.

As an additional reminder, the docs placeholder PR deadline is the day after code freeze on Friday 9th July.

@rikatz
Copy link
Contributor

rikatz commented Jul 3, 2021

@JamesLaverack Jay is on PTO this week, but I can confirm this is the only required PR to make this GA.

Next step is to remove at all the featuregate and the codes containing the FG, probably in next release :)

@JamesLaverack
Copy link
Member

JamesLaverack commented Jul 4, 2021

Great, thank you for confirming @rikatz. I believe this enhancement is all good to go for v1.22 code freeze. :)

@PI-Victor
Copy link
Member

PI-Victor commented Jul 6, 2021

Hi @jayunit100 ! I'm @chrisnegus , a Docs Shadow for release 1.22.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@rikatz hello again, friendly reminder about the upcoming docs placeholder PR Fri July 9, 11:59 PM PDT, thanks!

@PI-Victor
Copy link
Member

PI-Victor commented Jul 9, 2021

@rikatz Today is docs placeholder deadline, please submit a placeholder PR by the end of the day, today!

@rikatz
Copy link
Contributor

rikatz commented Jul 9, 2021

Hey @PI-Victor

was looking at this yesterday and figured out someone already updated the feature gate docs and the other docs are correct, so this one is Ok and no new doc is necessary :)

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 18, 2021
@salaxander
Copy link

salaxander commented Aug 19, 2021

@jayunit100 @rikatz - With the KEP status marked as implemented, I'm going to close out this issue. Great job everyone!

@thockin thockin modified the milestones: v1.22, v1.25 Feb 16, 2022
@thockin
Copy link
Member

thockin commented Feb 16, 2022

Reminder: Remove gate in 1.25, milestone updated

@thockin thockin moved this from GA (merged, gate not removed) to No gates in SIG-Network KEPs Mar 31, 2022
@thockin thockin moved this from No gates to GA forever! in SIG-Network KEPs Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
SIG-Network KEPs
GA (merged, gate removed)
Development

Successfully merging a pull request may close this issue.