Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Pod selection on ReplicaSet downscaling #2185

Closed
5 of 8 tasks
alculquicondor opened this issue Dec 15, 2020 · 43 comments
Closed
5 of 8 tasks

Random Pod selection on ReplicaSet downscaling #2185

alculquicondor opened this issue Dec 15, 2020 · 43 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@alculquicondor
Copy link
Member

alculquicondor commented Dec 15, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 15, 2020
@alculquicondor
Copy link
Member Author

alculquicondor commented Dec 15, 2020

/sig apps
/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 15, 2020
@alculquicondor
Copy link
Member Author

alculquicondor commented Dec 15, 2020

cc @damemi

@damemi
Copy link
Contributor

damemi commented Dec 15, 2020

/assign

@damemi
Copy link
Contributor

damemi commented Jan 5, 2021

Haven't fogotten about this, just didn't get it in time for the new year... will open a PR soon based on @alculquicondor's draft

@damemi
Copy link
Contributor

damemi commented Jan 6, 2021

Filled out most of the sections and opened a KEP here: #2233

Looking for anything I missed or could improve on. Pretty straightforward mostly since it's not affecting a user-documented behavior

@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 5, 2021
@annajung annajung added this to the v1.21 milestone Feb 5, 2021
@annajung annajung added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 5, 2021
@jrsapi
Copy link

jrsapi commented Feb 18, 2021

Greetings @damemi!
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
• If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!

@damemi
Copy link
Contributor

damemi commented Feb 18, 2021

xref - wip PR kubernetes/kubernetes#96898

I'll be picking up this PR and working to get that merged for code freeze. Thanks for the update @jrsapi !

@damemi
Copy link
Contributor

damemi commented Feb 18, 2021

Opened new PR in kubernetes/kubernetes#99212

@jrsapi
Copy link

jrsapi commented Mar 4, 2021

Greetings @damemi,

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST
Any enhancements that are NOT code complete by the freeze will be removed from the milestone will require an exception to be added back.
Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST.
Thanks!

@alculquicondor
Copy link
Member Author

alculquicondor commented Mar 8, 2021

Should we consider any updates to documentation for this? https://kubernetes.io/docs/concepts/workloads/controllers/replicaset/#scaling-a-replicaset

Current documentation doesn't give any details about internal selection, which might still be desired.

@janetkuo @soltysh

@janetkuo
Copy link
Member

janetkuo commented Mar 8, 2021

Yes, please update docs and the feature gate for this.

@PI-Victor
Copy link
Member

PI-Victor commented Mar 10, 2021

Hello @damemi, 1.21 Docs shadow here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@damemi
Copy link
Contributor

damemi commented Mar 10, 2021

Yeah, I will open a PR to update the docs Aldo linked above

@damemi
Copy link
Contributor

damemi commented Mar 10, 2021

Docs PR opened at kubernetes/website#26993, which just copies the comments from code into the docs

@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@damemi
Copy link
Contributor

damemi commented Jun 23, 2021

@reylejano yes, that and the docs PR (kubernetes/website#28102) are all that is needed for this. Thanks!

@reylejano
Copy link
Member

reylejano commented Jul 1, 2021

Hi @damemi ,

Just a reminder that the 1.22 code freeze starts next week on July 8, 2021.
We're tracking kubernetes/kubernetes#101767 for 1.22.
Looks like you're set for the 1.22 Docs Placeholder PR deadline (July 9, 2021) with kubernetes/website#28102

@reylejano
Copy link
Member

reylejano commented Jul 6, 2021

Hi @damemi ,

The 1.22 code freeze starts in a few days on Thursday, July 8 at 18:00 PDT. The following PR and any other PR required for this enhancement for 1.22 has to merge by then:

This enhancement is currently at-risk of falling out of 1.22 with kubernetes/kubernetes#101767 open

@damemi
Copy link
Contributor

damemi commented Jul 6, 2021

@reylejano that PR was tagged for merge this morning and should have no issues making it in by Thursday 🙂

@reylejano
Copy link
Member

reylejano commented Jul 8, 2021

Hi @damemi ,

This enhancement is all set for the 1.22 code freeze 🎉

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@alculquicondor
Copy link
Member Author

alculquicondor commented Nov 22, 2021

/remove-lifecycle stale

should be ready for GA in 1.24

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Feb 20, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Mar 22, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 22, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Apr 21, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 21, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi
Copy link
Contributor

damemi commented May 3, 2022

@alculquicondor did this ever move to GA?

@alculquicondor
Copy link
Member Author

alculquicondor commented May 3, 2022

/reopen

No, still beta

@k8s-ci-robot k8s-ci-robot reopened this May 3, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 3, 2022

@alculquicondor: Reopened this issue.

In response to this:

/reopen

No, still beta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@janetkuo
Copy link
Member

janetkuo commented May 13, 2022

I removed 1.23 from Stable release target (x.y) in the issue description to avoid confusion.

@soltysh
Copy link
Contributor

soltysh commented Jun 8, 2022

/milestone clear
since you can always check the latest-milestone in https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/kep.yaml

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone Jun 8, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 8, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 8, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests