Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexed Job semantics in Job API #2214

Closed
12 tasks done
alculquicondor opened this issue Dec 22, 2020 · 29 comments
Closed
12 tasks done

Indexed Job semantics in Job API #2214

alculquicondor opened this issue Dec 22, 2020 · 29 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@alculquicondor
Copy link
Member

alculquicondor commented Dec 22, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 22, 2020
@alculquicondor
Copy link
Member Author

alculquicondor commented Dec 22, 2020

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 22, 2020
@alculquicondor
Copy link
Member Author

alculquicondor commented Jan 6, 2021

/area batch

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 6, 2021

@alculquicondor: The label(s) area/batch cannot be applied, because the repository doesn't have them

In response to this:

/area batch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor alculquicondor changed the title Array Job semantics in Job API Indexed Job semantics in Job API Jan 12, 2021
@annajung annajung added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 27, 2021
@annajung annajung added this to the v1.21 milestone Jan 27, 2021
@ahg-g
Copy link
Member

ahg-g commented Feb 3, 2021

@annajung @JamesLaverack James, you mentioned in the sig-apps slack channel that this enhancement is at risk, can you clarify why?

@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 4, 2021

Just to follow up here after further discussion in Slack, that was a mistaken state due to a delay in review. Sorry for the delay on this. I've now marked this enhancement as tracked (and not at risk) for 1.21 on the tracking sheet.

@alculquicondor
Copy link
Member Author

alculquicondor commented Feb 5, 2021

/assign

@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 19, 2021

Hi @alculquicondor,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@JamesLaverack
Copy link
Member

JamesLaverack commented Mar 6, 2021

Hi @alculquicondor,

A friendly reminder that Code freeze is 3 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@alculquicondor
Copy link
Member Author

alculquicondor commented Mar 8, 2021

Thanks James. There is only one minor bugfix open kubernetes/kubernetes#99865 and I just opened the docs placeholder

@annajung
Copy link
Member

annajung commented Mar 10, 2021

@alculquicondor
Copy link
Member Author

alculquicondor commented Mar 10, 2021

Perfect, thank you

@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@ahg-g
Copy link
Member

ahg-g commented Nov 18, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2021
@alculquicondor
Copy link
Member Author

alculquicondor commented Nov 22, 2021

Probably ready for graduation in 1.24

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 22, 2022
@gracenng gracenng modified the milestones: v1.22, v1.24 Jan 22, 2022
@gracenng
Copy link
Member

gracenng commented Jan 22, 2022

Hi @alculquicondor ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting stable for 1.24
Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo -- Graduate Indexed Job to stable #3113
  • KEP status is marked as implementable for this release with latest-milestone: 1.24
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk. Please update this issue description to reflect enhancements target
Thanks!

@gracenng
Copy link
Member

gracenng commented Jan 30, 2022

The status for 1.24 Enhancementsis now tracked 🥳

@heyleke
Copy link

heyleke commented Feb 11, 2022

Not sure if this is the right place to ask, but we noticed in the docs following comment:

Note that, although rare, more than one Pod could be started for the same
index, but only one of them will count towards the completion count.

Can it be clarified why that note is needed? And if the pod is started, will it run to completion, or aborted before running or ... ?

@alculquicondor
Copy link
Member Author

alculquicondor commented Feb 11, 2022

Can you open an issue in github.com/kubernetes/website? We can clarify that it will be aborted.

@mehabhalodiya
Copy link

mehabhalodiya commented Feb 12, 2022

Hi @alculquicondor 👋🏻 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@gracenng gracenng added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Mar 16, 2022
@gracenng
Copy link
Member

gracenng commented Mar 16, 2022

Hi @alculquicondor 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, we are currently tracking the following k/k PR:

The status of this enhancement is at risk until the PRs are merged. Please let me know if I'm missing any. Thanks!

@gracenng
Copy link
Member

gracenng commented Mar 29, 2022

All good for 1.24 Code Freeze 🥳

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 9, 2022

Hello @alculquicondor 👋 1.25 Enhancements team here.

Since this feature has been fully implemented and is now GA in K8s version v1.24 🎉 (which is also properly updated in the status of the kep.yaml file).

I'm closing this issue for the purpose of accurate tracking for v1.25. Thank you so much for your valuable contributions. 🙏 🙂

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 9, 2022

@Priyankasaggu11929: Closing this issue.

In response to this:

Hello @alculquicondor 👋 1.25 Enhancements team here.

Since this feature has been fully implemented and is now GA in K8s version v1.24 🎉 (which is also properly updated in the status of the kep.yaml file).

I'm closing this issue for the purpose of accurate tracking for v1.25. Thank you so much for your valuable contributions. 🙏 🙂

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests