Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default container annotation that to be used by kubectl #2227 #2227

Open
5 tasks done
pacoxu opened this issue Jan 3, 2021 · 41 comments · Fixed by kubernetes/kubernetes#109254
Open
5 tasks done

default container annotation that to be used by kubectl #2227 #2227

pacoxu opened this issue Jan 3, 2021 · 41 comments · Fixed by kubernetes/kubernetes#109254
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@pacoxu
Copy link
Member

pacoxu commented Jan 3, 2021

I opened kubernetes/kubernetes#97099
Fixes kubernetes/kubernetes#96986, a similar solution like kubernetes/kubernetes#87809

Enhancement Description

  • One-line enhancement description (can be used as a release note): Users might specify the kubectl.kubernetes.io/default-container annotation in a Pod to preselect container for kubectl exec.
  • Kubernetes Enhancement Proposal: add KEP-2227 for default container used by kubectl #2189
  • Discussion Link: There is discussion in Need a way to set default container kubernetes#95293 which is in process for general default container.
  • Primary contact (assignee): @pacoxu
  • Responsible SIGs: sig/cli
  • Enhancement target (which target equals which milestone):
    • Alpha release target (x.y):
    • Beta release target (x.y): 1.21
    • Stable release target (x.y): 1.26

const defaultLogsContainerAnnotationName = "kubectl.kubernetes.io/default-logs-container"
It is deprecated and will be removed in 1.25.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 3, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 3, 2021

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 3, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 13, 2021

#2189 is updated now as well as the PR #97099.
/assign

@dougsland @howardjohn Thanks for review of the KEP. What would be the next step for this? I'm not quite familiar with the process.

@dougsland
Copy link
Member

dougsland commented Jan 13, 2021

#2189 is updated now as well as the PR #97099.
/assign

@dougsland @howardjohn Thanks for review of the KEP. What would be the next step for this? I'm not quite familiar with the
process.

I have added the enhancement #2189 to SIG Cli agenda asking people to take a look when they have free time. We need more people to review.

@pacoxu pacoxu changed the title default container annotation that to be used by kubectl #2189 default container annotation that to be used by kubectl #2227 Feb 2, 2021
@rikatz
Copy link
Contributor

rikatz commented Feb 2, 2021

Hey,

We have #2227 and #2368 , what is the difference between them?

@pacoxu
Copy link
Member Author

pacoxu commented Feb 3, 2021

@rikatz I closed #2368 and will update the KEP pr.

@soltysh
Copy link
Contributor

soltysh commented Feb 3, 2021

/stage alpha
/milestone v1.21
/kind feature

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. labels Feb 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 3, 2021
@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 3, 2021
@jrsapi
Copy link

jrsapi commented Feb 5, 2021

Greetings @pacoxu,

This is Joseph v1.21 enhancement shadow checking in. For the enhancement to be included in the 1.21 milestone, it must meet the following criteria:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have a production readiness review

Starting v1.21, all KEPs must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include all steps. Let us know if we can be of any assistance.

Thank you!

@soltysh
Copy link
Contributor

soltysh commented Feb 5, 2021

@jrsapi the enhancement is approved both by sig-leads and PRR approvers, it's awaiting small update and should merge on time.

@jrsapi
Copy link

jrsapi commented Feb 8, 2021

Greetings @soltysh @pacoxu,
Thanks for the update. Reminder that enhancement freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR [#2189]. Please make sure the updates get done and pr merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria
[DONE] The KEP must have a production readiness review

@pacoxu
Copy link
Member Author

pacoxu commented Feb 8, 2021

/assign

@soltysh
Copy link
Contributor

soltysh commented Feb 8, 2021

[IN PROGRESS] The KEP must have a production readiness review

@jrsapi #2189 merged on Friday with PRR approved, what else is missing?

@jrsapi
Copy link

jrsapi commented Feb 8, 2021

@soltysh Verified the kep.yaml for PRR. We're good to go. Thanks for your efforts and patience with this new step.

@jrsapi
Copy link

jrsapi commented Feb 18, 2021

Greetings @pacoxu,
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
• If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!

@pacoxu
Copy link
Member Author

pacoxu commented Feb 20, 2021

kubernetes/kubernetes#97099 is ready for log and exec.

I will work on it late next week and the first week of March.

Thanks for reminding @jrsapi

@pacoxu
Copy link
Member Author

pacoxu commented Mar 1, 2021

/assign @mengjiao-liu

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 1, 2021

@pacoxu: GitHub didn't allow me to assign the following users: mengjiao-liu.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mengjiao-liu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mengjiao-liu
Copy link
Member

mengjiao-liu commented Mar 1, 2021

I will work in cp, which will be finished this week.

@pacoxu
Copy link
Member Author

pacoxu commented Mar 17, 2021

@sftim

Goals

Provide a way for consumers (CLI, operators) to know which is the default Container of a Pod
Deprecate the already in use annotation kubectl.kubernetes.io/default-logs-container

Non-Goals

If the cli is not kubectl, we don't determine which is the default container.
Automatically define/create the default container annotation. This is an user operation.

This KEP came from a kubectl requirement. If the client is not kubectl, it depends on the client.

@soltysh
Copy link
Contributor

soltysh commented Mar 19, 2021

Correct, this is honored by kubectl and was driven by SIG-CLI, others are free to consume and interpret it as they wish, but most importantly that's an pod's author opt-in.

@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jul 12, 2021

@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 14, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2021
@soltysh
Copy link
Contributor

soltysh commented Nov 8, 2021

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 8, 2021
@ingvagabund
Copy link
Contributor

ingvagabund commented Aug 3, 2022

This KEEP seems to be finished based on kubernetes/kubernetes#109254 together with https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/2227-kubectl-default-container#beta---ga-graduation:

Beta -> GA Graduation:
- Gather feedback from developers and surveys
- At least 2 release cycles pass to gather feedback and bug reports during
- The deprecation message of the annotation kubectl.kubernetes.io/default-logs-container will be removed and this annotation will stop working.

@pacoxu would you please update the KEP history and the state accordingly?

@soltysh
Copy link
Contributor

soltysh commented Aug 9, 2022

@ingvagabund @pacoxu even though the annotation was removed, this functionality wasn't officially GA-ed, so I'd suggest in 1.26 to promote this to stable.

@soltysh
Copy link
Contributor

soltysh commented Aug 9, 2022

/reopen
/milestone v1.26
/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Aug 9, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.26 Aug 9, 2022
@k8s-ci-robot k8s-ci-robot reopened this Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 9, 2022

@soltysh: Reopened this issue.

In response to this:

/reopen
/milestone v1.26
/stage stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@KnVerey
Copy link
Contributor

KnVerey commented Oct 17, 2022

/milestone v1.27

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.26, v1.27 Oct 17, 2022
@KnVerey
Copy link
Contributor

KnVerey commented Oct 17, 2022

@ingvagabund @pacoxu even though the annotation was removed, this functionality wasn't officially GA-ed, so I'd suggest in 1.26 to promote this to stable.

@soltysh what do we need to do to promote to stable in this case? I moved to 1.27 because we didn't make the opt-in period for 1.26.

@pacoxu
Copy link
Member Author

pacoxu commented Oct 18, 2022

thanks. We may update it to be GAed in v1.27 release cycle.

@soltysh
Copy link
Contributor

soltysh commented Oct 21, 2022

@soltysh what do we need to do to promote to stable in this case? I moved to 1.27 because we didn't make the opt-in period for 1.26.

sgtm - thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.