Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch/v1: add suspend field to Jobs API #2232

Closed
12 tasks done
adtac opened this issue Jan 6, 2021 · 27 comments
Closed
12 tasks done

batch/v1: add suspend field to Jobs API #2232

adtac opened this issue Jan 6, 2021 · 27 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@adtac
Copy link
Member

adtac commented Jan 6, 2021

Enhancement Description

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jan 6, 2021
@adtac adtac changed the title batch/v1: batch/v1: add stopped field to Jobs API Jan 6, 2021
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 28, 2021
@annajung annajung added this to the v1.21 milestone Jan 28, 2021
@adtac adtac changed the title batch/v1: add stopped field to Jobs API batch/v1: add suspend field to Jobs API Feb 1, 2021
@arunmk
Copy link

arunmk commented Feb 5, 2021

hi @adtac I am one of the enhancement shadows for 1.21 and am reviewing this feature. I did not find graduation criteria for alpha phase in the kep. Could you please let me know if there are any?

@adtac
Copy link
Member Author

adtac commented Feb 5, 2021

We don't have any criteria for alpha -- the feature will be turned off by default and we expect users to test it for the first time in alpha. Feedback from users will be a part of beta graduation, but the criteria for alpha is pretty much just the existence of the KEP.

@arunmk
Copy link

arunmk commented Feb 8, 2021

Hi @adtac

This KEP looks good and I don't see any thing missing. However I am adding this message for the sake of completeness.

Enhancements Freeze is 2 days away, Feb 9th EOD PST.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans: needs to be updated in the right section as per template
[DONE] The KEP must have graduation criteria
[DONE] The KEP must have a production readiness review

@arunmk
Copy link

arunmk commented Feb 20, 2021

Hi @adtac,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@arunmk
Copy link

arunmk commented Mar 2, 2021

Hi @adtac ,

Enhancements team is currently tracking the following PR

I went through the review comments and there are a few comments requiring some amount of work. However since this is the only PR in this KEP, I am leaning towards keeping the status as Tracked rather than At Risk. However please note that the code freeze is on 3/9.

Thanks

@arunmk
Copy link

arunmk commented Mar 6, 2021

Hi @adtac,

A friendly reminder that Code freeze is 4 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@arunmk
Copy link

arunmk commented Mar 9, 2021

Hi @adtac, since the only PR mentioned earlier has been merged, can this KEP be marked as done?

@adtac
Copy link
Member Author

adtac commented Mar 9, 2021

@arunmk yes, the implementation is complete. Note that the docs PR is still open and under review.

@alculquicondor
Copy link
Member

alculquicondor commented Mar 12, 2021

/assign @adtac

@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@soltysh
Copy link
Contributor

soltysh commented Apr 27, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 Apr 27, 2021
@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@alculquicondor
Copy link
Member

alculquicondor commented Nov 22, 2021

/remove-lifecycle stale

We can probably graduate to GA in 1.24

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2021
@ahg-g
Copy link
Member

ahg-g commented Jan 7, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.24 Jan 7, 2022
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 22, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 24, 2022

Hello @adtac 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage stable for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
    • (the feature is already implemented & moving to stable)
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review for stage stable that has been completed and merged into k/enhancements.

With all the boxes checked, this enhancement is ready for the upcoming 1.24 enhancements freeze. 🚀

For note, at the moment, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ahg-g
Copy link
Member

ahg-g commented Jan 24, 2022

Hi, KEP for stable graduation is already merged: #3115

@mehabhalodiya
Copy link

mehabhalodiya commented Feb 12, 2022

Hi @adtac 👋🏻 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @ahg-g 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

@ahg-g
Copy link
Member

ahg-g commented Mar 18, 2022

Docs PR: kubernetes/website#32350

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

@ahg-g, thank you so much.

With the Docs PR open now, all requirements for Code Freeze are finished. The status is now tracked.

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 10, 2022

Hello @ahg-g 👋, 1.25 Enhancements team here.

Since this feature has been fully implemented and is now GA in K8s version v1.24 🎉 (which is also properly updated as implemeted in the status of the kep.yaml file).

I'm closing this issue for the purpose of accurate tracking for v1.25. Thank you so much for your valuable contributions. 🙏 🙂

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 10, 2022

@Priyankasaggu11929: Closing this issue.

In response to this:

Hello @ahg-g 👋, 1.25 Enhancements team here.

Since this feature has been fully implemented and is now GA in K8s version v1.24 🎉 (which is also properly updated as implemeted in the status of the kep.yaml file).

I'm closing this issue for the purpose of accurate tracking for v1.25. Thank you so much for your valuable contributions. 🙏 🙂

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Priyankasaggu11929 Priyankasaggu11929 added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests