Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable grace period to probes #2238

Open
8 tasks done
ehashman opened this issue Jan 7, 2021 · 52 comments
Open
8 tasks done

Add configurable grace period to probes #2238

ehashman opened this issue Jan 7, 2021 · 52 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@ehashman
Copy link
Member

ehashman commented Jan 7, 2021

Enhancement Description

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 7, 2021
@ehashman
Copy link
Member Author

ehashman commented Feb 2, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 2, 2021
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Feb 3, 2021
@arunmk
Copy link

arunmk commented Feb 5, 2021

@ehashman I am one of the enhancement shadows for v1.21 and am reviewing this KEP. We have the enhancements freeze coming up on 2/9. Could you mention if PR #2241 be merged by then?

I looked at the PR and things seem ok from a KEP standpoint with the exception of the empty Graduation Criteria section. We will be needing that also to be present (for the current alpha phase at least) at the enhancements freeze deadline.

Thanks!

@arunmk
Copy link

arunmk commented Feb 8, 2021

Hi @ehashman

Enhancements Freeze is 1 day away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2241). I do not see a graduation criteria section in the PR and will need some details. The KEP looks good.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

Assuming that the PR is merged, this would be the state of the KEP:
[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria: this is missing in the PR
[DONE] The KEP must have a production readiness review

EDIT: updated with new commit in the PR. Note that the PR still needs to be merged by the enhancements freeze.

@ehashman
Copy link
Member Author

ehashman commented Feb 8, 2021

Done; this was sort of implicit and I have added it explicitly.

@arunmk
Copy link

arunmk commented Feb 8, 2021

Thanks @ehashman. I will update the earlier status inline. (I'm not sure how rigorously the template is to be followed, but it is useful to follow it for the first few iterations so that we know what issues would arise).

@arunmk
Copy link

arunmk commented Feb 20, 2021

Hi @ehashman,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@ehashman
Copy link
Member Author

ehashman commented Feb 22, 2021

Thanks @arunmk, I was hoping to have some code out for this last week but didn't get a chance to work on it. Hoping today or tomorrow...

@arunmk
Copy link

arunmk commented Mar 2, 2021

Hi @ehashman ,

Enhancements team is currently tracking the following PR

I went through the review comments and there are a few comments requiring some decisions and there is also an api-review initiated. This is the only PR but it is a fairly large one at 15 KLOC. Since there are a few decision points and some test related comments, and also since the code freeze is one week away at 3/9, I am tagging this as At Risk for now.

Please do let me know if you think otherwise and the tag can be revised.

Thanks!

@arunmk
Copy link

arunmk commented Mar 6, 2021

Hi @ehashman,

A friendly reminder that Code freeze is 4 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@annajung
Copy link
Member

annajung commented Mar 10, 2021

Hi @ehashman, with code freeze now in effect, we are removing this enhancement from 1.21 release due to kubernetes/kubernetes#99375 not being merged or approved.

Feel free to file an exception to add this back into the release. thanks!

@annajung annajung removed this from the v1.21 milestone Mar 10, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 10, 2021
@ehashman
Copy link
Member Author

ehashman commented Mar 10, 2021

Hi @annajung,

This was basically approved, but the API reviewer didn't do a /approve to make it Official. I just finished rebasing the PR and I will have reviewers take another look today. Will you still need me to send a full exception email? Landing this PR (+ docs) is the only requirement for alpha graduation.

@ehashman ehashman changed the title Add a configurable grace period to liveness probes Add configurable grace period to probes Mar 10, 2021
@ehashman
Copy link
Member Author

ehashman commented Mar 10, 2021

Filed exception request: https://groups.google.com/g/kubernetes-sig-node/c/fg6Gd8m9jHc/m/u6KOEZYwAAAJ

@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 11, 2021
@annajung annajung added this to the v1.21 milestone Mar 11, 2021
@annajung
Copy link
Member

annajung commented Mar 12, 2021

Hi @ehashman, with kubernetes/kubernetes#99375 merged in, we're marking this as code complete for the 1.21 release. Thank you

@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@ehashman
Copy link
Member Author

ehashman commented Apr 28, 2021

/milestone v1.22

@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 10, 2022
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Jun 16, 2022

@mrunalp and I are trying to find another volunteer to help push this forward.

@mrunalp
Copy link
Contributor

mrunalp commented Jun 17, 2022

@mikebrow has folks from IBM working on it.

@psschwei
Copy link
Contributor

psschwei commented Jun 17, 2022

@mrunalp I'll take ownership of this, get the KEP updated, etc.

@psschwei
Copy link
Contributor

psschwei commented Jun 17, 2022

Actually, looks like the KEP was already updated: #3282

@mrunalp
Copy link
Contributor

mrunalp commented Jun 17, 2022

@psschwei Thanks! :)

@mrunalp
Copy link
Contributor

mrunalp commented Jun 17, 2022

@psschwei We may need to make sure it has the updated template. That's being flagged on many KEPs.

@psschwei
Copy link
Contributor

psschwei commented Jun 17, 2022

WIP for new template, etc : #3408

@rhockenbury
Copy link

rhockenbury commented Jun 20, 2022

👋 Hello @ehashman and @psschwei, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is remaining in beta for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@psschwei
Copy link
Contributor

psschwei commented Jun 23, 2022

@rhockenbury I believe the updates you were looking for are have now been addressed in #3408

@rhockenbury
Copy link

rhockenbury commented Jun 23, 2022

Yes, thanks. Please try to merge before enhancements freeze today at 18:00 PST (~3 hours from now).

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 24, 2022

Hello, 1.25 Enhancements Lead here 👋. With Enhancements Freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

  • KEP file using the latest template has been merged into the k/enhancements repo, with up to date latest milestone and stage
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Jun 24, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 24, 2022
@cici37
Copy link
Contributor

cici37 commented Jun 27, 2022

Hi, Thanks for raising the exception request. The exception request has been approved by 1.25 release team and your updated deadline to make any changes to your KEP is 18:00 PST Thursday 30th June 2022.
/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 27, 2022
@cici37 cici37 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 27, 2022
@psschwei
Copy link
Contributor

psschwei commented Jun 27, 2022

A couple of edits needed on the issue:

@sethmccombs
Copy link

sethmccombs commented Jul 12, 2022

Hello @ehashman ! 👋,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@psschwei
Copy link
Contributor

psschwei commented Jul 12, 2022

Hi @sethmccombs, the docs PR for this KEP is already created here

@marosset
Copy link
Contributor

marosset commented Jul 25, 2022

Hi @ehashman & @psschwei 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

I have found the following open PRs which I sound related to this enhancment.
Please update this issue if there are more.

Since these implementation PRs are not merged, the status of this enhancement is currently marked as at-risk.

As always, we are here to help should questions come up.

Thanks!!

@marosset
Copy link
Contributor

marosset commented Aug 1, 2022

Hi @ehashman and @psschwei

With the k/k code PRs, now merged, the enhancement is ready for the 1.25 code freeze
The status of this enhancement is currently marked as tracked

Thank you.

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests