Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable grace period to probes #2238

Open
8 tasks done
ehashman opened this issue Jan 7, 2021 · 78 comments
Open
8 tasks done

Add configurable grace period to probes #2238

ehashman opened this issue Jan 7, 2021 · 78 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@ehashman
Copy link
Member

ehashman commented Jan 7, 2021

Enhancement Description

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 7, 2021
@ehashman
Copy link
Member Author

ehashman commented Feb 2, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 2, 2021
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Feb 3, 2021
@arunmk
Copy link

arunmk commented Feb 5, 2021

@ehashman I am one of the enhancement shadows for v1.21 and am reviewing this KEP. We have the enhancements freeze coming up on 2/9. Could you mention if PR #2241 be merged by then?

I looked at the PR and things seem ok from a KEP standpoint with the exception of the empty Graduation Criteria section. We will be needing that also to be present (for the current alpha phase at least) at the enhancements freeze deadline.

Thanks!

@arunmk
Copy link

arunmk commented Feb 8, 2021

Hi @ehashman

Enhancements Freeze is 1 day away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2241). I do not see a graduation criteria section in the PR and will need some details. The KEP looks good.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

Assuming that the PR is merged, this would be the state of the KEP:
[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria: this is missing in the PR
[DONE] The KEP must have a production readiness review

EDIT: updated with new commit in the PR. Note that the PR still needs to be merged by the enhancements freeze.

@ehashman
Copy link
Member Author

ehashman commented Feb 8, 2021

Done; this was sort of implicit and I have added it explicitly.

@arunmk
Copy link

arunmk commented Feb 8, 2021

Thanks @ehashman. I will update the earlier status inline. (I'm not sure how rigorously the template is to be followed, but it is useful to follow it for the first few iterations so that we know what issues would arise).

@arunmk
Copy link

arunmk commented Feb 20, 2021

Hi @ehashman,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@ehashman
Copy link
Member Author

Thanks @arunmk, I was hoping to have some code out for this last week but didn't get a chance to work on it. Hoping today or tomorrow...

@arunmk
Copy link

arunmk commented Mar 2, 2021

Hi @ehashman ,

Enhancements team is currently tracking the following PR

I went through the review comments and there are a few comments requiring some decisions and there is also an api-review initiated. This is the only PR but it is a fairly large one at 15 KLOC. Since there are a few decision points and some test related comments, and also since the code freeze is one week away at 3/9, I am tagging this as At Risk for now.

Please do let me know if you think otherwise and the tag can be revised.

Thanks!

@arunmk
Copy link

arunmk commented Mar 6, 2021

Hi @ehashman,

A friendly reminder that Code freeze is 4 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@annajung
Copy link
Member

Hi @ehashman, with code freeze now in effect, we are removing this enhancement from 1.21 release due to kubernetes/kubernetes#99375 not being merged or approved.

Feel free to file an exception to add this back into the release. thanks!

@annajung annajung removed this from the v1.21 milestone Mar 10, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 10, 2021
@ehashman
Copy link
Member Author

Hi @annajung,

This was basically approved, but the API reviewer didn't do a /approve to make it Official. I just finished rebasing the PR and I will have reviewers take another look today. Will you still need me to send a full exception email? Landing this PR (+ docs) is the only requirement for alpha graduation.

@ehashman ehashman changed the title Add a configurable grace period to liveness probes Add configurable grace period to probes Mar 10, 2021
@ehashman
Copy link
Member Author

ehashman commented Mar 10, 2021

Filed exception request: https://groups.google.com/g/kubernetes-sig-node/c/fg6Gd8m9jHc/m/u6KOEZYwAAAJ

@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 11, 2021
@annajung annajung added this to the v1.21 milestone Mar 11, 2021
@annajung
Copy link
Member

Hi @ehashman, with kubernetes/kubernetes#99375 merged in, we're marking this as code complete for the 1.21 release. Thank you

@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@ehashman
Copy link
Member Author

/milestone v1.22

@bobbypage
Copy link
Member

This needs lead opted in label for 1.27.

@SergeyKanzhelev @mrunalp can you please add?

@SergeyKanzhelev
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@SergeyKanzhelev
Copy link
Member

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Feb 3, 2023
@npolshakova
Copy link

npolshakova commented Feb 6, 2023

Hello @rphillips 👋, 1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@johnbelamaric
Copy link
Member

@rphillips If it's moving from beta to stable it will need an updated PRR review, I don't see that.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 7, 2023

I've unchecked the PRR review complete on the checklist above @npolshakova, this needs an updated PRR review.

@npolshakova
Copy link

Thanks, I'll update the enhancement tracking!

@johnbelamaric
Copy link
Member

@rphillips please try to get a PR up soon, time is running short :)

@rphillips
Copy link
Member

@johnbelamaric I have a PR over here #3830

@johnbelamaric
Copy link
Member

thanks, sorry I didn't see it. this LGTM but I have to wait for sig approval before giving mine

@SergeyKanzhelev
Copy link
Member

@npolshakova all requirements are satisfied now. Can you please mark this one as tracked?

@rphillips
Copy link
Member

/assign @npolshakova

@npolshakova
Copy link

Great, with #3830 merged I'm marking this enhancement as tracked for v1.27.
Thanks!

/remove-label tracked/no
/label tracked/yes

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 9, 2023
@npolshakova
Copy link

Hi @rphillips,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

@Rishit-dagli
Copy link
Member

Hi @ehashman 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release. If I understand correctly this does not have docs PR for 1.27, right?

If so, please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

@mickeyboxell
Copy link

@rphillips @ehashman The deadline for getting docs into the 1.27 release is coming up quickly on April 4th. Please open a docs PR against dev-1.27 branch in the k/website repo ASAP.

@rphillips
Copy link
Member

@mickeyboxell Thank you for the ping... Added a PR.

@SergeyKanzhelev
Copy link
Member

/milestone v1.28

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.27, v1.28 May 5, 2023
@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked
Development

No branches or pull requests