New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable grace period to probes #2238
Comments
/milestone v1.21 |
@ehashman I am one of the enhancement shadows for v1.21 and am reviewing this KEP. We have the enhancements freeze coming up on 2/9. Could you mention if PR #2241 be merged by then? I looked at the PR and things seem ok from a KEP standpoint with the exception of the empty Thanks! |
Hi @ehashman Enhancements Freeze is 1 day away, Feb 9th EOD PST Enhancements team is aware that KEP update is currently in progress (PR #2241). Any enhancements that do not complete the following requirements by the freeze will require an exception. Assuming that the PR is merged, this would be the state of the KEP: EDIT: updated with new commit in the PR. Note that the PR still needs to be merged by the enhancements freeze. |
Done; this was sort of implicit and I have added it explicitly. |
Thanks @ehashman. I will update the earlier status inline. (I'm not sure how rigorously the template is to be followed, but it is useful to follow it for the first few iterations so that we know what issues would arise). |
Hi @ehashman, Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them. Thanks! |
Thanks @arunmk, I was hoping to have some code out for this last week but didn't get a chance to work on it. Hoping today or tomorrow... |
Hi @ehashman , Enhancements team is currently tracking the following PR I went through the review comments and there are a few comments requiring some decisions and there is also an api-review initiated. This is the only PR but it is a fairly large one at 15 KLOC. Since there are a few decision points and some test related comments, and also since the code freeze is one week away at 3/9, I am tagging this as Please do let me know if you think otherwise and the tag can be revised. Thanks! |
Hi @ehashman, A friendly reminder that Code freeze is 4 days away, March 9th EOD PST Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back. Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST Thanks! |
Hi @ehashman, with code freeze now in effect, we are removing this enhancement from 1.21 release due to kubernetes/kubernetes#99375 not being merged or approved. Feel free to file an exception to add this back into the release. thanks! |
Hi @annajung, This was basically approved, but the API reviewer didn't do a /approve to make it Official. I just finished rebasing the PR and I will have reviewers take another look today. Will you still need me to send a full exception email? Landing this PR (+ docs) is the only requirement for alpha graduation. |
Filed exception request: https://groups.google.com/g/kubernetes-sig-node/c/fg6Gd8m9jHc/m/u6KOEZYwAAAJ |
Hi @ehashman, with kubernetes/kubernetes#99375 merged in, we're marking this as code complete for the 1.21 release. Thank you |
/milestone v1.22 |
This needs lead opted in label for 1.27. @SergeyKanzhelev @mrunalp can you please add? |
/label lead-opted-in |
/stage stable |
Hello @rphillips Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. The status of this enhancement is marked as |
@rphillips If it's moving from |
I've unchecked the PRR review complete on the checklist above @npolshakova, this needs an updated PRR review. |
Thanks, I'll update the enhancement tracking! |
@rphillips please try to get a PR up soon, time is running short :) |
@johnbelamaric I have a PR over here #3830 |
thanks, sorry I didn't see it. this LGTM but I have to wait for sig approval before giving mine |
@npolshakova all requirements are satisfied now. Can you please mark this one as tracked? |
/assign @npolshakova |
Great, with #3830 merged I'm marking this enhancement as tracked for v1.27. /remove-label tracked/no |
Hi @rphillips, Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023. Please ensure the following items are completed:
Please let me know if there are any other PRs in k/k I should be tracking for this KEP. |
Hi @ehashman If so, please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. |
@rphillips @ehashman The deadline for getting docs into the 1.27 release is coming up quickly on April 4th. Please open a docs PR against dev-1.27 branch in the k/website repo ASAP. |
@mickeyboxell Thank you for the ping... Added a PR. |
/milestone v1.28 |
Enhancement Description
gracePeriodSeconds
field to liveness probesk/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):/sig node
The text was updated successfully, but these errors were encountered: