Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup v2 #2254

Closed
4 tasks
giuseppe opened this issue Jan 12, 2021 · 39 comments
Closed
4 tasks

cgroup v2 #2254

giuseppe opened this issue Jan 12, 2021 · 39 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@giuseppe
Copy link
Member

giuseppe commented Jan 12, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 12, 2021
@giuseppe
Copy link
Member Author

giuseppe commented Jan 12, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 12, 2021
@ehashman ehashman added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 13, 2021
@eero-t
Copy link

eero-t commented Jan 25, 2021

https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2254-cgroup-v2

Seems to need update as it says: "OCI runtime spec: TODO" and "OCI will need support for cgroups v2"

Instead of referring to: https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md#unified

@xiaoxubeii
Copy link
Member

xiaoxubeii commented Feb 25, 2021

I have already submitted a PR to update the information: #2507

@xiaoxubeii
Copy link
Member

xiaoxubeii commented Feb 25, 2021

@giuseppe We are working on supporting cgroup v2 of Kubernetes in our production in Tencent, including new addition, such as memory.high / memory.low, io controller. We really want to contribute to the community with cgroup v2 and resource qos, please contact me if need.

@iliul
Copy link

iliul commented Apr 25, 2021

/cc

1 similar comment
@wzshiming
Copy link
Member

wzshiming commented Apr 26, 2021

/cc

@ehashman
Copy link
Member

ehashman commented May 4, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 5, 2021
@salaxander
Copy link

salaxander commented May 11, 2021

Hi @giuseppe , 1.22 enhancements team here

For the enhancement to be included in the milestone, it must meet the following criteria:

  • [DONE] The KEP must be merged in an implementable state
  • The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • The KEP must have a production readiness review

In order to move forward in 1.22 we'd need to have test plans as well as a production readiness review before enhancements freeze on 5/13. Feel free to reference the KEP template here -> https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Thanks!!

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 11, 2021

If you get there please assign me as PRR approver. Thanks.

@ehashman
Copy link
Member

ehashman commented May 12, 2021

@johnbelamaric it's up here: #2689

But questionnaire isn't filled out, I'll leave a comment.

@salaxander
Copy link

salaxander commented May 13, 2021

@ehashman as long as that merges before enhancements freeze tomorrow evening we're good to go!

@chrisnegus
Copy link

chrisnegus commented May 19, 2021

Hi @giuseppe ! I'm @chrisnegus , a Docs Shadow for release 1.22.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@giuseppe
Copy link
Member Author

giuseppe commented May 25, 2021

Hi @giuseppe ! I'm @chrisnegus , a Docs Shadow for release 1.22.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

opened a draft PR here: kubernetes/website#28106

@giuseppe
Copy link
Member Author

giuseppe commented May 25, 2021

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

do you have any example of what should end up in the documentation for this feature?

@salaxander
Copy link

salaxander commented Jun 23, 2021

Hey @giuseppe - Just checking in as we're about 2 weeks away from code freeze for 1.22. Are there any open or closed k/k PRs for the milestone that we should be tracking? Or is kubernetes/kubernetes#85218 everything planned for 1.22?

@giuseppe
Copy link
Member Author

giuseppe commented Jun 23, 2021

@salaxander thanks for asking. There is nothing more planned for cgroup v2 in 1.22.

There were a few fixes PR but they were already merged

@salaxander salaxander removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Aug 19, 2021
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 31, 2022
@dchen1107 dchen1107 added this to the v1.25 milestone Jun 9, 2022
@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 10, 2022
@rhockenbury
Copy link

rhockenbury commented Jun 15, 2022

👋 Hello @giuseppe,

1.25 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 21, 2022

With KEP PR #3405 merged, the enhancement is ready for the 1.25 Enhancements Freeze. Thank you!

For note, the status is now marked as tracked in the 1.25 Enhancements Tracking sheet.

@bobbypage
Copy link
Member

bobbypage commented Jun 21, 2022

Thank you @Priyankasaggu11929 for the update!

@ReillyBrogan
Copy link

ReillyBrogan commented Jul 1, 2022

Moving this to this issue per comments in #3405:

Would there be value in making it visible in the Node status that the node is using cgroup v2?

Yes, I think so. It might be a good candidate for a node label so that pods can target pure v1, pure v2, or hybrid mode v1/v2. Some applications that expect an older setup could experience issues if a node is pure v2. Applications using Java 8 or Java 11 <= 11.0.16 for example don't accurately detect CPU/memory limits when ran on v2-only systems.

@sethmccombs
Copy link

sethmccombs commented Jul 12, 2022

Hello @giuseppe, @mrunalp, @bobbypage! 👋,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@bobbypage
Copy link
Member

bobbypage commented Jul 19, 2022

@ReillyBrogan regarding adding a node label / node status of cgroupv2, it's something me and @mrunalp discussed but we decided it would make more sense for the vendor to set since some vendors may or may not want to set this label. Some vendors may only allow running all nodes as cgroupv2 so it would be redundant to add the label.

@bobbypage
Copy link
Member

bobbypage commented Jul 19, 2022

Thanks @sethmccombs, I created a placeholder doc PR here - kubernetes/website#35180

@marosset
Copy link
Contributor

marosset commented Jul 25, 2022

Hi @bobbypage / @giuseppe

1.25 Enhancements team here. Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

I couldn't find any PRs (opened or closed) relating to promoting this enhancement to stable.
Can you confirm if any code changes are needed here or if documentation just needs to be updated.

Thank!!

@giuseppe
Copy link
Member Author

giuseppe commented Jul 25, 2022

AFAIK, only documentation needs to be updated

@bobbypage
Copy link
Member

bobbypage commented Jul 25, 2022

Yes, we only need documentation updates, thank you!

@marosset
Copy link
Contributor

marosset commented Jul 25, 2022

Thanks for confirming!

@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 24, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2022
@bobbypage
Copy link
Member

bobbypage commented Aug 25, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 25, 2022
@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 11, 2022

@bobbypage @giuseppe Can we close this issue since it's graduated to stable?

@giuseppe
Copy link
Member Author

giuseppe commented Sep 12, 2022

yes, I think it can be closed since there is nothing left to do. Thanks for the reminder!

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 12, 2022

@giuseppe: Closing this issue.

In response to this:

yes, I think it can be closed since there is nothing left to do. Thanks for the reminder!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
No open projects
Development

No branches or pull requests