Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node log query #2258

Open
9 tasks done
aravindhp opened this issue Jan 12, 2021 · 75 comments
Open
9 tasks done

Node log query #2258

aravindhp opened this issue Jan 12, 2021 · 75 comments
Assignees
Labels
sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@aravindhp
Copy link
Contributor

aravindhp commented Jan 12, 2021

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 12, 2021
@aravindhp
Copy link
Contributor Author

/cc @LorbusChris @marosset @immuzz
/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 12, 2021
@marosset marosset added this to In Progress (v1.21) in SIG-Windows Jan 14, 2021
@dougsland
Copy link
Member

/cc

@annajung annajung added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 28, 2021
@annajung annajung added this to the v1.21 milestone Jan 28, 2021
@annajung
Copy link
Contributor

annajung commented Feb 7, 2021

Hi @aravindhp

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2271). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [IN PROGRESS] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

@aravindhp
Copy link
Contributor Author

@annajung #2271 has the following completed:
[IN PROGRESS] The KEP must have test plans
[IN PROGRESS] The KEP must have graduation criteria
[IN PROGRESS] The KEP must have a production readiness review (I need update the check mark but it has been /approved for PRR)
Is there a reason for it to be marked IN PROGRESS?

@annajung
Copy link
Contributor

annajung commented Feb 7, 2021

@aravindhp We consider it in progress until PR merges. Even if you have a PR open for the change, if it doesn't merge before the enhancements freeze, this enhancement is at risk of not making it into the release.

@aravindhp
Copy link
Contributor Author

Thanks for the clarification @annajung. We are waiting for LGTMs from sig-node and sig-auth to merge.

@annajung
Copy link
Contributor

Hi @aravindhp,

Enhancements Freeze is now in effect.

Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.21 milestone Feb 10, 2021
@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Feb 10, 2021
@immuzz
Copy link

immuzz commented Feb 19, 2021

This is very much needed especially for scenarios where you need to access host like gMSA for Windows Containers. Cant wait to see this land soon

@marosset marosset moved this from In Progress (v1.21) to InProgress (v1.22) in SIG-Windows Mar 11, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Apr 29, 2021
@JamesLaverack JamesLaverack added this to the v1.22 milestone May 3, 2021
@salaxander
Copy link
Contributor

Hi @aravindhp , 1.22 enhancements team here!

For the enhancement to be included in the milestone, it must meet the following criteria:

[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria
[DONE] The KEP must have a production readiness review

Looks like we're in good shape for enhancements freeze on 5/13. Let us know if there's anything we can do to help before then!

Thanks!!

@salaxander
Copy link
Contributor

Hey @aravindhp - Just checking in as we're about 2 weeks away from 1.22 code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!

@aravindhp
Copy link
Contributor Author

@salaxander, I have a WIP PR: kubernetes/kubernetes#96120. But it is looking very tight at this point.

@salaxander
Copy link
Contributor

Hi @aravindhp - One more check-in as we're a week out from code freeze. Any updates on if you expect kubernetes/kubernetes#96120 to merge before the deadline?

Thanks!

@LorbusChris
Copy link
Contributor

By now, I don't think it's reasonable to assume it will make it in in time. We will circle back to this in the next Dev window.

@marosset marosset moved this from InProgress (v1.22) to In Progress (v1.23) in SIG-Windows Jul 29, 2021
@marosset
Copy link
Contributor

/milestone clear

@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 14, 2023

I have opened a draft PR for the docs:

@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@aravindhp
Copy link
Contributor Author

@marosset can close this issue given the feature was merged as alpha or do we need to wait until we hit stable?

@marosset
Copy link
Contributor

@marosset can close this issue given the feature was merged as alpha or do we need to wait until we hit stable?

Keep the issue open until it hits stable and all the work called out in the KEP is merged

@kannon92
Copy link
Contributor

Could you please make sure the milestones are up to date with this feature?

@kannon92
Copy link
Contributor

And last thing, I find it helpful to add PRs and issues related to this in this issue. It helps track this over time.

I guess for beta, you have a KEP needed and some e2e tests you want to promote. I'd update the description to mention what PRs are targed for beta.

@aravindhp
Copy link
Contributor Author

Thanks for the reminder @kannon92. I have updated the description.

@aravindhp
Copy link
Contributor Author

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.27, v1.30 Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 18, 2024
@sreeram-venkitesh
Copy link
Member

sreeram-venkitesh commented Feb 7, 2024

Hello @aravindhp 👋, v1.30 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Please update latest-milestone to 1.30 here.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@aravindhp
Copy link
Contributor Author

@sreeram-venkitesh I have updated the milestone in

@salehsedghpour
Copy link
Contributor

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@Princesso
Copy link

Hello @aravindhp, 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@aravindhp
Copy link
Contributor Author

@Checksumz
Copy link

Hi @aravindhp ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@aravindhp
Copy link
Contributor Author

@Checksumz I already blogged about the feature when it was added as alpha. No changes to the feature from alpha to beta. I will do a blog when it graduates to GA.

@Checksumz
Copy link

Thanks for the response @aravindhp

@mrunalp
Copy link
Contributor

mrunalp commented Feb 26, 2024

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Feb 26, 2024
@sreeram-venkitesh
Copy link
Member

Hey again @aravindhp 👋 v1.30 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, with below PRs merged as per the issue description, this enhancement is now marked as Tracked for code freeze for the 1.30 Code Freeze! 🚀

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

@sreeram-venkitesh
Copy link
Member

Hi @aravindhp 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Net New
Status: Tracked
Status: Tracked for Doc Freeze
Status: In Progress
Development

No branches or pull requests