Node log query

[aravindhp]

Enhancement Description

• Add a kubelet API for viewing logs of system services on nodes
• Kubernetes Enhancement Proposal: KEP-2258: Node service log viewer
• Discussion Link: https://kubernetes.slack.com/archives/C0SJ4AFB7/p1610055846236600
• Primary contact (assignee): @aravindhp
• Responsible SIGs: sig-windows
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.27
  • Beta release target (x.y): 1.28
  • Stable release target (x.y): 1.29
• Alpha
  • KEP (k/enhancements) update PR(s): KEP 2258: Node service log viewer #2271
  • Code (k/k) update PR(s):
    • KEP 2258: add node log query kubernetes#96120
  • Docs (k/website) update PR(s): KEP-2258: Node log query documentation website#40003

[aravindhp]

/cc @LorbusChris @marosset @immuzz
/sig windows

[dougsland]

/cc

[annajung]

Hi @aravindhp

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2271). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

• [IN PROGRESS] The KEP must be merged in an implementable state
• [IN PROGRESS] The KEP must have test plans
• [IN PROGRESS] The KEP must have graduation criteria
• [IN PROGRESS] The KEP must have a production readiness review

[aravindhp]

@annajung #2271 has the following completed:
[IN PROGRESS] The KEP must have test plans
[IN PROGRESS] The KEP must have graduation criteria
[IN PROGRESS] The KEP must have a production readiness review (I need update the check mark but it has been /approved for PRR)
Is there a reason for it to be marked IN PROGRESS?

[annajung]

@aravindhp We consider it in progress until PR merges. Even if you have a PR open for the change, if it doesn't merge before the enhancements freeze, this enhancement is at risk of not making it into the release.

[aravindhp]

Thanks for the clarification @annajung. We are waiting for LGTMs from sig-node and sig-auth to merge.

[annajung]

Hi @aravindhp,

Enhancements Freeze is now in effect.

Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

[immuzz]

This is very much needed especially for scenarios where you need to access host like gMSA for Windows Containers. Cant wait to see this land soon

[salaxander]

Hi @aravindhp , 1.22 enhancements team here!

For the enhancement to be included in the milestone, it must meet the following criteria:

[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria
[DONE] The KEP must have a production readiness review

Looks like we're in good shape for enhancements freeze on 5/13. Let us know if there's anything we can do to help before then!

Thanks!!

[salaxander]

Hey @aravindhp - Just checking in as we're about 2 weeks away from 1.22 code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!

[aravindhp]

@salaxander, I have a WIP PR: kubernetes/kubernetes#96120. But it is looking very tight at this point.

[salaxander]

Hi @aravindhp - One more check-in as we're a week out from code freeze. Any updates on if you expect kubernetes/kubernetes#96120 to merge before the deadline?

Thanks!

[LorbusChris]

By now, I don't think it's reasonable to assume it will make it in in time. We will circle back to this in the next Dev window.

[marosset]

/milestone clear

[cathchu]

Hi there @aravindhp 👋 1.26 Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for 1.26 release. I see you've opened kubernetes/website#32660. I'd like to confirm that all Docs related changes will be included in this PR.

If not, please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

[marosset]

Hi @aravindhp 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).

• All PRs are fully merged by the code freeze deadline.
  For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• KEP 2258: add node log query kubernetes#96120

• Update tests to match current alpha node-logs feature kubernetes#112207

As always, we are here to help should questions come up. Thanks!

[rhockenbury]

Hello 👋, 1.26 Enhancements Lead here

Unfortunately, this enhancement did not meet requirements for code freeze.
If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

[marosset]

/label lead-opted-in
/milestone v1.27

[fsmunoz]

Hello @aravindhp 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.27
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

This enhancement is ready to be traced for graduation to alpha in v1.27

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[fsmunoz]

This enhancement is ready to be traced for graduation to alpha in v1.27

/label tracked/yes
/remove-label tracked/no

[fsmunoz]

@aravindhp , there is a new question in the PRR Scalability that you might want to address:

Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

The Scalability section of the PRR is encouraged, but not mandatory, for alpha enhancements, but since you answered the rest you may want to update it,

[katmutua]

Hello @aravindhp 👋🏾 !

@katmutua 1.27 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

If you already have existing open PRs please link them to the description so we can easily track them. Thanks!

[fsmunoz]

Hi @aravindhp 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• KEP 2258: add node log query kubernetes#96120
• Update tests to match current alpha node-logs feature kubernetes#112207

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

[aravindhp]

We decided to close kubernetes/kubernetes#112207, so it is only kubernetes/kubernetes#96120 that needs to be merged.

[fsmunoz]

@aravindhp sorry, that was clear from the status of it but I pasted it there by accident - updated it!

[aravindhp]

/retitle Node log query

[aravindhp]

I have opened a draft PR for the docs:

• KEP-2258: Node log query documentation website#40003

[aravindhp]

@marosset can close this issue given the feature was merged as alpha or do we need to wait until we hit stable?

[marosset]

@marosset can close this issue given the feature was merged as alpha or do we need to wait until we hit stable?

Keep the issue open until it hits stable and all the work called out in the KEP is merged