Non-graceful node shutdown

[xing-yang]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add support to handle non-graceful node shutdown
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2268-non-graceful-shutdown
• Discussion Link:
• Primary contact (assignee): @yastij @xing-yang
• Responsible SIGs: sig-storage, sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.24
  • Beta release target (x.y): 1.26
  • Stable release target (x.y): 1.28
• Beta
  • Code PRs:
    • Move feature gate to beta: Move non-graceful node shutdown to beta kubernetes#113511
    • Add metrics to Pod GC Controller: Add metric deleting_pods_total kubernetes#113519
    • e2e test: chore(e2e): add e2e test for non graceful node shutdown kubernetes#111380
  • Doc PR:
    • PR: NodeOutOfServiceVolumeDetach feature update to beta website#37374
  • Blog:
    • PR: Add blog for non-graceful node shutdown beta website#37583
• GA
  • KEP update: KEP-2268: move non-graceful node shutdown to GA #4029
  • Code PRs:
    • move feature to stable: move non-graceful node shutdown to GA kubernetes#118228
    • add reason to force detach metric: Add reason to force detach metric kubernetes#119185
    • update force_delete_pods_total metric: podgc metrics should count all pod deletion behaviors kubernetes#118480
  • Doc PR: NodeOutOfServiceVolumeDetach feature update to GA website#41302
  • Placeholder Blog PR: Add blog for non-graceful node shutdown website#41914

[xing-yang]

/sig storage

[xing-yang]

/sig node

[annajung]

Hi @xing-yang, 1.21 enhancements lead here.
I see that you’ve opted in this enhancement into 1.21, but I also see that this is tagged with participation from the SIG node. Is that accurate? If so, is there work that SIG node must deliver in 1.21 as well?

[yastij]

Hi @annajung - we're still in the process of seeing which changes are needed for sig-node

[jrsapi]

Greetings @xing-yang ,
This is Joseph v1.21 enhancement shadow following up. For the enhancement to be included in the 1.21 milestone, it must meet the following criteria:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have a production readiness review

Starting v1.21, all KEPs must include a production readiness review. Please make sure to take a look at the instructions and follow all steps.

Thank you!

[jrsapi]

Greetings @xing-yang,

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #1116). Please make sure to work on PRR questionnaires and requirements and get them merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

[IN PROGRESS] The KEP must be merged in an implementable state
[IN PROGRESS] The KEP must have test plans
[IN PROGRESS] The KEP must have graduation criteria
[IN PROGRESS] The KEP must have a production readiness review

[xing-yang]

Hi @jrsapi,
Thanks for the reminder! We still need more discussions to figure out some design issues. So it will not make it in 1.21.