Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New label for trusted PR identification #2290

Closed
4 tasks
shekhar-rajak opened this issue Jan 19, 2021 · 10 comments
Closed
4 tasks

New label for trusted PR identification #2290

shekhar-rajak opened this issue Jan 19, 2021 · 10 comments
Labels
sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@shekhar-rajak
Copy link
Member

shekhar-rajak commented Jan 19, 2021

Enhancement Description

  • One-line enhancement description (can be used as a release note):

New label for trusted PR identification

  • Kubernetes Enhancement Proposal:

This document describes a major change to the way the trigger plugin determines if test jobs should be started on a pull request (PR).

We propose introducing a new label named ok-to-test that will be applied on non-member PRs once they have been /ok-to-test by a legitimate reviewer.

We suggest introducing a new label named ok-to-test that would be required on any non-member PR before automatic test jobs can be started by the trigger plugin.

This label will be added by members of the trusted organization for the repository using the /ok-to-test command, detected with a single GenericCommentEvent handler on corresponding events (issue_comment, pull_request_review, and pull_request_review_comment).

  • Discussion Link:

  • Primary contact (assignee): @matthyx

  • Responsible SIGs:

sig-testing

  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y):
    • Beta release target (x.y):
    • Stable release target (x.y):
  • Alpha
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update PR(s):

References

Implementation History

  • 2018-06-25: creation of the KEP
  • 2018-07-09: KEP content LGTM during sig-testing presentation
  • 2018-07-24: KEP updated to keep needs-ok-to-test for better UX
  • 2018-09-03: KEP rewritten with template
  • 2018-10-04: KEP merged into master
  • 2018-10-08: start of implementation
  • 2018-10-10: ok-to-test label added
  • 2019-01-29: remove comment parsing code for PR trust

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 19, 2021
@matthyx
Copy link
Contributor

matthyx commented Jan 19, 2021

@shekhar-rajak do you need help with this?

@shekhar-rajak
Copy link
Member Author

shekhar-rajak commented Jan 19, 2021

This is created for the PR #2292 , I do not think there is issue for the kep.

@shekhar-rajak
Copy link
Member Author

shekhar-rajak commented Jan 19, 2021

I needed the issue number as kep-number for the folder structure. Please review the PR and let me know, if we need to any update in the kep.

@matthyx
Copy link
Contributor

matthyx commented Jan 19, 2021

I think everything is fine.
Thanks for cleaning my mess!

@fejta-bot
Copy link

fejta-bot commented Apr 19, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2021
@fejta-bot
Copy link

fejta-bot commented May 19, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 19, 2021
@fejta-bot
Copy link

fejta-bot commented Jun 18, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 18, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Aug 16, 2021

/remove-lifecycle rotten
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 16, 2021
@spiffxp
Copy link
Member

spiffxp commented Aug 16, 2021

/tracked no
/stage stable

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Aug 16, 2021
@spiffxp spiffxp added the tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team label Aug 16, 2021
@spiffxp spiffxp added this to the v1.14 milestone Aug 16, 2021
@spiffxp spiffxp added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team labels Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

5 participants