New label for trusted PR identification

[shekhar-rajak]

Enhancement Description

• One-line enhancement description (can be used as a release note):

New label for trusted PR identification

• Kubernetes Enhancement Proposal:

This document describes a major change to the way the trigger plugin determines if test jobs should be started on a pull request (PR).

We propose introducing a new label named ok-to-test that will be applied on non-member PRs once they have been /ok-to-test by a legitimate reviewer.

We suggest introducing a new label named ok-to-test that would be required on any non-member PR before automatic test jobs can be started by the trigger plugin.

This label will be added by members of the trusted organization for the repository using the /ok-to-test command, detected with a single GenericCommentEvent handler on corresponding events (issue_comment, pull_request_review, and pull_request_review_comment).

• Discussion Link:

• Primary contact (assignee): @matthyx

• Responsible SIGs:

sig-testing

• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y):
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):

References

• ok-to-test not detected in review approval test-infra#3827
• "/ok-to-test" is not respected when it's inline review comment. test-infra#7801
• Trust a PR if it doesn't have "needs-ok-to-test" test-infra#5246

Implementation History

• 2018-06-25: creation of the KEP
• 2018-07-09: KEP content LGTM during sig-testing presentation
• 2018-07-24: KEP updated to keep needs-ok-to-test for better UX
• 2018-09-03: KEP rewritten with template
• 2018-10-04: KEP merged into master
• 2018-10-08: start of implementation
• 2018-10-10: ok-to-test label added
• 2019-01-29: remove comment parsing code for PR trust

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[matthyx]

@shekhar-rajak do you need help with this?

[shekhar-rajak]

This is created for the PR #2292 , I do not think there is issue for the kep.

[shekhar-rajak]

I needed the issue number as kep-number for the folder structure. Please review the PR and let me know, if we need to any update in the kep.

[matthyx]

I think everything is fine.
Thanks for cleaning my mess!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spiffxp]

/remove-lifecycle rotten
/sig testing

[spiffxp]

/tracked no
/stage stable