-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presubmit config inside the tested repo #2291
Comments
@shekhar-rajak: There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:
Please see the group list for a listing of the SIGs, working groups, and committees available. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@shekhar-rajak hey! What is the purpose of this issue? If this is referring to https://github.com/kubernetes/enhancements/blob/master/keps/sig-testing/20190605-presubmitconfig-in-tested-repo.md , that one is implemented already |
This is created for the PR #2292 , I do not think there is issue for the kep. |
I needed the issue number as kep-number for the folder structure. Please review the PR and let me know, if we need to any update in the kep. |
well, the kep is implemented and there are no to-dos left. Is there really value in adjusting historic keps due to a new format? |
I find that there is few open issues where state is implemented. Not sure if we should open the issue for kep and close it if implemented already and there is no further actions. I think, issue need to be created anyways to track it later as per the new kep template. @wojtek-t please add your points here. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Rotten issues close after 30d of inactivity. Send feedback to sig-contributor-experience at kubernetes/community. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enhancement Description
Presubmit config inside the tested repo
It is proposed to introduce a the option to configure additional presubmits inside
the code repositories that are tested by prow via a file named
prow.yaml
.This requires to change the existing
Config
struct to not expose aPresubmits
property anymore, but instead getter functions to get all Presubmits with the
ones from the
prow.yaml
added, if applicable.Additionally, all components that need to access the
Presubmit
configuration needto be changed to use the new getters and to contain a git client which can be used
to fetch the
Presubmit
config from inside the repo.Discussion Link:
Primary contact (assignee): @alvaroaleman
Responsible SIGs: sig-testing
Enhancement target (which target equals to which milestone):
Alpha
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):Implementation History
for this feature was created that served as initial basis for this KEP.
and how the signatures for the newly-added functions look like was created to
be the basis for a discussion on how exactly an implementation could look like
Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: