Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presubmit config inside the tested repo #2291

Closed
4 tasks
shekhar-rajak opened this issue Jan 19, 2021 · 10 comments
Closed
4 tasks

Presubmit config inside the tested repo #2291

shekhar-rajak opened this issue Jan 19, 2021 · 10 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.

Comments

@shekhar-rajak
Copy link
Member

shekhar-rajak commented Jan 19, 2021

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Presubmit config inside the tested repo

  • Kubernetes Enhancement Proposal:

It is proposed to introduce a the option to configure additional presubmits inside
the code repositories that are tested by prow via a file named prow.yaml.

This requires to change the existing Config struct to not expose a Presubmits
property anymore, but instead getter functions to get all Presubmits with the
ones from the prow.yaml added, if applicable.

Additionally, all components that need to access the Presubmit configuration need
to be changed to use the new getters and to contain a git client which can be used
to fetch the Presubmit config from inside the repo.

  • Discussion Link:

  • Primary contact (assignee): @alvaroaleman

  • Responsible SIGs: sig-testing

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y):
    • Beta release target (x.y):
    • Stable release target (x.y):
  • Alpha

    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update PR(s):

Implementation History

  • A basic but functioning prototype
    for this feature was created that served as initial basis for this KEP.
  • A non-working sketch pull request that shows which parts of Prow need to be touched
    and how the signatures for the newly-added functions look like was created to
    be the basis for a discussion on how exactly an implementation could look like
  • Current work is being tracked via a GitHub tracking issue

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 19, 2021

@shekhar-rajak: There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

  • /sig <group-name>
  • /wg <group-name>
  • /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman
Copy link
Member

alvaroaleman commented Jan 19, 2021

@shekhar-rajak hey! What is the purpose of this issue? If this is referring to https://github.com/kubernetes/enhancements/blob/master/keps/sig-testing/20190605-presubmitconfig-in-tested-repo.md , that one is implemented already

@shekhar-rajak
Copy link
Member Author

shekhar-rajak commented Jan 19, 2021

This is created for the PR #2292 , I do not think there is issue for the kep.

@shekhar-rajak
Copy link
Member Author

shekhar-rajak commented Jan 19, 2021

I needed the issue number as kep-number for the folder structure. Please review the PR and let me know, if we need to any update in the kep.

@alvaroaleman
Copy link
Member

alvaroaleman commented Jan 19, 2021

well, the kep is implemented and there are no to-dos left. Is there really value in adjusting historic keps due to a new format?

@shekhar-rajak
Copy link
Member Author

shekhar-rajak commented Jan 19, 2021

I find that there is few open issues where state is implemented. Not sure if we should open the issue for kep and close it if implemented already and there is no further actions.

I think, issue need to be created anyways to track it later as per the new kep template.

@wojtek-t please add your points here.

@fejta-bot
Copy link

fejta-bot commented Apr 21, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2021
@fejta-bot
Copy link

fejta-bot commented May 21, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2021
@fejta-bot
Copy link

fejta-bot commented Jun 20, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 20, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants