Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric cardinality enforcement #2305

Open
1 of 4 tasks
ehashman opened this issue Jan 21, 2021 · 51 comments
Open
1 of 4 tasks

Metric cardinality enforcement #2305

ehashman opened this issue Jan 21, 2021 · 51 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@ehashman
Copy link
Member

ehashman commented Jan 21, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 21, 2021
@ehashman
Copy link
Member Author

ehashman commented Jan 21, 2021

/sig instrumentation
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2021
@lilic
Copy link
Member

lilic commented Jan 25, 2021

@ehashman is there any action items for either Han or me? Thank you!

@ehashman
Copy link
Member Author

ehashman commented Jan 27, 2021

@lilic this KEP graduated to alpha last cycle (1.20), it would be good to finish up beta and graduation criteria and target releases for those.

@ehashman
Copy link
Member Author

ehashman commented Jan 27, 2021

@lilic @logicalhan once we have beta/graduation criteria we should decide how we want to target milestones for this moving forward. That's all currently empty:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2305-metrics-cardinality-enforcement#post-beta-tasks

@ehashman
Copy link
Member Author

ehashman commented Feb 4, 2021

/milestone v1.21

slipped from 1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 4, 2021
@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 4, 2021
@annajung
Copy link
Member

annajung commented Feb 6, 2021

Hi @logicalhan and @lilic, 1.21 Enhancements Lead here

For the enhancement to be included in the milestone, it must meet the following criteria:

  • [DONE] The KEP must be merged in an implementable state
  • The KEP must have test plans
  • The KEP must have graduation criteria
  • The KEP must have a production readiness review

Please make sure you update the KEP using the latest template.

Also starting 1.21, all KEP must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include this. For PRR review, please make sure to reach out to #prod-readiness slack channel asap to get this in before the enhancements freeze coming up on Feb. 9th.

Thank you!

@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 7, 2021

Hey @logicalhan and @lilic, 1.21 enhancements shadow here,

Just to add to Anna's comment above — enhancement's freeze is 2 days away, Feb 9th EOD PST. Any enhancements that do not complete the requirements in Anna's comment above by the freeze will require an exception.

@ehashman
Copy link
Member Author

ehashman commented Feb 8, 2021

I've pinged @logicalhan about getting this added today.

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Feb 8, 2021

Opened #2468 to update kep and request for PPR approval.

@ehashman
Copy link
Member Author

ehashman commented Feb 10, 2021

@annajung everything should now be addressed.

@annajung
Copy link
Member

annajung commented Feb 10, 2021

With PR #2468 merged, this enhancement meets all criteria required for the enhancements freeze 👍

@alculquicondor
Copy link
Member

alculquicondor commented Feb 11, 2021

ref kubernetes/kubernetes#97208

I have a couple of suggestions for extensions:

  • Can we generalize the proposal to allow for mapping? That is, instead of replacing the value with "unknown", allowing configurable renaming, maybe with numeric intervals or regex.
  • Make this configurable via component configs, as a CLI arg would be harder to maintain.

@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 19, 2021

Hi @logicalhan and @lilic,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@JamesLaverack
Copy link
Member

JamesLaverack commented Mar 2, 2021

Hi @logicalhan and @lilic,

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@ehashman
Copy link
Member Author

ehashman commented Mar 2, 2021

@JamesLaverack I'm updating the point contacts to be @logicalhan and @YoyinZyc

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Mar 2, 2021

@JamesLaverack There is one ongoing pr kubernetes/kubernetes#99385

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Mar 2, 2021

ref kubernetes/kubernetes#97208

I have a couple of suggestions for extensions:

  • Can we generalize the proposal to allow for mapping? That is, instead of replacing the value with "unknown", allowing configurable renaming, maybe with numeric intervals or regex.
  • Make this configurable via component configs, as a CLI arg would be harder to maintain.

I think they are good ideas. I'll keep that in mind. Thanks!

@JamesLaverack
Copy link
Member

JamesLaverack commented Mar 3, 2021

@ehashman Thanks for the clarification! We'll update our tracking spreadsheet to reflect that.

@YoyinZyc Thank you for linking me, i've set this enhancement back to "Tracked". I see that kubernetes/kubernetes#99385 is now merged. Are there any other k/k pull requests outstanding (/need doing before code freeze) or can I mark you as done?

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Mar 4, 2021

Yuchen Zhou Thank you for linking me, i've set this enhancement back to "Tracked". I see that kubernetes/kubernetes#99385 is now merged. Are there any other k/k pull requests outstanding (/need doing before code freeze) or can I mark you as done?

@JamesLaverack I have one more pr kubernetes/kubernetes#99738. Once it is merged, you can mark it as done.:)

@ehashman
Copy link
Member Author

ehashman commented Mar 4, 2021

Code changes are complete, we just need to follow up with documentation updates.

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Mar 4, 2021

Code changes are complete, we just need to follow up with documentation updates.

Can you give me some instruction on which document I should update? I am not sure I know all. Thanks!

@JamesLaverack
Copy link
Member

JamesLaverack commented Mar 5, 2021

Thanks both. I've now updated the enhancement tracking spreadsheet to note this enhancement as done for code freeze.

@k8s-triage-robot
Copy link

k8s-triage-robot commented Mar 10, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Apr 9, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 9, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet
Copy link
Member

dgrisonnet commented Sep 26, 2022

This KEP is still in Alpha, we need to do something about it.

/reopen
/lifecycle frozen

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 26, 2022

@dgrisonnet: Reopened this issue.

In response to this:

This KEP is still in Alpha, we need to do something about it.

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 26, 2022
@dgrisonnet
Copy link
Member

dgrisonnet commented Sep 28, 2022

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 28, 2022
@dgrisonnet
Copy link
Member

dgrisonnet commented Sep 28, 2022

/milestone v1.26

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 28, 2022

@dgrisonnet: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset
Copy link
Contributor

marosset commented Sep 28, 2022

/milestone v1.26
/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 28, 2022
@marosset
Copy link
Contributor

marosset commented Sep 28, 2022

Hello @dgrisonnet 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, I do see #3560.
In addition to the current changes in this PR can you

  • Update the PR to include the updated detailed test plan section in the KEP template
  • Add updated graduation criteria
  • Edit the issue description to provide links to relevant PRs

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@dgrisonnet
Copy link
Member

dgrisonnet commented Sep 29, 2022

Hi @marosset, thank you for the feedback.

Considering that we need to revisit the test plan of the KEP, this would require more involvement than expected, so it would be better to defer the graduation to 1.27. As such, could you please remove the KEP from the list for the 1.26 milestone?

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 29, 2022
@marosset
Copy link
Contributor

marosset commented Sep 29, 2022

No problem.
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Sep 29, 2022
@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 29, 2022
@logicalhan
Copy link
Contributor

logicalhan commented Dec 1, 2022

/assign @rexagod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests