Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric cardinality enforcement #2305

Open
11 of 15 tasks
ehashman opened this issue Jan 21, 2021 · 114 comments
Open
11 of 15 tasks

Metric cardinality enforcement #2305

ehashman opened this issue Jan 21, 2021 · 114 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@ehashman
Copy link
Member

ehashman commented Jan 21, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 21, 2021
@ehashman
Copy link
Member Author

/sig instrumentation
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2021
@lilic
Copy link
Member

lilic commented Jan 25, 2021

@ehashman is there any action items for either Han or me? Thank you!

@ehashman
Copy link
Member Author

@lilic this KEP graduated to alpha last cycle (1.20), it would be good to finish up beta and graduation criteria and target releases for those.

@ehashman
Copy link
Member Author

@lilic @logicalhan once we have beta/graduation criteria we should decide how we want to target milestones for this moving forward. That's all currently empty:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2305-metrics-cardinality-enforcement#post-beta-tasks

@ehashman
Copy link
Member Author

ehashman commented Feb 4, 2021

/milestone v1.21

slipped from 1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 4, 2021
@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 4, 2021
@annajung
Copy link
Contributor

annajung commented Feb 6, 2021

Hi @logicalhan and @lilic, 1.21 Enhancements Lead here

For the enhancement to be included in the milestone, it must meet the following criteria:

  • [DONE] The KEP must be merged in an implementable state
  • The KEP must have test plans
  • The KEP must have graduation criteria
  • The KEP must have a production readiness review

Please make sure you update the KEP using the latest template.

Also starting 1.21, all KEP must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include this. For PRR review, please make sure to reach out to #prod-readiness slack channel asap to get this in before the enhancements freeze coming up on Feb. 9th.

Thank you!

@JamesLaverack
Copy link
Member

Hey @logicalhan and @lilic, 1.21 enhancements shadow here,

Just to add to Anna's comment above — enhancement's freeze is 2 days away, Feb 9th EOD PST. Any enhancements that do not complete the requirements in Anna's comment above by the freeze will require an exception.

@ehashman
Copy link
Member Author

ehashman commented Feb 8, 2021

I've pinged @logicalhan about getting this added today.

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Feb 8, 2021

Opened #2468 to update kep and request for PPR approval.

@ehashman
Copy link
Member Author

@annajung everything should now be addressed.

@annajung
Copy link
Contributor

With PR #2468 merged, this enhancement meets all criteria required for the enhancements freeze 👍

@alculquicondor
Copy link
Member

ref kubernetes/kubernetes#97208

I have a couple of suggestions for extensions:

  • Can we generalize the proposal to allow for mapping? That is, instead of replacing the value with "unknown", allowing configurable renaming, maybe with numeric intervals or regex.
  • Make this configurable via component configs, as a CLI arg would be harder to maintain.

@JamesLaverack
Copy link
Member

Hi @logicalhan and @lilic,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@JamesLaverack
Copy link
Member

Hi @logicalhan and @lilic,

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@ehashman
Copy link
Member Author

ehashman commented Mar 2, 2021

@JamesLaverack I'm updating the point contacts to be @logicalhan and @YoyinZyc

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Mar 2, 2021

@JamesLaverack There is one ongoing pr kubernetes/kubernetes#99385

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Mar 2, 2021

ref kubernetes/kubernetes#97208

I have a couple of suggestions for extensions:

  • Can we generalize the proposal to allow for mapping? That is, instead of replacing the value with "unknown", allowing configurable renaming, maybe with numeric intervals or regex.
  • Make this configurable via component configs, as a CLI arg would be harder to maintain.

I think they are good ideas. I'll keep that in mind. Thanks!

@JamesLaverack
Copy link
Member

@ehashman Thanks for the clarification! We'll update our tracking spreadsheet to reflect that.

@YoyinZyc Thank you for linking me, i've set this enhancement back to "Tracked". I see that kubernetes/kubernetes#99385 is now merged. Are there any other k/k pull requests outstanding (/need doing before code freeze) or can I mark you as done?

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Mar 4, 2021

Yuchen Zhou Thank you for linking me, i've set this enhancement back to "Tracked". I see that kubernetes/kubernetes#99385 is now merged. Are there any other k/k pull requests outstanding (/need doing before code freeze) or can I mark you as done?

@JamesLaverack I have one more pr kubernetes/kubernetes#99738. Once it is merged, you can mark it as done.:)

@ehashman
Copy link
Member Author

ehashman commented Mar 4, 2021

Code changes are complete, we just need to follow up with documentation updates.

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Mar 4, 2021

Code changes are complete, we just need to follow up with documentation updates.

Can you give me some instruction on which document I should update? I am not sure I know all. Thanks!

@JamesLaverack
Copy link
Member

Thanks both. I've now updated the enhancement tracking spreadsheet to note this enhancement as done for code freeze.

@rexagod
Copy link
Member

rexagod commented Feb 25, 2024

perhaps no code changes are expected, [...]

ACK, that's right. I can't edit the description currently but I'll see to it as soon as #4522 is in (and I have the ability to do so). :)

@meganwolf0
Copy link

Hi @rexagod - Code freeze is upon us and I wanted to check back in as the description in this issue is still ambiguous for any expected code changes. Are you able to update so we can make sure this is tracked for code freeze? Thank you!

@salehsedghpour
Copy link
Contributor

Hello @logicalhan @YoyinZyc 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 6, 2024
@liggitt
Copy link
Member

liggitt commented Mar 11, 2024

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

are you sure? #4522 was the only one linked and merged two weeks ago

@salehsedghpour
Copy link
Contributor

My bad, sorry! As it was merged two weeks ago, this can be marked as tracked for code freeze.

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 11, 2024
@drewhagen
Copy link
Member

drewhagen commented Mar 11, 2024

Hello @rexagod 👋 Regarding this:

Hello @drewhagen @fkautz! Since there haven't been any changes marking the stable graduation, I believe kubernetes/website#41998 should suffice for exposing details about this feature. PS. Apologies for not updating the issue description with the website-side link, I've opened #4522 that should allow me to do so for all such instances in the future. 👋🏼

I think there still needs to be a docs PR (against the k8s website) for adding the new feature flag to beta, correct? If you have some time, can you please do this soon? PR Ready for Review is due this week, supposed to be tomorrow March 12th 18:00 PDT, but grace makes sense in this circumstance of short notice. Let me know, thanks!

@sreeram-venkitesh
Copy link
Member

Hi @rexagod 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2024
@rexagod
Copy link
Member

rexagod commented May 14, 2024

/milestone v1.31
/label lead-opted-in

I believe there's nothing more to be done here, but PLMK if you think otherwise. If not, I'll close this out.

@k8s-ci-robot
Copy link
Contributor

@rexagod: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.31
/label lead-opted-in

I believe there's nothing more to be done here, but PLMK if you think otherwise. If not, I'll close this out.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2024
@sreeram-venkitesh
Copy link
Member

/milestone v1.31

@k8s-ci-robot
Copy link
Contributor

@sreeram-venkitesh: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sreeram-venkitesh
Copy link
Member

/milestone v1.31

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Jun 3, 2024
@tjons
Copy link

tjons commented Jun 5, 2024

Hello @rexagod 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage stable for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • Mark the KEP status as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed. Your KEP status is currently marked as implementable for 1.30, but not 1.31.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@sreeram-venkitesh
Copy link
Member

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jun 5, 2024
@salaxander
Copy link
Contributor

Hello @rexagod 👋, 1.31 Docs Shadow here.

Does the work related to this KEP planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

@sreeram-venkitesh
Copy link
Member

With #4695 merged, we can mark this KEP as tracked for enhancements freeze 🎉

@a-mccarthy
Copy link

Hi @rexagod,

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@rexagod
Copy link
Member

rexagod commented Jun 18, 2024

Hello, @a-mccarthy. The website PR was raised a while ago and merged: kubernetes/website#41998.

@a-mccarthy
Copy link

Hello, @a-mccarthy. The website PR was raised a while ago and merged: kubernetes/website#41998.

@rexagod thanks for sharing that PR, it looks like it was for docs content added for 1.29. Are there any new change for 1.31 that we should tell users about in a blog? This would be for any new changes or to give users an introduction to this feature, and would be published here blog, it is different than the docs content. We are checking again now that this is moving to stable in 1.31.

cc: @salaxander since we are also talking about docs :)

If there are any changes to the docs that are needed or if you would like to write a blog, you would need to create 2 separate placeholder PRs. One for docs updates and one for a blog.

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Deferred
Status: Tracked for Code Freeze
Status: Tracked for Code Freeze
Status: Tracked for Enhancements Freeze
Development

No branches or pull requests