legacyflags kflag

[shekhar-rajak]

Enhancement Description

• One-line enhancement description (can be used as a release note): kflag

• Kubernetes Enhancement Proposal:

Create a legacyflags package, which wraps pflag and addresses the pain-points of backwards-compatible
ComponentConfig migration, and selective registration of third-party library flags.

Make it easier for component owners to implement
Versioned Component Configuration Files
(a.k.a. ComponentConfig).

While a number of problems with existing machinery are highlighted in the above doc, this
proposal is focused on the following two use-cases:

• Enforcing flag precedence between values
  specified on the command line and values from a config file, which is required to incrementally
  migrate flags to a config file with backwards compatibility.
• Preventing third-party code from
  implicitly registering flags
  against a component's command-line interface, which is required for components to maintain
  explicit control over their command-line interface.

Rather than require other components to copy and customize the Kubelet's relatively complex
solutions to these problems, we should put the common functionality in a library, legacyflags, to reduce
the burden on component owners.

• Discussion Link:

This proposal recommends the approach in this example PR:

• WIP Kflag example kubernetes#73494

See also @sttts's prototype for an alternative approach that predates this KEP:

• WIP: component: prototyping custom flag semantics kubernetes#72037

• Primary contact (assignee): @mtaufen
• Responsible SIGs: sig-api-machinery
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y):
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):

Implementation History

• 2019-01-29: Initial KEP PR.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[shekhar-rajak]

#2331 created for migrating the old keps into new template.

[LappleApple]

/sig api-machinery

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[k8s-triage-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.