Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposing hashed storage versions via the discovery API #2342

Open
7 of 10 tasks
ghost opened this issue Jan 26, 2021 · 14 comments
Open
7 of 10 tasks

exposing hashed storage versions via the discovery API #2342

ghost opened this issue Jan 26, 2021 · 14 comments
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@ghost
Copy link

ghost commented Jan 26, 2021

Enhancement Description

Motivation

We intend to use the exposed storage version hash to trigger the storage
version migrator
.

In short, the storage version migrator detects if objects in etcd are stored in
a version different than the configured storage version. If so, the migrator
issues no-op update for the objects to migrate them to the storage version.

The storage version migrator can keep track of the versions the objects are
stored as. However, today the migrator has no way to tell what the expected
storage versions are. Thus we propose to expose this piece of information via
the discovery API.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@ghost
Copy link
Author

ghost commented Jan 26, 2021

#2331 created for migrating the old keps into new template.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 26, 2021
@lasomethingsomething
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 8, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2021
@k8s-triage-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 6, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu
Copy link
Member

pacoxu commented Jan 22, 2025

/reopen
@caesarxuchao @roycaihw @liggitt

	genericfeatures.StorageVersionHash: {
		{Version: version.MustParse("1.14"), Default: false, PreRelease: featuregate.Alpha},
		{Version: version.MustParse("1.15"), Default: true, PreRelease: featuregate.Beta},
	},

The feature gate StorageVersionHash keeps beta for a long time. Do we want to promote it to GA?

BTW, https://github.com/kubernetes-sigs/kube-storage-version-migrator has no update for 2 years.

@k8s-ci-robot k8s-ci-robot reopened this Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

@pacoxu: Reopened this issue.

In response to this:

/reopen
@caesarxuchao @roycaihw @liggitt

  genericfeatures.StorageVersionHash: {
  	{Version: version.MustParse("1.14"), Default: false, PreRelease: featuregate.Alpha},
  	{Version: version.MustParse("1.15"), Default: true, PreRelease: featuregate.Beta},
  },

The feature gate StorageVersionHash keeps beta for a long time. Do we want to promote it to GA?

BTW, https://github.com/kubernetes-sigs/kube-storage-version-migrator has no update for 2 years.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacoxu
Copy link
Member

pacoxu commented Jan 22, 2025

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 22, 2025
@roycaihw
Copy link
Member

#2342 (comment)
cc @richabanker @wenjiaswe

@liggitt
Copy link
Member

liggitt commented Jan 23, 2025

I think https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/4192-svm-in-tree might be the replacement for this KEP.

StorageVersionHash was not included in v2 aggregated discovery (see https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3352-aggregated-discovery) ... I'm not sure if that was because it was not expected to be needed or graduate, or for some other reason.

@richabanker
Copy link
Contributor

@enj could you confirm if KEP#4192 is indeed replacing this feature?

@richabanker
Copy link
Contributor

Also, looking at the PRR questionnaire for v2 aggregated discovery it mentions The storage version migrator will have an additional flag when initializing the discovery client to continue using the unaggregated API as the reason for not exposing the SorageVersionHash.

Not sure if that fits well with KEP#4192

@enj
Copy link
Member

enj commented Jan 24, 2025

@enj could you confirm if KEP#4192 is indeed replacing this feature?

#2339 was meant to replace this KEP, since clients like SVM could use the storage version API to drive creation of StorageVersionMigration API objects to automate migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

9 participants