-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cAdvisor-less, CRI-full Container and Pod Stats #2371
Comments
/sig node |
/milestone v1.21 |
Hey @haircommander and @bobbypage, enhancements 1.21 shadow here, Enhancements Freeze is 2 days away, Feb 9th EOD PST The enhancements team is aware that KEP update is currently in progress (PR #2364). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel. Any enhancements that do not complete the following requirements by the freeze will require an exception.
|
Hi @haircommander and @bobbypage, 1.21 Enhancements Lead here. Enhancements Freeze is now in effect. Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible. /milestone clear |
/milestone v1.22 |
Hey @haircommander and @bobbypage - 1.22 enhancements team here! Just a reminder that enhancements freeze is coming up on 5/13. We'll need the KEP merged before then to get this included in the 1.22 release. Let us know if there's anything we can do to help before then! |
@haircommander @bobbypage #2364 merged so we've got you tracked for 1.22 :) |
Hello @haircommander @bobbypage 👋, 1.22 Docs release lead here. Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. |
thanks for the heads up @PI-Victor ! |
xref initial kubelet implementation kubernetes/kubernetes#103095 |
Hey @bobbypage and @haircommander - Just checking in as we're about 2 weeks away from 1.22 code freeze. I've got kubernetes/kubernetes#103095 and kubernetes/kubernetes#103095 tracked as the open k/k PRs. Are there any other open or merged PRs we should be tracking? Thanks! |
none opened yet! I will post them here if we do. Thanks for your work @salaxander |
Hey @haircommander - One more check-in as we're a week out from 1.22 code freeze. Any updates on if you expect kubernetes/kubernetes#103095 and kubernetes/kubernetes#103095 to merge before the deadline? Thanks! |
Thanks for checking! I do expect them to merge. We're waiting on a e2e POC which I'm working on :) |
Hi @haircommander - One last ping (sorry!). Code freeze is tomorrow evening (PST), so those two open PRs will need to merge before then for this to be included in 1.22. Let me know if there's anything we can do to help :) |
@haircommander cgroupV2 https://github.com/containerd/cgroups/blob/main/cgroup2/stats/metrics.pb.go has no network stats as compared to cgroupsV1 https://github.com/containerd/cgroups/blob/main/cgroup1/stats/metrics.pb.go , who are what will provide the networks stats? |
containerd will still need to report the network stats https://github.com/kubernetes/cri-api/blob/master/pkg/apis/runtime/v1/api.proto#L724 I'm not sure how it will do so. CRI-O collects them from /proc directly AFAIR |
technically speaking, k8s doesn't require any metrics be reported, but to start to get feature pairty with cadvisor, this list will probably be the basis |
@haircommander Thanks for the update. The next question would be, what about Filesystem metrics? All the |
|
How are the metrics going to be mapped into proto there are not corresponding field for all the metrics? |
filesystem metrics will stay with cadvisor for now, perf metrics aren't needed as kubelet only requests cadvisor collect these metrics https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cadvisor/cadvisor_linux.go#L85-L94 |
"metrics" are defined as arbitrary key value pairs that cadvisor reported through prometheus. "stats" is a structured object kubelet reports through /stats/summary API "metrics" in this case will be reported through https://github.com/kubernetes/cri-api/blob/master/pkg/apis/runtime/v1/api.proto#L125-L133 |
@haircommander Can you add this to 1.33 project board? |
/label lead-opted-in |
Hello @bitoku @bobbypage @haircommander 👋, v1.33 Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025. This enhancement is targeting stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
in thinking about this more, I don't know if containerd/containerd#10691 will land with enough time to make it into 1.33 (plus, if it does, containerd 2.1 will be released after 1.33 anyway). I think we should hold off on beta until we know we'll move forward on it in containerd /remove-milestone v1.33 |
I see that this issue has been opted-out of |
Clearing the milestone as this KEP has been deferred from current v1.33 release (based on #2371 (comment)). /milestone clear |
Hello @haircommander, @bobbypage 👋, v1.33 Docs Shadow here. Does this enhancement work planned for v1.33 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
Enhancement Description
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s): Document PodAndContainerStatsFromCRI feature website#30535k/enhancements
) update PR(s): KEP 2371: target to beta for 1.28 #3770k/k
) update PR(s):k/website
) update PR(s):k/enhancements
) update PR(s): KEP 2371: retarget to alpha for 1.29 #4249k/k
) update PR(s):k/website
) update PR(s):k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):The text was updated successfully, but these errors were encountered: