Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cAdvisor-less, CRI-full Container and Pod Stats #2371

Open
3 of 8 tasks
haircommander opened this issue Jan 29, 2021 · 67 comments
Open
3 of 8 tasks

cAdvisor-less, CRI-full Container and Pod Stats #2371

haircommander opened this issue Jan 29, 2021 · 67 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@haircommander
Copy link
Contributor

haircommander commented Jan 29, 2021

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 29, 2021
@haircommander
Copy link
Contributor Author

haircommander commented Jan 29, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 29, 2021
@ehashman
Copy link
Member

ehashman commented Feb 2, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 2, 2021
@annajung annajung added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Feb 3, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 7, 2021

Hey @haircommander and @bobbypage, enhancements 1.21 shadow here,

Enhancements Freeze is 2 days away, Feb 9th EOD PST

The enhancements team is aware that KEP update is currently in progress (PR #2364). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [IN PROGRESS] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

@annajung
Copy link
Member

annajung commented Feb 10, 2021

Hi @haircommander and @bobbypage, 1.21 Enhancements Lead here.

Enhancements Freeze is now in effect.

Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.21 milestone Feb 10, 2021
@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Feb 10, 2021
@ehashman
Copy link
Member

ehashman commented May 4, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 5, 2021
@salaxander
Copy link

salaxander commented May 7, 2021

Hey @haircommander and @bobbypage - 1.22 enhancements team here! Just a reminder that enhancements freeze is coming up on 5/13. We'll need the KEP merged before then to get this included in the 1.22 release.

Let us know if there's anything we can do to help before then!

@salaxander
Copy link

salaxander commented May 13, 2021

@haircommander @bobbypage #2364 merged so we've got you tracked for 1.22 :)

@PI-Victor
Copy link
Member

PI-Victor commented May 18, 2021

Hello @haircommander @bobbypage 👋, 1.22 Docs release lead here.
This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@haircommander
Copy link
Contributor Author

haircommander commented May 19, 2021

thanks for the heads up @PI-Victor !

@ehashman
Copy link
Member

ehashman commented Jun 18, 2021

xref kubernetes/kubernetes#102789

@haircommander
Copy link
Contributor Author

haircommander commented Jun 22, 2021

xref initial kubelet implementation kubernetes/kubernetes#103095

@salaxander
Copy link

salaxander commented Jun 23, 2021

Hey @bobbypage and @haircommander - Just checking in as we're about 2 weeks away from 1.22 code freeze. I've got kubernetes/kubernetes#103095 and kubernetes/kubernetes#103095 tracked as the open k/k PRs. Are there any other open or merged PRs we should be tracking? Thanks!

@haircommander
Copy link
Contributor Author

haircommander commented Jun 23, 2021

none opened yet! I will post them here if we do. Thanks for your work @salaxander

@salaxander
Copy link

salaxander commented Jul 2, 2021

Hey @haircommander - One more check-in as we're a week out from 1.22 code freeze. Any updates on if you expect kubernetes/kubernetes#103095 and kubernetes/kubernetes#103095 to merge before the deadline?

Thanks!

@haircommander
Copy link
Contributor Author

haircommander commented Jul 2, 2021

Thanks for checking! I do expect them to merge. We're waiting on a e2e POC which I'm working on :)

@salaxander
Copy link

salaxander commented Jul 8, 2021

Hi @haircommander - One last ping (sorry!). Code freeze is tomorrow evening (PST), so those two open PRs will need to merge before then for this to be included in 1.22. Let me know if there's anything we can do to help :)

@marosset
Copy link
Contributor

marosset commented Sep 30, 2022

/milestone v1.26
/label lead-opted-in
(I'm doing this on behalf of @ruiwen-zhao / SIG-node)

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 30, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

Is this graduating to beta or should we track it as a major change to alpha?

/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 1, 2022
@haircommander
Copy link
Contributor Author

haircommander commented Oct 3, 2022

we'll be making a major change to alpha in 1.26

@rhockenbury rhockenbury added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Oct 3, 2022
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 3, 2022

/milestone v1.26
/label lead-opted-in

@rhockenbury
Copy link

rhockenbury commented Oct 3, 2022

Hello @haircommander and @bobbypage 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the KEP yaml to reflect the latest milestones.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

We would also need to have the milestone stages updated in the KEP yaml - https://github.com/kubernetes/enhancements/pull/3559/files#diff-0ed5ee24cb73f3749f465e3aa48380d7daf115cdb2e1e83bb2c0aa3c4786d662R22

@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

I'll mark this as tracked for enhancements freeze but please update the milestone stages in the KEP yaml.

@haircommander
Copy link
Contributor Author

haircommander commented Oct 7, 2022

@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

Okay, I think it should be fine. I was referring to this line, but since this went into alpha in v1.23, we should probably leave it as v1.23 rather than updating to v1.26.

Thanks!

@ruheenaansari34
Copy link

ruheenaansari34 commented Nov 2, 2022

Hi @haircommander 👋,

Checking in once more as we approach the 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any k/k PRs, other than kubernetes/kubernetes#103095. If you do have k/k PRs open, please link them to this issue.

As always, we are here to help should questions come up. Thanks!

@krol3
Copy link

krol3 commented Nov 7, 2022

Hello @haircommander 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@krol3
Copy link

krol3 commented Nov 11, 2022

Hello @haircommander and @bobbypage 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

@haircommander
Copy link
Contributor Author

haircommander commented Nov 11, 2022

I think we can not have docs for this release. How do we opt-out?

@krol3
Copy link

krol3 commented Nov 14, 2022

@reylejano , This KEP is keeping the 1.23 version, we don't need to update the doc for 1.26.

@haircommander
Copy link
Contributor Author

haircommander commented Nov 14, 2022

we did have new pieces for alpha retargeted at 1.26, but I don't think they require documentation

@krol3
Copy link

krol3 commented Nov 16, 2022

Hi @haircommander , I think at least we will need to update the new changes of these feature PodAndContainerStatsFromCRI
in https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

cc: @reylejano

@palnabarun
Copy link
Member

palnabarun commented Nov 18, 2022

kubernetes/website#33509 is relevant here.

@krol3
Copy link

krol3 commented Nov 18, 2022

@haircommander and @bobbypage could you help with the documentation relevant for the release 1.26?

@haircommander
Copy link
Contributor Author

haircommander commented Nov 18, 2022

I've opened kubernetes/website#37962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Major Change
Development

No branches or pull requests