Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node swap support #2400

Open
10 of 19 tasks
ehashman opened this issue Feb 1, 2021 · 44 comments
Open
10 of 19 tasks

Node swap support #2400

ehashman opened this issue Feb 1, 2021 · 44 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@ehashman
Copy link
Member

ehashman commented Feb 1, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig node

No work expected for the 1.21 milestone outside of drafting KEP/requirements. Just wanted to get a tracking issue filed for the backlog.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 1, 2021
@karan
Copy link
Member

karan commented Feb 9, 2021

@cookieisaac

@ehashman
Copy link
Member Author

ehashman commented Apr 28, 2021

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2021
@ehashman ehashman self-assigned this May 10, 2021
@jrsapi
Copy link

jrsapi commented May 11, 2021

Greetings @ehashman!
Enhancement shadow checking in with a few reminders. 1.22 Enhancements Freeze starts at 23:59:59 pst on Thursday, May 13. A few items needing review for this KEP:

Thanks!

@ehashman
Copy link
Member Author

ehashman commented May 11, 2021

All of this is covered in #2602

@jrsapi
Copy link

jrsapi commented May 13, 2021

Greetings @ehashman!
Thanks for the follow-up. After reviewing the KEP and PRR everything looks on target. The enhancement is marked at risk but once merged we can move its status to tracked. A reminder that tomorrow 5/13 the Enhancement freeze starts at 23:59:59 PST.

Thanks!

@ehashman
Copy link
Member Author

ehashman commented May 19, 2021

Work breakdown for 1.22

  • Documentation for enabling swap (TBD - @ehashman?)
  • CI environment/test updates (@ike-ma)
    • Build images with swap for 2 Linux distros
    • Add jobs to test-infra that use the images and enable the swap feature flag/kubelet option for node e2e suite
    • See also Test Plan
  • CRI and kubelet changes (@ehashman)
    • Complete API changes per KEP
    • Add e2e tests as appropriate

External to k8s but still need to happen:

  • Containerd update to use new CRI
  • CRI-O update to use new CRI

Once the above CRI updates happen, ensure that CI environment is using latest container runtimes with updated CRI.

@jrsapi
Copy link

jrsapi commented Jun 24, 2021

Greetings @ehashman ,
Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you like the k/k PR/s that are needed to implement this enhancement for the 1.22 milestone?

@jrsapi
Copy link

jrsapi commented Jul 6, 2021

Greetings @ehashman,
A friendly reminder that code freeze is this Thursday, July 8th and we're tracking the following k/k PR:

Thanks!

@ehashman
Copy link
Member Author

ehashman commented Jul 7, 2021

PR just merged. Docs placeholder is kubernetes/website#28838

@jrsapi
Copy link

jrsapi commented Jul 7, 2021

Awesome! Thanks for the update. Moving this to "Tracked".

@ehashman
Copy link
Member Author

ehashman commented Jul 21, 2021

We are good to go for 1.22! Docs complete.

@ehashman
Copy link
Member Author

ehashman commented Aug 12, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Aug 12, 2021
@ehashman
Copy link
Member Author

ehashman commented Aug 12, 2021

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Aug 12, 2021
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Oct 3, 2022

/remove-label lead-opted-in

no volunteer has come forward yet this release to push this work further, it will remain unchanged in 1.26.

@derekwaynecarr I plan to move this forward, not to beta, but to more clarity. See #3571.

@rhockenbury
Copy link

rhockenbury commented Oct 3, 2022

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 3, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

It looks like we would still need to update the KEP readme to use the latest template to meet all requirements for enhancements freeze.

@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 7, 2022
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Oct 7, 2022

/assign

@rhockenbury I changed the formatting of TestPlan and added some links to tests we introduced in Alpha stage. Can this be returned back to milestone without the exception process since the content was not modified?

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Oct 7, 2022

/unassign @ehashman

(@ehashman please feel free to re-assign back to yourself)

@rhockenbury
Copy link

rhockenbury commented Oct 8, 2022

Alright, thanks for making those changes. I have it marked as tracked now but can you please also update the KEP yaml to set stage: alpha? - https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2400-node-swap/kep.yaml#L21

/milestone v1.26
/label tracked/yes
/label lead-opted-in
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 8, 2022
@k8s-ci-robot k8s-ci-robot added lead-opted-in Denotes that an issue has been opted in to a release and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 8, 2022
@ehashman
Copy link
Member Author

ehashman commented Oct 13, 2022

@SergeyKanzhelev I am not planning on working on this at this time, please feel free to continue driving it forward and let me know if you need any feedback/reviews.

@cathchu
Copy link

cathchu commented Nov 2, 2022

Hello @SergeyKanzhelev 👋 1.26 Release Docs shadow here!

This enhancement is marked as ‘Needs Docs’ for 1.26 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@Atharva-Shinde
Copy link

Atharva-Shinde commented Nov 7, 2022

Hey @ehashman @SergeyKanzhelev 👋, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow.
Looks like we would at least need to get the code PR/s:
kubernetes/kubernetes#105019
kubernetes/kubernetes#105020
kubernetes/kubernetes#105021
kubernetes/kubernetes#105022
kubernetes/kubernetes#105023
kubernetes/kubernetes#105025
kubernetes/kubernetes#105978 (any other PRs?) merged before the code-freeze :)

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Major Change
Node Swap Beta
  
To do
Development

No branches or pull requests