Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node memory swap support #2400

Open
31 of 44 tasks
ehashman opened this issue Feb 1, 2021 · 134 comments
Open
31 of 44 tasks

Node memory swap support #2400

ehashman opened this issue Feb 1, 2021 · 134 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@ehashman
Copy link
Member

ehashman commented Feb 1, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 1, 2021
@karan
Copy link

karan commented Feb 9, 2021

@cookieisaac

@ehashman
Copy link
Member Author

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2021
@ehashman ehashman self-assigned this May 10, 2021
@jrsapi
Copy link

jrsapi commented May 11, 2021

Greetings @ehashman!
Enhancement shadow checking in with a few reminders. 1.22 Enhancements Freeze starts at 23:59:59 pst on Thursday, May 13. A few items needing review for this KEP:

Thanks!

@ehashman
Copy link
Member Author

All of this is covered in #2602

@jrsapi
Copy link

jrsapi commented May 13, 2021

Greetings @ehashman!
Thanks for the follow-up. After reviewing the KEP and PRR everything looks on target. The enhancement is marked at risk but once merged we can move its status to tracked. A reminder that tomorrow 5/13 the Enhancement freeze starts at 23:59:59 PST.

Thanks!

@ehashman
Copy link
Member Author

Work breakdown for 1.22

  • Documentation for enabling swap (TBD - @ehashman?)
  • CI environment/test updates (@ike-ma)
    • Build images with swap for 2 Linux distros
    • Add jobs to test-infra that use the images and enable the swap feature flag/kubelet option for node e2e suite
    • See also Test Plan
  • CRI and kubelet changes (@ehashman)
    • Complete API changes per KEP
    • Add e2e tests as appropriate

External to k8s but still need to happen:

  • Containerd update to use new CRI
  • CRI-O update to use new CRI

Once the above CRI updates happen, ensure that CI environment is using latest container runtimes with updated CRI.

@jrsapi
Copy link

jrsapi commented Jun 24, 2021

Greetings @ehashman ,
Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you like the k/k PR/s that are needed to implement this enhancement for the 1.22 milestone?

@jrsapi
Copy link

jrsapi commented Jul 6, 2021

Greetings @ehashman,
A friendly reminder that code freeze is this Thursday, July 8th and we're tracking the following k/k PR:

Thanks!

@ehashman
Copy link
Member Author

ehashman commented Jul 7, 2021

PR just merged. Docs placeholder is kubernetes/website#28838

@jrsapi
Copy link

jrsapi commented Jul 7, 2021

Awesome! Thanks for the update. Moving this to "Tracked".

@ehashman
Copy link
Member Author

We are good to go for 1.22! Docs complete.

@ehashman
Copy link
Member Author

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Aug 12, 2021
@ehashman
Copy link
Member Author

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Aug 12, 2021
@harche
Copy link
Contributor

harche commented Oct 31, 2023

Hi @ehashman @pacoxu @SergeyKanzhelev ! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

I am afraid, due to pending issues we won't be able to graduate swap to beta2 in 1.29.

@npolshakova
Copy link

npolshakova commented Nov 1, 2023

Hello @ehashman @pacoxu @SergeyKanzhelev 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

@kannon92
Copy link
Contributor

@pacoxu are you able to add some PRs to beta2 section? I have been working on this feature but I am unable to edit the description to keep this up to date.

@kannon92
Copy link
Contributor

Scheduling workloads for Swap on hetergenous cluster (some nodes have swap enabled and others do not) - kubernetes/kubernetes#122279

LimitedSwap Tests - kubernetes/kubernetes#122175

Fail fast for cgroup v1 and swap - kubernetes/kubernetes#122241

I have also updated all the swap tests to be passing now. It was a mix of PRs.

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@kannon92
Copy link
Contributor

kubernetes/kubernetes#121820 is also related for testing.

@marquiz
Copy link
Contributor

marquiz commented Jan 16, 2024

@kannon92 et al: related to the SIG Node discussion meeting today, the QoS resources KEP (issue, PR) lists per-application swap control as one potential use case (albeit a short mention when under memory QoS). It would give per-node visibility (where swap is available) and scheduler support, for example.

@SergeyKanzhelev
Copy link
Member

/stage beta
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 26, 2024
@salehsedghpour
Copy link
Contributor

Hello @SergeyKanzhelev @kannon92 and @iholder101 , 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@kannon92
Copy link
Contributor

@SergeyKanzhelev can you add that label? I think we have everything on my end.

@mrunalp
Copy link
Contributor

mrunalp commented Feb 1, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 1, 2024
@mickeyboxell
Copy link

mickeyboxell commented Feb 5, 2024

Hello @kannon92 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on [02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca):.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

It looks like all of the above were created for your beta1 release, but now need to be refreshed for your beta2 release.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@kannon92
Copy link
Contributor

kannon92 commented Feb 7, 2024

@mickeyboxell I think everything should be good on this one.

@mickeyboxell
Copy link

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@Princesso
Copy link

Hello @ehashman, @kannon92 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@kannon92
Copy link
Contributor

Hello @Princesso I opened up kubernetes/website#45128.

@jabdoa2
Copy link

jabdoa2 commented Feb 14, 2024

I can confirm that this works well if you set --experimental-allocatable-ignore-eviction (i.e. via kubernetes/kops#15821) on kubelet to prevent memory evictions. Allows you to pack tighter with very performance penalties. Especially useful for java workloads.

@Checksumz
Copy link

Hi @ehashman,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@iholder101
Copy link
Contributor

Hey all!

I'm sorry for disappearing for so long. It was due to the unfortunate events in my country that have led to me being drafted for a more than 4 months of active military service.

In any case, I'm back now and intend to dedicate the vast majority of my time around the swap feature and other SIG-NODE related features. After some catching up I would be more than happy to help in any way I can.

Thanks for understanding.

@mickeyboxell
Copy link

Hey again @kannon92 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Major Change
Status: Removed From Milestone
Status: Tracked
Status: Removed from Milestone
Status: At Risk for Code Freeze
Node Swap Beta
  
In progress
Development

No branches or pull requests