Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend podresources API to report allocatable resources #2403

Open
fromanirh opened this issue Feb 2, 2021 · 27 comments
Open

Extend podresources API to report allocatable resources #2403

fromanirh opened this issue Feb 2, 2021 · 27 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@fromanirh
Copy link
Contributor

fromanirh commented Feb 2, 2021

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Extend the podresources API to report the allocatable compute resources
  • Kubernetes Enhancement Proposal:
    Add GetAllocatableResource to PodResource API #2404
  • Discussion Link: SIG Node Meeting 20200811: Recording, Slides
    Slack thread for introducing GetAllocatableResources() endpoint (previously called GetAvailableResources) in podresource API
  • Primary contact (assignee):
    Francesco Romani (@fromanirh)
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y):
    • Beta release target (x.y):
    • Stable release target (1.21):

Previous/Related work:

  • initial issue - initially targeting 1.20, we are creating a separate issue + KEP to clearly describe this unit of work.

PRs:

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 2, 2021
@fromanirh
Copy link
Contributor Author

fromanirh commented Feb 2, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 2, 2021
@fromanirh
Copy link
Contributor Author

fromanirh commented Feb 2, 2021

rationale for this split in this slack conversation

the main goal is to make this change easier to review

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Feb 2, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 2, 2021
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Feb 3, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 7, 2021

Hey @fromanirh, enhancements 1.21 shadow here,

Enhancements Freeze is 2 days away, Feb 9th EOD PST

The enhancements team is aware that KEP update is currently in progress (PR #2404). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [IN PROGRESS] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 19, 2021

Hi @fromanirh,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@fromanirh
Copy link
Contributor Author

fromanirh commented Feb 20, 2021

Hi @fromanirh,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

* Tuesday, March 9th: Week 9 — Code Freeze

* Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
  
  * If this enhancement requires new docs or modification to existing docs, please follow the steps in the [Open a placeholder PR doc](https://kubernetes.io/docs/contribute/new-content/new-features/#open-a-placeholder-pr) to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

Thanks for the reminder!
I don't think this enhancement requires a k/website PR, but I'll doublecheck and file a placeholder PR if needed.
Implementation PR: kubernetes/kubernetes#95734

@JamesLaverack
Copy link
Member

JamesLaverack commented Mar 6, 2021

Hi @fromanirh,

A friendly reminder that Code freeze is 3 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@annajung
Copy link
Member

annajung commented Mar 9, 2021

Hi @fromanirh, with kubernetes/kubernetes#95734 merged in, we will mark this as code complete.

@fromanirh
Copy link
Contributor Author

fromanirh commented Mar 9, 2021

yes, thanks!

@annajung annajung added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Apr 8, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 26, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 24, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2021
@ehashman
Copy link
Member

ehashman commented Sep 2, 2021

/milestone v1.23

per 08/24 Node meeting

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.23 Sep 2, 2021
@ehashman
Copy link
Member

ehashman commented Sep 2, 2021

/stage beta

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Sep 2, 2021
@salaxander
Copy link

salaxander commented Sep 2, 2021

Hi @fromanirh! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo. (PR open)
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (PR open)

As long as that PR merge by enhancements freeze, we should be all good!

Thanks!

@swatisehgal
Copy link
Contributor

swatisehgal commented Sep 6, 2021

Graduating PodResource API GetAllocatableResource to Beta in 1.23 release:

@salaxander salaxander added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 7, 2021
@jlbutler
Copy link

jlbutler commented Sep 17, 2021

Hi @swatisehgal @fromanirh 👋 1.23 Docs lead here

This enhancement issue is listed as "Needs Docs" for the 1.23 release. I see a docs PR is open (k/website 28074), can you point it at the dev-1.23 branch in k/website please?

For more info, please refer to the steps in the documentation. Ping if you have any questions.

Thanks!

@swatisehgal
Copy link
Contributor

swatisehgal commented Sep 20, 2021

Hi @swatisehgal @fromanirh 1.23 Docs lead here

This enhancement issue is listed as "Needs Docs" for the 1.23 release. I see a docs PR is open (k/website 28074), can you point it at the dev-1.23 branch in k/website please?

For more info, please refer to the steps in the documentation. Ping if you have any questions.

Thanks!

Thanks @jlbutler, I have created a docs PR that points to dev-1.23 branch in k/website here: kubernetes/website#29751. Let me know if there is anything else you need from my end.

@salaxander
Copy link

salaxander commented Nov 8, 2021

Hi @swatisehgal @fromanirh 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

@fromanirh
Copy link
Contributor Author

fromanirh commented Nov 9, 2021

hi @salaxander ! @swatisehgal has already tracked the items you mentioned in #2403 (comment) . Please let us know if something's missing!

@fromanirh
Copy link
Contributor Author

fromanirh commented Nov 17, 2021

Graduating PodResource API GetAllocatableResource to Beta in 1.23 release:

All PRs merged!

EDIT: fix formatting

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 9, 2022
@gracenng gracenng removed this from the v1.23 milestone Jan 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Apr 9, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 9, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 9, 2022
@swatisehgal
Copy link
Contributor

swatisehgal commented May 9, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 7, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2022
@fromanirh
Copy link
Contributor Author

fromanirh commented Aug 8, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 6, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022
@fromanirh
Copy link
Contributor Author

fromanirh commented Nov 7, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
None yet
Development

No branches or pull requests