CRIContainerLogRotation

[umohnani8]

Enhancement Description

• One-line enhancement description (can be used as a release note): Kubelet manages CRI container log rotation.
• Kubernetes Enhancement Proposal: Add KEP for enabling CRIContainerLogRotation by default #2418
• Discussion Link: In original design doc
• Primary contact (assignee): @umohnani8
• Responsible SIGs: Node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.10
  • Beta release target (x.y): 1.11
  • Stable release target (x.y): 1.21
• Stable
  • KEP (k/enhancements) update PR(s): Update CRIContainerLogRotation KEP #2547
  • Code (k/k) update PR(s): Move CRIContainerLogRotation to GA kubernetes#99651
  • Docs (k/website) update PR(s): Update docs for CRIContainerLogRotation website#26799

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

This feature predates the KEP process. According to the timeline in the original issue discussing this feature kubernetes/kubernetes#58823, it was Alpha in v1.10 and moved to Beta in v1.11. This issue is to track the enhancement for graduating this feature to stable.

/sig node
/milestone v1.21

[k8s-ci-robot]

@umohnani8: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

Enhancement Description

• One-line enhancement description (can be used as a release note): Kubelet manages CRI container log rotation.
• Kubernetes Enhancement Proposal:
• Discussion Link: In original design doc
• Primary contact (assignee): @umohnani8
• Responsible SIGs: Node
• Enhancement target (which target equals to which milestone):
• Alpha release target (x.y): 1.10
• Beta release target (x.y): 1.11
• Stable release target (x.y): 1.21
• Stable
• KEP (k/enhancements) update PR(s):
• Code (k/k) update PR(s):
• Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

This feature predates the KEP process. According to the timeline in the original issue discussing this feature kubernetes/kubernetes#58823, it was Alpha in v1.10 and moved to Beta in v1.11. This issue is to track the enhancement for graduating this feature to stable.

/sig node
/milestone v1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

cc @ehashman

[dims]

@umohnani8 is there any pending issues/prs that need to be worked on to mark this as stable?

[umohnani8]

@dims there is one issue on some logs being lost when rotation happens kubernetes/kubernetes#64760

[ehashman]

Linking original design doc from the community repo: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/kubelet-cri-logging.md

[dims]

@umohnani8 i don't think that issue is valid anymore ... asked a question there, hopefully we don't have to do anything there.

[jrsapi]

Greetings @umohnani8! 1.21 Enhancement shadow checking in with some reminders.

Enhancements Freeze is 2 days away, Feb 9th EOD PST. Enhancements team is aware that KEP update is currently in progress.
Any enhancements that do not complete the following requirements by the freeze will require an exception.
[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria
[DONE] The KEP must have a production readiness review
Also as mentioned by @annajung on (PR 2418)
"In addition to PRR questionnaires, you have to create a k/enhancements/prod-readiness//.yaml file, with the PRR approver's GitHub handle for the specific stage as stated in the submitting KEP for PRR approval doc.Then, you'll need to get PRR reviewed asap and you can do that by asking for a review in the #prod-readiness slack channel.
Please remember that Enhancements freeze is 2 days away (Feb 9th) and this must be merged in with the requirements stated above to make sure this enhancement lands in 1.21."

[jrsapi]

Greetings @umohnani8
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
• If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!

[jrsapi]

Greetings @umohnani8,
The enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so the release team can track it.

[umohnani8]

Linked k/k PR and k/website draft PR.

[jrsapi]

Greetings @umohnani8,

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST
Any enhancements that are NOT code complete by the freeze will be removed from the milestone will require an exception to be added back.
Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST.
Thanks!

[umohnani8]

The docs PR got merged and the graduation for CRIContainerLogRotation is done now I believe. Should this issue be closed?

[annajung]

Hi @umohnani8 1.21 Enhancement Lead here.

Can you update the kep.yaml to reflect a status of implemented:

enhancements/keps/sig-node/2411-cri-container-log-rotation/kep.yaml

Line 9 in 29a891b

status: implemented

Once that merges, we can close out this issue.

[umohnani8]

Hi @annajung, the status is set to implemented already, what exactly would you like me to change?

[annajung]

oops! sorry, I must have misread it, then feel free to close out the issue! thanks!

[umohnani8]

Perfect! This issue is all set :)