Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRIContainerLogRotation #2411

Closed
4 tasks done
umohnani8 opened this issue Feb 3, 2021 · 16 comments
Closed
4 tasks done

CRIContainerLogRotation #2411

umohnani8 opened this issue Feb 3, 2021 · 16 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@umohnani8
Copy link
Contributor

umohnani8 commented Feb 3, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

This feature predates the KEP process. According to the timeline in the original issue discussing this feature kubernetes/kubernetes#58823, it was Alpha in v1.10 and moved to Beta in v1.11. This issue is to track the enhancement for graduating this feature to stable.

/sig node
/milestone v1.21

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 3, 2021

@umohnani8: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

Enhancement Description

  • One-line enhancement description (can be used as a release note): Kubelet manages CRI container log rotation.
  • Kubernetes Enhancement Proposal:
  • Discussion Link: In original design doc
  • Primary contact (assignee): @umohnani8
  • Responsible SIGs: Node
  • Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.10
  • Beta release target (x.y): 1.11
  • Stable release target (x.y): 1.21
  • Stable
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

This feature predates the KEP process. According to the timeline in the original issue discussing this feature kubernetes/kubernetes#58823, it was Alpha in v1.10 and moved to Beta in v1.11. This issue is to track the enhancement for graduating this feature to stable.

/sig node
/milestone v1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 3, 2021
@umohnani8 umohnani8 changed the title CRI Log Rotation CRIContainerLogRotation Feb 3, 2021
@dims
Copy link
Member

dims commented Feb 3, 2021

cc @ehashman

@dims
Copy link
Member

dims commented Feb 3, 2021

@umohnani8 is there any pending issues/prs that need to be worked on to mark this as stable?

@umohnani8
Copy link
Contributor Author

umohnani8 commented Feb 3, 2021

@dims there is one issue on some logs being lost when rotation happens kubernetes/kubernetes#64760

@ehashman
Copy link
Member

ehashman commented Feb 3, 2021

@annajung annajung added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Feb 3, 2021
@annajung annajung added this to the v1.21 milestone Feb 3, 2021
@dims
Copy link
Member

dims commented Feb 3, 2021

@umohnani8 i don't think that issue is valid anymore ... asked a question there, hopefully we don't have to do anything there.

@jrsapi
Copy link

jrsapi commented Feb 8, 2021

Greetings @umohnani8! 1.21 Enhancement shadow checking in with some reminders.

Enhancements Freeze is 2 days away, Feb 9th EOD PST. Enhancements team is aware that KEP update is currently in progress.
Any enhancements that do not complete the following requirements by the freeze will require an exception.
[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria
[DONE] The KEP must have a production readiness review
Also as mentioned by @annajung on (PR 2418)
"In addition to PRR questionnaires, you have to create a k/enhancements/prod-readiness//.yaml file, with the PRR approver's GitHub handle for the specific stage as stated in the submitting KEP for PRR approval doc.Then, you'll need to get PRR reviewed asap and you can do that by asking for a review in the #prod-readiness slack channel.
Please remember that Enhancements freeze is 2 days away (Feb 9th) and this must be merged in with the requirements stated above to make sure this enhancement lands in 1.21."

@jrsapi
Copy link

jrsapi commented Feb 18, 2021

Greetings @umohnani8
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
• If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!

@jrsapi
Copy link

jrsapi commented Mar 2, 2021

Greetings @umohnani8,
The enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so the release team can track it.

@umohnani8
Copy link
Contributor Author

umohnani8 commented Mar 2, 2021

Linked k/k PR and k/website draft PR.

@jrsapi
Copy link

jrsapi commented Mar 4, 2021

Greetings @umohnani8,

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST
Any enhancements that are NOT code complete by the freeze will be removed from the milestone will require an exception to be added back.
Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST.
Thanks!

@umohnani8
Copy link
Contributor Author

umohnani8 commented Mar 18, 2021

The docs PR got merged and the graduation for CRIContainerLogRotation is done now I believe. Should this issue be closed?

@annajung
Copy link
Member

annajung commented Apr 8, 2021

Hi @umohnani8 1.21 Enhancement Lead here.

Can you update the kep.yaml to reflect a status of implemented:

Once that merges, we can close out this issue.

@umohnani8
Copy link
Contributor Author

umohnani8 commented Apr 8, 2021

Hi @annajung, the status is set to implemented already, what exactly would you like me to change?

@annajung
Copy link
Member

annajung commented Apr 8, 2021

oops! sorry, I must have misread it, then feel free to close out the issue! thanks!

@umohnani8
Copy link
Contributor Author

umohnani8 commented Apr 8, 2021

Perfect! This issue is all set :)

@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

7 participants