Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology Aware Hints #2433

Open
4 tasks done
robscott opened this issue Feb 5, 2021 · 53 comments
Open
4 tasks done

Topology Aware Hints #2433

robscott opened this issue Feb 5, 2021 · 53 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@robscott
Copy link
Member

robscott commented Feb 5, 2021

Enhancement Description

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Feb 5, 2021
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Feb 9, 2021
@annajung annajung added this to the v1.21 milestone Feb 9, 2021
@robscott
Copy link
Member Author

robscott commented Feb 22, 2021

/assign

@kendallroden
Copy link
Contributor

kendallroden commented Feb 24, 2021

Hi @robscott ,
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
  • As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@JornShen
Copy link
Member

JornShen commented Feb 26, 2021

@robscott What' the develop process of this feature? I am interested in it. Is there something I can help to do ? :)

@robscott
Copy link
Member Author

robscott commented Mar 2, 2021

Hey @JornShen thanks for checking in! If you have time, I'd really appreciate any review or testing of my related PR: kubernetes/kubernetes#99522.

@kendallroden
Copy link
Contributor

kendallroden commented Mar 5, 2021

Hey @robscott! I know you are aware based on other enhancement work that code freeze is coming up on March 9th EOD PST and if any PRs are not merged by the deadline, you'll have to request an exception! Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST
Thanks!

@annajung
Copy link
Member

annajung commented Mar 9, 2021

Hi @robscott, with kubernetes/kubernetes#99522 merged in, we will mark this as code complete for 1.21 release.

@reylejano
Copy link
Member

reylejano commented Mar 12, 2021

Hello @robscott , 1.21 Docs lead here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@robscott
Copy link
Member Author

robscott commented Mar 12, 2021

Hey @reylejano, thanks for checking in! This will require some significant docs additions. I'll make sure to have a docs PR ready before that deadline.

@aojea aojea added this to Alpha in SIG-Network KEPs Apr 17, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 1, 2021

/milestone v1.22
/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels May 1, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 May 1, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 1, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 8, 2021

Hey @robscott, 1.22 Enhancements Lead here,

I have a few questions about your enhancement, as it is currently targeted for 1.22.

  • Your kep.yaml needs updating to reflect the graduation. The latest-milestone should be set to "v1.22".

I'm assuming you're targeting beta for this release (if you're not please let me know!) in which case we will also require:

  • Your KEP must list graduation critera for beta.
  • You will require a beta PRR review from the PRR team.

We require these merged into master by enhancements freeze at 23:59:59 on Thursday 13th May, or else require an exception after this deadline.

Please do reach out if you have any questions.

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 30, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

Hello @robscott 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, please plan to open a PR to update the KEP yaml, KEP readme and PRR file.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@robscott
Copy link
Member Author

robscott commented Oct 1, 2022

Hey @rhockenbury, thanks for checking in! I've created #3572 to update the KEP.

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

To meet the requirements, we would also need to update the KEP readme in #3572 to use latest test plan template.

@robscott
Copy link
Member Author

robscott commented Oct 6, 2022

Thanks for catching that @rhockenbury, I've updated the KEP to include the latest test plan template. Unfortunately https://storage.googleapis.com/k8s-triage/index.html was not working for me. Regardless of the input I tried, I got "0 clusters of 0 failures out of 0 builds from Invalid Date to Invalid Date."

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

We would still need to add the test update agreement which needs to be checked and included in the kep readme.

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

Thanks! Marked as tracked for v1.26.

@jonathon2nd
Copy link

jonathon2nd commented Oct 18, 2022

In addition, with the previous feature you could route to endpoints on the same host, is this functionality now gone? Only zone routing is taking place?

I am also trying to see about using Topology Aware Hints because Topology-aware traffic routing with topology keys has been deprecated. We were using it to ensure optimal routing for high bandwidth services, to keep traffic on the same node if possible.

Is there doc that lists the various different hints that could be set? I am hoping that there is forHosts or something of the like.

Thanks in advanced, if I am missing something obvious I am sorry.

@jonathon2nd
Copy link

jonathon2nd commented Oct 18, 2022

Wait the only hint is ForZone?
https://pkg.go.dev/k8s.io/api/discovery/v1#EndpointHints

That makes this , not really accurate, right? Or am I missing something obvious?

Note: This feature, specifically the alpha topologyKeys API, is deprecated since Kubernetes v1.21. Topology Aware Hints, introduced in Kubernetes v1.21, provide similar functionality.

@sftim
Copy link
Contributor

sftim commented Oct 18, 2022

@jonathon2nd we could perhaps stress that “similar” is not “equivalent”. This enhancement issue specifically tracks Topology Aware Hints.

You could raise an issue against k/website if you'd like to work on improving the explanation, or want to encourage other contributors to do so.

jonathon2nd added a commit to jonathon2nd/website that referenced this issue Oct 18, 2022
During investigation of Topology Aware Hints, documentation is very confusing.

States that it is similar, but only provides zone level topology management. Regional based topology is stated as out of scope: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/2433-topology-aware-hints/README.md#non-goals, but there is no reference at all to node level topology management. 

Proposing documentation change as suggested here: kubernetes/enhancements#2433 (comment)
@robscott
Copy link
Member Author

robscott commented Oct 19, 2022

@jonathon2nd Do you mind sharing your use cases for same node routing on #3293?

@mickeyboxell
Copy link

mickeyboxell commented Oct 20, 2022

@robscott Are additional docs required for this KEP? If so, will there be a new PR for k/website?

@Atharva-Shinde
Copy link

Atharva-Shinde commented Oct 31, 2022

Hey @robscott 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to this enhancement are linked in the issue description above(for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

As always, we are here to help should questions come up.
Thanks :)

@mickeyboxell
Copy link

mickeyboxell commented Nov 2, 2022

Hi @robscott 👋 This enhancement is marked as Needs Docs for 1.26 release. Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time. It must be created by November 9. For more information, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

@robscott
Copy link
Member Author

robscott commented Nov 3, 2022

Hey @Atharva-Shinde and @mickeyboxell, we are working on some incremental updates for this KEP in the 1.26 cycle, but the required doc updates should be minimal. Unfortunately we don't have sufficient capacity to graduate to GA in this cycle. The first PR related to this KEP is kubernetes/kubernetes#113556, I think we'll have at least one more PR to k/k in this cycle + one small k/website PR.

@Atharva-Shinde
Copy link

Atharva-Shinde commented Nov 7, 2022

Hey @robscott 👋, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow.
Looks like we would at least need to get the code PR: kubernetes/kubernetes#113556 merged before the code-freeze :)

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Nov 9, 2022
@robscott
Copy link
Member Author

robscott commented Nov 9, 2022

@rhockenbury sorry for the confusion here, the only PR we got into this release was kubernetes/kubernetes#113544, which ended up being a superset of the PR I'd mentioned earlier. I'll work on a draft docs PR, but I don't think we need much since the change is pretty tiny in this cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
SIG-Network KEPs
Beta gated (merged)
Development

No branches or pull requests