Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A single scoring plugin for node resources #2458

Closed
4 tasks done
ahg-g opened this issue Feb 8, 2021 · 21 comments
Closed
4 tasks done

A single scoring plugin for node resources #2458

ahg-g opened this issue Feb 8, 2021 · 21 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@ahg-g
Copy link
Member

ahg-g commented Feb 8, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 8, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Feb 8, 2021

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2021
@annajung annajung added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Feb 9, 2021
@annajung annajung added this to the v1.21 milestone Feb 9, 2021
@annajung
Copy link
Member

annajung commented Feb 9, 2021

With PR #2461 merged, this enhancement meets all required criteria for the enhancements freeze 👍

@JamesLaverack
Copy link
Member

JamesLaverack commented Feb 19, 2021

Hi @ahg-g,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@JamesLaverack
Copy link
Member

JamesLaverack commented Mar 2, 2021

Hi @ahg-g,

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@JamesLaverack
Copy link
Member

JamesLaverack commented Mar 6, 2021

Hi @ahg-g,

A friendly reminder that Code freeze is 3 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@ahg-g
Copy link
Member Author

ahg-g commented Mar 8, 2021

/milestone v1.22

This enhancement will not make it.

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 Mar 8, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 14, 2021

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone May 14, 2021
@ahg-g
Copy link
Member Author

ahg-g commented May 14, 2021

@JamesLaverack sorry, I missed to add this to the spreadsheet, I thought it was already there. The KEP is already merged and doesn't need updating. Can we add it back to v1.22?

@JamesLaverack
Copy link
Member

JamesLaverack commented May 14, 2021

Hey @ahg-g. As enhancements freeze has passed we can't add it in directly at this point. But if the KEP is fully up to date already then I'd highly suggest filing an exception to get it added in.

@ahg-g
Copy link
Member Author

ahg-g commented May 14, 2021

Hey @ahg-g. As enhancements freeze has passed we can't add it in directly at this point. But if the KEP is fully up to date already then I'd highly suggest filing an exception to get it added in.

Thanks, I just sent a request for the exception.

@JamesLaverack
Copy link
Member

JamesLaverack commented May 18, 2021

Hi @ahg-g, as per the discussion on the SIG Release mailing list, this enhancement's exception request has been approved.

With #2741 merged your enhancement is in a good state for 1.22. I have added it to the tracking sheet.

As a general comment, should the metrics key in your kep.yaml be TBD? I'm aware in your PRR questionnaire you don't have any metrics (and the kep.yaml file was approved at PPR like that, so I don't consider it blocking). But it'd be nice to neaten it out.

@JamesLaverack JamesLaverack added this to the v1.22 milestone May 18, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 18, 2021
@carlisia
Copy link
Member

carlisia commented May 19, 2021

Hello @ahg-g 👋, 1.22 Docs Shadow here.
This enhancement is marked as ‘Needs Docs’ for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙏

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Jul 2, 2021

Hi @ahg-g,
Just a reminder that we are one week away from the code freeze(July 8th, 2021), and with the merged PR, this issue is on track for the 1.22 release 🎉

Also, the Doc Placeholder PR deadline is on July 9th, 2021.

P.S. please let us know if there any k/k PRs need to be tracked for this one. Thank you!

@ahg-g
Copy link
Member Author

ahg-g commented Jul 2, 2021

Thanks, implementation is merged. I will send the docs PR soon.

@PI-Victor
Copy link
Member

PI-Victor commented Jul 6, 2021

Hello @ahg-g 👋, 1.22 Docs Shadow here.
This enhancement is marked as ‘Needs Docs’ for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙏

@ahg-g Friendly reminder about the upcoming docs placeholder PR deadline on Fri July 9, 11:59 PM PDT.

@ahg-g
Copy link
Member Author

ahg-g commented Jul 6, 2021

Updating the docs for this feature is dependent on updating the docs for scheduler's v1beta2 CC: kubernetes/kubernetes#95446

@PI-Victor
Copy link
Member

PI-Victor commented Jul 9, 2021

@ahg-g Today is docs placeholder deadline, please submit a placeholder PR by the end of the day, today!
You can open a simple placeholder for now and rebase later on the work from the PR it's depending on

@ahg-g
Copy link
Member Author

ahg-g commented Jul 10, 2021

@ahg-g
Copy link
Member Author

ahg-g commented Jul 27, 2021

all required PRs and docs merged.

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Nov 18, 2021

This will graduate with component config to GA.

@ahg-g ahg-g closed this as completed Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

9 participants