New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure secret pulled images #2535
Comments
Thx @adisky |
/stage stable Note: Since this is a bugfix Mike would like to target graduation directly to stable. |
Hey @mikebrow, 1.22 Enhancements Lead here.
@ehashman That should be fine so long as SIG Node are happy with that. (cc @dchen1107 @derekwaynecarr) I'm aware there's an open PR for your KEP open, but I'd just like to highlight a few things. By enhancements freeze (23:59:59 PST on Thursday 13th May) we require the following:
|
exception was filed last week.. no response yet. KEP updated to latest format and to resolve review questions (mainly added feature gate and switch to alpha vs going directly to GA. Code PR needs final reviews to go over the added feature gate. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hi @adisky! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:
Looks like for this one, we would need the following:
Also, could we please add some more information in the
Thank you! |
cc @mikebrow |
@adisky @Priyankasaggu11929 I updated the KEP adding a description for the test plan and links.. and updated the KEP's alpha target from 1.22 to 1.23. |
Thank you so much for adding the changes, @mikebrow. Just to confirm once:
Could you please confirm this part. Thanks once again. :) |
Yes, it is right to change the stage to alpha.
Forgot to hit the save button on those changes :-) Fixed now. Cheers, Mike |
Thanks for the changes @mikebrow :) |
Hello @mikebrow, just checking in as we approach 1.23 enhancements freeze tonight (09/09/2021, 23:59 PDT). Looks like the PR #1608 has got both Is it intended or can be removed to go ahead.? As with the PR merged, this enhancements will be ready for the 1.23 enhancements freeze tonight. Thank you! |
Just an update, the The KEP is now tracked for the kubernetes 1.23 release. Thank you so much @mikebrow. |
@mikebrow: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
/milestone v1.26 |
Hello @mikebrow Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
/label tracked/yes |
/remove-label lead-opted-in design consensus is not yet reached on this feature, and code implementation will not be worked on in 1.26. |
/label tracked/no |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/assign |
@adisky - the issue description should link to https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2535-ensure-secret-pulled-images/README.md - have you got the time to make that update? At the moment the link is to PR #1608 which is close but not quite right. |
@pacoxu do you plan to work on this for 1.28? |
Yes. The top priority for me in sig-node tasks. |
I updated kubernetes/kubernetes#114847 PR to implement the KEP.
|
Enhancement Description
IfNotPresent
image pull policyKubelet should enforce access to images after they've already been pulled to a node kubernetes#18787
k/enhancements
) update PR(s): ensure secret pulled images #1608k/k
) update PR(s): Ensure secret pulled images kubernetes#94899k/website
) update PR(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
/sig node
The text was updated successfully, but these errors were encountered: