-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subresource support to kubectl #2590
Comments
/stage alpha |
Hi @nikhita , 1.22 enhancements team here! For the enhancement to be included in the milestone, it must meet the following criteria:
In order to move forward in 1.22 we'd need to get the KEP merged as well as a production readiness review before enhancements freeze on 5/13. Let us know if there's anything we can do to help before then. Thanks!! |
Hi @salaxander, @nikhita and I are working in this together. Regarding the production readiness review, the KEP doc has a section by the same name. Does this section satisfy the required criteria? If not, can you let us know what is missing from it. |
Hi @ykakarap! - Here's the full documentation on the production readiness review process -> https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md |
#2600 merged so we should be all good now. |
Hi @nikhita 👋 1.22 Docs Shadow here. Please follow the steps detailed in the documentation to open a PR against dev-1.22 in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you! |
@chrisnegus Thanks for the heads-up! :) Will follow the steps to do it. |
Hey @salaxander the final PR will be read in a day or 2. |
Hey @salaxander, this is the corresponding PR: kubernetes/kubernetes#99556. |
Hi @ykakarap - One more check-in as we're a week away from code freeze. Any updates on if you expect kubernetes/kubernetes#99556 to merge before the deadline? Thanks! |
Hi @salaxander, I expect the PR to be merged before the deadline. SIG CLI has already reviewed the code. cc @nikhita |
Hey @ykakarap - I see the PR is approved, but there are merge conflicts at the moment. It'll need to merge before code freeze tomorrow evening to be included in 1.22. Let us know if there's anything we can do to help :) |
@salaxander thanks for offering to help :) There is still some work that needs to be done before the PR can be merged. |
@nikhita @salaxander Friendly reminder about the upcoming docs placeholder PR deadline tomorrow |
@salaxander @ritpanjw We are planning to move this enhancement to the next release. Please let me know if there is anything I need to do to note that. |
Hi @ykakarap - I'll update it in our tracking, thanks for letting me know! |
/milestone v1.23 |
Tim this enhancement is still in beta, I haven't heard from the original authors, so very likely the sig-cli will have to find new folks to push this through, but I doubt this is something we can pick up in 1.32. |
Thanks, Maciej. Totally understand. |
I don't have bandwidth to push this through. Removing myself as an assignee. @MadhavJivrajani PTAL if you can contribute here. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
How can we rally some energy behind this and get it across the finish line? It's been open for years and still beta, still lacking, and now potentially unowned? We have to do better at finishing things. We HAVE TO. Things that get stuck in perma-beta make the project look like it's amateur hour. I really don't mean to pick on anyone in particular. If anyone understands "I got busy", it's me. That said, the only "penalty" for abandoning a KEP is the threat of rollback, but that actually punishes our users rather than inventing good behavior from contributors :( Is there even a clear roadmap for what is missing to take this GA? |
Agreed.
I'll sync with the rest of the sig-cli, it seems that we don't expect any further work on this particular feature, so I'm willing to personally push this over the final hump. /label lead-opted-in |
/assign |
Hello @nikhita 👋, v1.33 Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025. This enhancement is targeting stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement for now is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
That is correct, I'm waiting for PRR approval only on that PR. |
Hi @soltysh 👋, 1.33 Enhancements team here, Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025. The current status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
All the comments has been addressed, I'm only awaiting PRR approval on the PR. |
#5079 merged a few minutes ago, so we should be all ready for release :) |
@soltysh I was under the impression that KEPs targeting stable should be marked as |
@dipesh-rawat that's a good catch, I missed that it was changed in the commit which I was building on. I've opened #5162 updating the remaining bits of that file to match the current template. |
Hello @soltysh 👋, 1.33 Enhancements team here, Now that PRs #5079 #5162 have been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is marked as (cc: @ArkaSaha30) /label tracked/yes |
Hello @nikhita @soltysh 👋, v1.33 Docs Shadow here. Does this enhancement work planned for v1.33 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
Enhancement Description
--subresource
to kubectl commands like get, patch, edit and replace commands to allow fetching and updating subresources like status, scale, etc.k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):/sig cli
/assign @nikhita @ykakarap
cc @eddiezane @soltysh @seans3 @pwittrock
The text was updated successfully, but these errors were encountered: