Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subresource support to kubectl #2590

Open
9 of 12 tasks
nikhita opened this issue Mar 31, 2021 · 78 comments
Open
9 of 12 tasks

Add subresource support to kubectl #2590

nikhita opened this issue Mar 31, 2021 · 78 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@nikhita
Copy link
Member

nikhita commented Mar 31, 2021

Enhancement Description

/sig cli
/assign @nikhita @ykakarap
cc @eddiezane @soltysh @seans3 @pwittrock

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Mar 31, 2021
@JamesLaverack
Copy link
Member

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 11, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 11, 2021
@salaxander
Copy link
Contributor

Hi @nikhita , 1.22 enhancements team here!

For the enhancement to be included in the milestone, it must meet the following criteria:

  • The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • The KEP must have a production readiness review

In order to move forward in 1.22 we'd need to get the KEP merged as well as a production readiness review before enhancements freeze on 5/13. Let us know if there's anything we can do to help before then.

Thanks!!

@ykakarap
Copy link

Hi @salaxander, @nikhita and I are working in this together.
Thanks for the heads-up on the pending items for the KEP :).

Regarding the production readiness review, the KEP doc has a section by the same name. Does this section satisfy the required criteria? If not, can you let us know what is missing from it.
Thanks!

@salaxander
Copy link
Contributor

Hi @ykakarap! - Here's the full documentation on the production readiness review process -> https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md

@soltysh
Copy link
Contributor

soltysh commented May 13, 2021

#2600 merged so we should be all good now.

@chrisnegus
Copy link

Hi @nikhita 👋 1.22 Docs Shadow here.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@ykakarap
Copy link

@chrisnegus Thanks for the heads-up! :)

Will follow the steps to do it.

@salaxander
Copy link
Contributor

Hi @nikhita and @ykakarap - Just checking in as we're about 2 weeks away from 1.22 code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!!

@ykakarap
Copy link

Hey @salaxander the final PR will be read in a day or 2.

@ykakarap
Copy link

Hey @salaxander, this is the corresponding PR: kubernetes/kubernetes#99556.

@salaxander
Copy link
Contributor

Hi @ykakarap - One more check-in as we're a week away from code freeze. Any updates on if you expect kubernetes/kubernetes#99556 to merge before the deadline?

Thanks!

@ykakarap
Copy link

ykakarap commented Jul 2, 2021

Hi @salaxander, I expect the PR to be merged before the deadline. SIG CLI has already reviewed the code.

cc @nikhita

@salaxander
Copy link
Contributor

Hey @ykakarap - I see the PR is approved, but there are merge conflicts at the moment. It'll need to merge before code freeze tomorrow evening to be included in 1.22. Let us know if there's anything we can do to help :)

@ykakarap
Copy link

ykakarap commented Jul 8, 2021

@salaxander thanks for offering to help :)

There is still some work that needs to be done before the PR can be merged.
I will drop a message here tomorrow to update the status of the PR.

@ritpanjw
Copy link

ritpanjw commented Jul 8, 2021

Hi @nikhita 👋 1.22 Docs Shadow here.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@nikhita @salaxander Friendly reminder about the upcoming docs placeholder PR deadline tomorrow
on Fri July 9, 11:59 PM PDT.

@ykakarap
Copy link

ykakarap commented Jul 8, 2021

@salaxander @ritpanjw We are planning to move this enhancement to the next release. Please let me know if there is anything I need to do to note that.

@salaxander
Copy link
Contributor

Hi @ykakarap - I'll update it in our tracking, thanks for letting me know!

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@soltysh
Copy link
Contributor

soltysh commented Sep 2, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Sep 2, 2021
@salaxander salaxander removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 2, 2021
@thockin thockin moved this to Incomplete in KEPs I am tracking Sep 10, 2024
@soltysh
Copy link
Contributor

soltysh commented Oct 1, 2024

I saw today that edit --subresource scale still is notr implemented. Do we know if it is on purpose or just an accident of impl?

Tim this enhancement is still in beta, I haven't heard from the original authors, so very likely the sig-cli will have to find new folks to push this through, but I doubt this is something we can pick up in 1.32.

@thockin
Copy link
Member

thockin commented Oct 4, 2024

Thanks, Maciej. Totally understand.

@nikhita
Copy link
Member Author

nikhita commented Oct 7, 2024

I don't have bandwidth to push this through. Removing myself as an assignee. @MadhavJivrajani PTAL if you can contribute here.

@nikhita nikhita removed their assignment Oct 7, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2025
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2025
@thockin
Copy link
Member

thockin commented Jan 6, 2025

How can we rally some energy behind this and get it across the finish line? It's been open for years and still beta, still lacking, and now potentially unowned?

We have to do better at finishing things. We HAVE TO. Things that get stuck in perma-beta make the project look like it's amateur hour. I really don't mean to pick on anyone in particular. If anyone understands "I got busy", it's me. That said, the only "penalty" for abandoning a KEP is the threat of rollback, but that actually punishes our users rather than inventing good behavior from contributors :(

Is there even a clear roadmap for what is missing to take this GA?

@soltysh
Copy link
Contributor

soltysh commented Jan 20, 2025

We have to do better at finishing things. We HAVE TO. Things that get stuck in perma-beta make the project look like it's amateur hour. I really don't mean to pick on anyone in particular. If anyone understands "I got busy", it's me. That said, the only "penalty" for abandoning a KEP is the threat of rollback, but that actually punishes our users rather than inventing good behavior from contributors :(

Agreed.

Is there even a clear roadmap for what is missing to take this GA?

I'll sync with the rest of the sig-cli, it seems that we don't expect any further work on this particular feature, so I'm willing to personally push this over the final hump.

/label lead-opted-in
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 20, 2025
@soltysh
Copy link
Contributor

soltysh commented Jan 20, 2025

/assign

@ArkaSaha30
Copy link
Member

ArkaSaha30 commented Feb 5, 2025

Hello @nikhita 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage stable for v1.33 (correct me, if otherwise)
/stage stable

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • The PR addresses all the missing requirements for enhancement tracking which is yet to be merged.

The status of this enhancement for now is marked as At risk for enhancements freeze. Once the PR is merged we can starting tracking it. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@ArkaSaha30 ArkaSaha30 moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 5, 2025
@soltysh
Copy link
Contributor

soltysh commented Feb 6, 2025

  • The PR addresses all the missing requirements for enhancement tracking which is yet to be merged.

That is correct, I'm waiting for PRR approval only on that PR.

@dipesh-rawat
Copy link
Member

Hi @soltysh 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #2590 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@soltysh
Copy link
Contributor

soltysh commented Feb 11, 2025

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #2590 (comment) that still need to be completed.

All the comments has been addressed, I'm only awaiting PRR approval on the PR.

@soltysh
Copy link
Contributor

soltysh commented Feb 11, 2025

#5079 merged a few minutes ago, so we should be all ready for release :)

@dipesh-rawat
Copy link
Member

@soltysh I was under the impression that KEPs targeting stable should be marked as implemented (in kep.yaml) once the code PRs are merged and feature gates are removed. For this one, we've already marked it as implemented, has the code changes for this already been merged. Apologies for any confusion on my side!

@soltysh
Copy link
Contributor

soltysh commented Feb 11, 2025

@dipesh-rawat that's a good catch, I missed that it was changed in the commit which I was building on. I've opened #5162 updating the remaining bits of that file to match the current template.

@dipesh-rawat
Copy link
Member

Hello @soltysh 👋, 1.33 Enhancements team here,

Now that PRs #5079 #5162 have been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

(cc: @ArkaSaha30)

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 12, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 12, 2025
@Urvashi0109
Copy link

Hello @nikhita @soltysh 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked
Status: Removed from Milestone
Status: Tracked for enhancements freeze
Status: Needs Triage
Development

No branches or pull requests