Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subresource support to kubectl #2590

Open
9 of 12 tasks
nikhita opened this issue Mar 31, 2021 · 58 comments
Open
9 of 12 tasks

Add subresource support to kubectl #2590

nikhita opened this issue Mar 31, 2021 · 58 comments
Assignees
Labels
sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@nikhita
Copy link
Member

nikhita commented Mar 31, 2021

Enhancement Description

/sig cli
/assign @nikhita @ykakarap
cc @eddiezane @soltysh @seans3 @pwittrock

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Mar 31, 2021
@JamesLaverack
Copy link
Member

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 11, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 11, 2021
@salaxander
Copy link
Contributor

Hi @nikhita , 1.22 enhancements team here!

For the enhancement to be included in the milestone, it must meet the following criteria:

  • The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • The KEP must have a production readiness review

In order to move forward in 1.22 we'd need to get the KEP merged as well as a production readiness review before enhancements freeze on 5/13. Let us know if there's anything we can do to help before then.

Thanks!!

@ykakarap
Copy link
Contributor

Hi @salaxander, @nikhita and I are working in this together.
Thanks for the heads-up on the pending items for the KEP :).

Regarding the production readiness review, the KEP doc has a section by the same name. Does this section satisfy the required criteria? If not, can you let us know what is missing from it.
Thanks!

@salaxander
Copy link
Contributor

Hi @ykakarap! - Here's the full documentation on the production readiness review process -> https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md

@soltysh
Copy link
Contributor

soltysh commented May 13, 2021

#2600 merged so we should be all good now.

@chrisnegus
Copy link

Hi @nikhita 👋 1.22 Docs Shadow here.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@ykakarap
Copy link
Contributor

@chrisnegus Thanks for the heads-up! :)

Will follow the steps to do it.

@salaxander
Copy link
Contributor

Hi @nikhita and @ykakarap - Just checking in as we're about 2 weeks away from 1.22 code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!!

@ykakarap
Copy link
Contributor

Hey @salaxander the final PR will be read in a day or 2.

@ykakarap
Copy link
Contributor

Hey @salaxander, this is the corresponding PR: kubernetes/kubernetes#99556.

@salaxander
Copy link
Contributor

Hi @ykakarap - One more check-in as we're a week away from code freeze. Any updates on if you expect kubernetes/kubernetes#99556 to merge before the deadline?

Thanks!

@ykakarap
Copy link
Contributor

ykakarap commented Jul 2, 2021

Hi @salaxander, I expect the PR to be merged before the deadline. SIG CLI has already reviewed the code.

cc @nikhita

@salaxander
Copy link
Contributor

Hey @ykakarap - I see the PR is approved, but there are merge conflicts at the moment. It'll need to merge before code freeze tomorrow evening to be included in 1.22. Let us know if there's anything we can do to help :)

@ykakarap
Copy link
Contributor

ykakarap commented Jul 8, 2021

@salaxander thanks for offering to help :)

There is still some work that needs to be done before the PR can be merged.
I will drop a message here tomorrow to update the status of the PR.

@ritpanjw
Copy link

ritpanjw commented Jul 8, 2021

Hi @nikhita 👋 1.22 Docs Shadow here.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@nikhita @salaxander Friendly reminder about the upcoming docs placeholder PR deadline tomorrow
on Fri July 9, 11:59 PM PDT.

@ykakarap
Copy link
Contributor

ykakarap commented Jul 8, 2021

@salaxander @ritpanjw We are planning to move this enhancement to the next release. Please let me know if there is anything I need to do to note that.

@salaxander
Copy link
Contributor

Hi @ykakarap - I'll update it in our tracking, thanks for letting me know!

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@soltysh
Copy link
Contributor

soltysh commented Sep 2, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Sep 2, 2021
@salaxander salaxander removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 2, 2021
@marosset marosset added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 7, 2023
@nikhita
Copy link
Member Author

nikhita commented Feb 8, 2023

@thockin ah, good catch!

It looks like edit was deliberately written to not support scale:

https://github.com/kubernetes/kubernetes/blob/b7ad17978eaba508c560f81bab2fb9d0b256e469/staging/src/k8s.io/kubectl/pkg/cmd/util/editor/editoptions.go#L57

To be honest, I can't remember why we decided to do this but I'll follow up on this to either: 1) add support or 2) document this behavior.

scale is supported for get, patch and replace commands though!

@LukeMwila
Copy link

Hi @MadhavJivrajani @nikhita, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@shatoboar
Copy link

Hi @nikhita 👋,
Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.
Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Please let me know what PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@MadhavJivrajani
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2024
@soltysh
Copy link
Contributor

soltysh commented Feb 5, 2024

/label lead-opted-in
/stage stable
/milestone v1.30

@k8s-ci-robot k8s-ci-robot removed the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.27, v1.30 Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status lead-opted-in Denotes that an issue has been opted in to a release labels Feb 5, 2024
@mickeyboxell
Copy link

Hello @nikhita 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on [02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca):.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

The only thing left to do is to merge: #4468. Please let me know when you've done so.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@soltysh
Copy link
Contributor

soltysh commented Feb 8, 2024

@mickeyboxell based on slack discussion with @MadhavJivrajani we'll taking this out from 1.30 cycle, we'll push this over to 1.31

/remove-label lead-opted-in
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Feb 8, 2024
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Feb 8, 2024
@salehsedghpour
Copy link
Contributor

/milestone clear

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2024
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked
Status: Removed from Milestone
Status: Needs Triage
Development

No branches or pull requests