Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subresource support to kubectl #2590

Open
4 tasks done
nikhita opened this issue Mar 31, 2021 · 35 comments
Open
4 tasks done

Add subresource support to kubectl #2590

nikhita opened this issue Mar 31, 2021 · 35 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@nikhita
Copy link
Member

nikhita commented Mar 31, 2021

Enhancement Description

/sig cli
/assign @nikhita @ykakarap
cc @eddiezane @soltysh @seans3 @pwittrock

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Mar 31, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 11, 2021

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 11, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 11, 2021
@salaxander
Copy link

salaxander commented May 11, 2021

Hi @nikhita , 1.22 enhancements team here!

For the enhancement to be included in the milestone, it must meet the following criteria:

  • The KEP must be merged in an implementable state
  • [DONE] The KEP must have test plans
  • [DONE] The KEP must have graduation criteria
  • The KEP must have a production readiness review

In order to move forward in 1.22 we'd need to get the KEP merged as well as a production readiness review before enhancements freeze on 5/13. Let us know if there's anything we can do to help before then.

Thanks!!

@ykakarap
Copy link
Contributor

ykakarap commented May 11, 2021

Hi @salaxander, @nikhita and I are working in this together.
Thanks for the heads-up on the pending items for the KEP :).

Regarding the production readiness review, the KEP doc has a section by the same name. Does this section satisfy the required criteria? If not, can you let us know what is missing from it.
Thanks!

@salaxander
Copy link

salaxander commented May 11, 2021

Hi @ykakarap! - Here's the full documentation on the production readiness review process -> https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md

@soltysh
Copy link
Contributor

soltysh commented May 13, 2021

#2600 merged so we should be all good now.

@chrisnegus
Copy link

chrisnegus commented May 19, 2021

Hi @nikhita 👋 1.22 Docs Shadow here.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@ykakarap
Copy link
Contributor

ykakarap commented May 20, 2021

@chrisnegus Thanks for the heads-up! :)

Will follow the steps to do it.

@salaxander
Copy link

salaxander commented Jun 23, 2021

Hi @nikhita and @ykakarap - Just checking in as we're about 2 weeks away from 1.22 code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!!

@ykakarap
Copy link
Contributor

ykakarap commented Jun 23, 2021

Hey @salaxander the final PR will be read in a day or 2.

@ykakarap
Copy link
Contributor

ykakarap commented Jun 23, 2021

Hey @salaxander, this is the corresponding PR: kubernetes/kubernetes#99556.

@salaxander
Copy link

salaxander commented Jul 2, 2021

Hi @ykakarap - One more check-in as we're a week away from code freeze. Any updates on if you expect kubernetes/kubernetes#99556 to merge before the deadline?

Thanks!

@ykakarap
Copy link
Contributor

ykakarap commented Jul 2, 2021

Hi @salaxander, I expect the PR to be merged before the deadline. SIG CLI has already reviewed the code.

cc @nikhita

@salaxander
Copy link

salaxander commented Jul 8, 2021

Hey @ykakarap - I see the PR is approved, but there are merge conflicts at the moment. It'll need to merge before code freeze tomorrow evening to be included in 1.22. Let us know if there's anything we can do to help :)

@ykakarap
Copy link
Contributor

ykakarap commented Jul 8, 2021

@salaxander thanks for offering to help :)

There is still some work that needs to be done before the PR can be merged.
I will drop a message here tomorrow to update the status of the PR.

@ritpanjw
Copy link

ritpanjw commented Jul 8, 2021

Hi @nikhita 👋 1.22 Docs Shadow here.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@nikhita @salaxander Friendly reminder about the upcoming docs placeholder PR deadline tomorrow
on Fri July 9, 11:59 PM PDT.

@ykakarap
Copy link
Contributor

ykakarap commented Jul 8, 2021

@salaxander @ritpanjw We are planning to move this enhancement to the next release. Please let me know if there is anything I need to do to note that.

@salaxander
Copy link

salaxander commented Jul 8, 2021

Hi @ykakarap - I'll update it in our tracking, thanks for letting me know!

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@soltysh
Copy link
Contributor

soltysh commented Sep 2, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Sep 2, 2021
@salaxander salaxander removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 2, 2021
@salaxander
Copy link

salaxander commented Nov 17, 2021

Hi, 1.23 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

  • All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Nov 17, 2021
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 9, 2022
@soltysh
Copy link
Contributor

soltysh commented Jan 19, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 19, 2022
@nikhita
Copy link
Member Author

nikhita commented Jan 20, 2022

/unassign @ykakarap
@ykakarap won't have the bandwidth to work on this right now, but will help on the sidelines!

/assign @MadhavJivrajani

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Mar 26, 2022
@chrisnegus
Copy link

chrisnegus commented Mar 28, 2022

Hi @MadhavJivrajani and @nikhita 1.24 Docs shadow here.
This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Note also that the date for having the docs ready for review is coming up soon as well: April 5, 2022.

@nikhita
Copy link
Member Author

nikhita commented Mar 29, 2022

This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

@chrisnegus placeholder PR created - kubernetes/website#32604

@chrisnegus
Copy link

chrisnegus commented Mar 31, 2022

Thanks @nikhita !

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 8, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@nikhita
Copy link
Member Author

nikhita commented Aug 9, 2022

/remove-lifecycle stale

We've had pretty good feedback for this feature. We'll try to move this to beta in 1.26.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2022
@soltysh
Copy link
Contributor

soltysh commented Aug 9, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 7, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2022
@koct9i
Copy link

koct9i commented Nov 11, 2022

Could be nice to add note here: https://kubernetes.io/docs/tasks/administer-cluster/extended-resource-node/

Advertising extended-resources for node requires patching its status subresource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests