Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing NodeIPAM to support multiple ClusterCIDRs #2593

Open
5 of 7 tasks
rahulkjoshi opened this issue Apr 1, 2021 · 44 comments
Open
5 of 7 tasks

Enhancing NodeIPAM to support multiple ClusterCIDRs #2593

rahulkjoshi opened this issue Apr 1, 2021 · 44 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@rahulkjoshi
Copy link
Contributor

rahulkjoshi commented Apr 1, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 1, 2021
@rahulkjoshi
Copy link
Contributor Author

rahulkjoshi commented Apr 1, 2021

/sig network

@dcbw
Copy link
Member

dcbw commented Jun 10, 2021

[sig-network 2021-06-10] Waiting for SIG Network to decide whether to do this as a built-in or a CRD. Tim wants to see if we can define the type here as a CRD and make the controller built-in first. If we can't figure this out in the next few weeks, we'll just try to make it a built-in.

@wojtek-t
Copy link
Member

wojtek-t commented Sep 6, 2021

@rahulkjoshi - to target 1.23, you need PRR approved By Thursday - feel free to assign to me once you open a PR

@salaxander
Copy link

salaxander commented Sep 7, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 7, 2021
@salaxander
Copy link

salaxander commented Sep 7, 2021

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 7, 2021
@salaxander salaxander added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 7, 2021
@salaxander
Copy link

salaxander commented Sep 7, 2021

Hi @rahulkjoshi! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09. Here's where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

I see there's an open PR that will complete those last 2 items, so once that merges we're all good to go!

Thanks!

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Sep 9, 2021

Hi @rahulkjoshi, 1.23 Enhancements Shadow here 👋🏽
This issue is currently marked as atRisk and I am following up as we are approaching the enhancements freeze deadline at 23:59:59 PDT on Thursday, September 9th.

Looks like the merged KEP number doesn't match the enhancements issue #2593. It is currently pointing to the PR #. Could you please update that?

@rahulkjoshi
Copy link
Contributor Author

rahulkjoshi commented Sep 9, 2021

@supriya-premkumar @salaxander please take a look and let me know if this PR needs any other changes.

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Sep 9, 2021

Thank you @rahulkjoshi. Looks like this enhancement is all set for the freeze party 🎉
I will update the tracking sheet.

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Nov 9, 2021

Hi @rahulkjoshi👋🏽 1.23 Enhancements Shadow here
Just checking on the PR status for this issue as we are approaching code freeze deadline on Tuesday, November 16 at 6:00 pm PST

I see that the linked PRs are merged. Are there any other associated PRs for this issue?
Also, please update the respective PRs in the description

Marking this issue as tracked. Please let me know if there are any open PRs.

@rahulkjoshi
Copy link
Contributor Author

rahulkjoshi commented Nov 10, 2021

I think the code will not be merged before the 1.23 deadline. We'll probably merge into 1.24

@sarveshr7

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Nov 17, 2021

@rahulkjoshi Are there any open PRs? If yes, Could you please link them in the description?
Marking this issue as atRisk for now

@rahulkjoshi
Copy link
Contributor Author

rahulkjoshi commented Nov 17, 2021

To my knowledge, there aren't any open PRs. I'll switch this to be targeting alpha for 1.24 since it seems we're missing the deadline.

@reylejano
Copy link
Member

reylejano commented Nov 17, 2021

Thank you @rahulkjoshi for confirming that this enhancement will target 1.24
/milestone v1.24

@marosset
Copy link
Contributor

marosset commented Aug 1, 2022

Hi @rahulkjoshi 👋

This is a friendly reminder that the v1.25 code freeze is at 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

I see the following PRs related to this enhancement still open

Hopefully they can get merged before the code-freeze deadline.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 3, 2022

Hello 👋, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 3, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 3, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 5, 2022
@Priyankasaggu11929 Priyankasaggu11929 added this to the v1.25 milestone Aug 5, 2022
@jasonbraganza
Copy link
Member

jasonbraganza commented Aug 8, 2022

Hello @rahulkjoshi 👋🏿

PR kubernetes/kubernetes#109090 is now merged and this issue is marked as tracked

Thank you!

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@thockin thockin modified the milestones: v1.25, v1.26 Sep 29, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Candidate for Alpha in 1.26

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 29, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 30, 2022

@thockin - This enhancement is already in alpha. Would it be beta for v1.26?

/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 30, 2022
@marosset
Copy link
Contributor

marosset commented Oct 3, 2022

@@rahulkjoshi / @thockin - Can one of you confirm the status of this enhancement?
It looks like the KEP and implementation for alpha merged in v1.25. Is there more work for needed for an alpha release here?
I also don't see any PRs trying to target a beta release.
Thanks!

@thockin thockin removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 5, 2022
@thockin
Copy link
Member

thockin commented Oct 5, 2022

Pushing to 1.27

@thockin thockin moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to Alpha gated (code is merged) in SIG-Network KEPs Oct 5, 2022
@thockin thockin modified the milestones: v1.26, v1.27 Oct 5, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 6, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 6, 2022

@rhockenbury: Those labels are not set on the issue: lead-opted-in

In response to this:

/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
SIG-Network KEPs
Alpha gated (code is merged)
Development

No branches or pull requests