Always Honor PersistentVolume Reclaim Policy

[xing-yang]

Enhancement Description

• One-line enhancement description (can be used as a release note): PersistentVolume reclaim policy should always be honored
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2644-honor-pv-reclaim-policy
• Discussion Link: volume leaks when PVC is deleted when associated PV is in the terminating state kubernetes-csi/external-provisioner#546
• Primary contact (assignee): @xing-yang @deepakkinni
• Responsible SIGs: SIG-Storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.29
  • Stable release target (x.y): 1.30
• Alpha
  • KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2644-honor-pv-reclaim-policy
  • Code (k/k) update PR(s):
  • Docs (k/website) update(s): PR submitted

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[xing-yang]

/sig storage

[JamesLaverack]

/milestone v1.22

[gracenng]

Hi @xing-yang, 1.22 Enhancements Shadow here.

The KEP looks all good, however, the status of the KEP on Enhancement track sheet will be at risk until the KEP is merged into master.

Thanks!

[gracenng]

Hi @xing-yang 👋 1.22 Enhancements shadow here.
To help SIG's be aware of their workload, I just wanted to check to see if SIG-Storage will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

[JamesLaverack]

Hi @deepakkinni, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[xing-yang]

KEP is here but not merged yet: #2680

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[xing-yang]

/milestone v1.23

[lauralorenz]

Hi @xing-yang, @deepakkinni! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09.

If I understand correctly, you are targeting alpha stage in release 1.23.

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable (filled out in PR, not merged)
• KEP has a test plan section filled out. (filled out in PR, not merged)
• KEP has up to date graduation criteria. (filled out in PR, not merged)
• KEP has a production readiness review that has been completed and merged into k/enhancements. (filled out in PR, not merged)

Starting with 1.23, we have implemented a soft freeze on production readiness reviews beginning tomorrow, Thursday 09/02. It looks like you already have the questionnaire filled out in your PR and have a PRR reviewer associated, so you are on track for tomorrow's soft freeze!

Thanks!

[ramrodo]

Hi @xing-yang, @deepakkinni 👋 1.23 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[xing-yang]

Hi @ramrodo,
We looked at this again and decided that this does not need a doc change. Can you please help remove "Need Docs" from the feature tracking sheet? Thanks!

[xing-yang]

Also the required in-tree PR for this KEP is merged: kubernetes/kubernetes#105773
We are on-track for 1.23.

[lauralorenz]

Hi @xing-yang, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

• all PRs to the Kubernetes repo related to your enhancement are fully merged by the code freeze deadline (It looks like you've already got PV controller changes to support PV Deletion protection finalizer kubernetes#105773 merged. 🎉)
• have a documentation placeholder PR open by Thursday, November 18. (Based on the comment above Always Honor PersistentVolume Reclaim Policy #2644 (comment) it looks like you are expecting not to open one but will let @ramrodo speak to that from their side.)

Thanks!!

[ruheenaansari34]

Hello @xing-yang @deepakkinni 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.26
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Update KEP's README.md to include test plan details as per the latest template
• Update latest-milestone and milestone details on kep.yml
• Create a PR to meet the above requirements for Enhancements freeze and get it merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[ruheenaansari34]

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and README and get the PR merged.

[deepakkinni]

Hello @xing-yang @deepakkinni 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

We have decided to not move the KEP to beta in 1.26. Instead, we are going for KEP update(for additional changes) and target the beta next release.

[rhockenbury]

Thanks for the update.

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[xing-yang]

/remove-lifecycle rotten

[xing-yang]

/milestone 1.29

[k8s-ci-robot]

@xing-yang: The provided milestone is not valid for this repository. Milestones in this repository: [v1.25, v1.27, v1.28, v1.29, v1.30, v1.31]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

/milestone v1.29