Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Honor PersistentVolume Reclaim Policy #2644

Open
3 of 4 tasks
xing-yang opened this issue Apr 22, 2021 · 30 comments
Open
3 of 4 tasks

Always Honor PersistentVolume Reclaim Policy #2644

xing-yang opened this issue Apr 22, 2021 · 30 comments
Assignees
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@xing-yang
Copy link
Contributor

xing-yang commented Apr 22, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 22, 2021
@xing-yang
Copy link
Contributor Author

xing-yang commented Apr 22, 2021

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 22, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented Apr 28, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021
@JamesLaverack JamesLaverack added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 28, 2021
@gracenng
Copy link
Member

gracenng commented May 10, 2021

Hi @xing-yang, 1.22 Enhancements Shadow here.

The KEP looks all good, however, the status of the KEP on Enhancement track sheet will be at risk until the KEP is merged into master.

Thanks!

@gracenng
Copy link
Member

gracenng commented May 11, 2021

Hi @xing-yang 👋 1.22 Enhancements shadow here.
To help SIG's be aware of their workload, I just wanted to check to see if SIG-Storage will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@JamesLaverack
Copy link
Member

JamesLaverack commented May 14, 2021

Hi @deepakkinni, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone May 14, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 14, 2021
@xing-yang
Copy link
Contributor Author

xing-yang commented May 14, 2021

KEP is here but not merged yet: #2680

@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 12, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 12, 2021
@xing-yang
Copy link
Contributor Author

xing-yang commented Aug 30, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2021
@xing-yang
Copy link
Contributor Author

xing-yang commented Aug 30, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 30, 2021
@salaxander salaxander added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 31, 2021
@lauralorenz
Copy link
Contributor

lauralorenz commented Sep 1, 2021

Hi @xing-yang, @deepakkinni! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09.

If I understand correctly, you are targeting alpha stage in release 1.23.

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable (filled out in PR, not merged)
  • KEP has a test plan section filled out. (filled out in PR, not merged)
  • KEP has up to date graduation criteria. (filled out in PR, not merged)
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (filled out in PR, not merged)

Starting with 1.23, we have implemented a soft freeze on production readiness reviews beginning tomorrow, Thursday 09/02. It looks like you already have the questionnaire filled out in your PR and have a PRR reviewer associated, so you are on track for tomorrow's soft freeze!

Thanks!

@ramrodo
Copy link
Member

ramrodo commented Sep 20, 2021

Hi @xing-yang, @deepakkinni 👋 1.23 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@xing-yang
Copy link
Contributor Author

xing-yang commented Nov 15, 2021

Hi @ramrodo,
We looked at this again and decided that this does not need a doc change. Can you please help remove "Need Docs" from the feature tracking sheet? Thanks!

@xing-yang
Copy link
Contributor Author

xing-yang commented Nov 15, 2021

Also the required in-tree PR for this KEP is merged: kubernetes/kubernetes#105773
We are on-track for 1.23.

@lauralorenz
Copy link
Contributor

lauralorenz commented Nov 15, 2021

Hi @xing-yang, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

Thanks!!

@xing-yang xing-yang added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 7, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 21, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2022
@xing-yang xing-yang added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 14, 2022
@xing-yang
Copy link
Contributor Author

xing-yang commented Sep 14, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2022
@xing-yang xing-yang added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lead-opted-in Denotes that an issue has been opted in to a release labels Sep 14, 2022
@xing-yang
Copy link
Contributor Author

xing-yang commented Sep 14, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 18, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 18, 2022
@rhockenbury rhockenbury added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 20, 2022
@ruheenaansari34
Copy link

ruheenaansari34 commented Sep 27, 2022

Hello @xing-yang @deepakkinni 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ruheenaansari34
Copy link

ruheenaansari34 commented Oct 4, 2022

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and README and get the PR merged.

@deepakkinni
Copy link
Member

deepakkinni commented Oct 5, 2022

Hello @xing-yang @deepakkinni 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

We have decided to not move the KEP to beta in 1.26. Instead, we are going for KEP update(for additional changes) and target the beta next release.

@rhockenbury
Copy link

rhockenbury commented Oct 5, 2022

Thanks for the update.

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests