Always Honor PersistentVolume Reclaim Policy

[xing-yang]

Enhancement Description

• One-line enhancement description (can be used as a release note): PersistentVolume reclaim policy should always be honored
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2644-honor-pv-reclaim-policy
• Discussion Link: volume leaks when PVC is deleted when associated PV is in the terminating state kubernetes-csi/external-provisioner#546
• Primary contact (assignee): @deepakkinni @xing-yang
• Responsible SIGs: SIG-Storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.31
  • Stable release target (x.y): 1.32
• Alpha
  • KEP (k/enhancements) update PR(s): Honor Persistent Volume Reclaim Policy #2680
  • Code (k/k) update PR(s): PV controller changes to support PV Deletion protection finalizer kubernetes#105773
  • Docs (k/website) update(s): PR submitted
• Beta
  • KEP (k/enhancements) update PR(s): promote KEP-2644 to beta in 1.31 #4397
  • e2e tests: add e2e test for HonorPVReclaimPolicy kubernetes#123151
  • Code (k/k) update PR(s): Promote HonorPVReclaimPolicy to beta and enable it by default kubernetes#124842
  • Docs (k/website) update(s): promote HonorPVReclaimPolicy to beta website#46794
  • Blog: Blogpost for honor PV reclaim policy fix moving to Beta website#46890
• GA
  • KEP (k/enhancements) update PR(s): KEP-2644: promote HonorPVReclaimPolicy to GA #5035
  • Code (k/k) update PR(s): promote HonorPVReclaimPolicy to GA kubernetes#129583, promote HonorPVReclaimPolicy to GA kubernetes-csi/external-provisioner#1328

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[xing-yang]

/sig storage

[JamesLaverack]

/milestone v1.22

[gracenng]

Hi @xing-yang, 1.22 Enhancements Shadow here.

The KEP looks all good, however, the status of the KEP on Enhancement track sheet will be at risk until the KEP is merged into master.

Thanks!

[gracenng]

Hi @xing-yang 👋 1.22 Enhancements shadow here.
To help SIG's be aware of their workload, I just wanted to check to see if SIG-Storage will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

[JamesLaverack]

Hi @deepakkinni, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[xing-yang]

KEP is here but not merged yet: #2680

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[xing-yang]

/milestone v1.23

[lauralorenz]

Hi @xing-yang, @deepakkinni! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09.

If I understand correctly, you are targeting alpha stage in release 1.23.

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable (filled out in PR, not merged)
• KEP has a test plan section filled out. (filled out in PR, not merged)
• KEP has up to date graduation criteria. (filled out in PR, not merged)
• KEP has a production readiness review that has been completed and merged into k/enhancements. (filled out in PR, not merged)

Starting with 1.23, we have implemented a soft freeze on production readiness reviews beginning tomorrow, Thursday 09/02. It looks like you already have the questionnaire filled out in your PR and have a PRR reviewer associated, so you are on track for tomorrow's soft freeze!

Thanks!

[ramrodo]

Hi @xing-yang, @deepakkinni 👋 1.23 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[xing-yang]

Hi @ramrodo,
We looked at this again and decided that this does not need a doc change. Can you please help remove "Need Docs" from the feature tracking sheet? Thanks!

[xing-yang]

Also the required in-tree PR for this KEP is merged: kubernetes/kubernetes#105773
We are on-track for 1.23.

[lauralorenz]

Hi @xing-yang, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

• all PRs to the Kubernetes repo related to your enhancement are fully merged by the code freeze deadline (It looks like you've already got PV controller changes to support PV Deletion protection finalizer kubernetes#105773 merged. 🎉)
• have a documentation placeholder PR open by Thursday, November 18. (Based on the comment above Always Honor PersistentVolume Reclaim Policy #2644 (comment) it looks like you are expecting not to open one but will let @ramrodo speak to that from their side.)

Thanks!!

[dipesh-rawat]

Hello @xing-yang @deepakkinni @carlory 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage stable for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.33.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

• Please ensure the KEP readme using the latest template and merge it in the k/enhancements repo. Currently, I’ve noticed the following discrepancies compared to the latest template:

  • Under the Production Readiness Review Questionnaire section, the subsections "Rollout, Upgrade, and Rollback Planning", "Dependencies", and "Troubleshooting" are missing.

  • Under the Scalability section, the question Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)? is missing.

  • Under the Test Plan section, the "Unit Test" and "Integration Test" sub-sections are missing. I’m not sure if they were intentionally excluded or missed - apologies for any confusion on my part if they were meant to be omitted.

• Also, please make sure to update the issue description with the correct stages and PRs. This will assist the release team in tracking progress more effectively.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[dipesh-rawat]

Hello @xing-yang @deepakkinni @carlory 👋, 1.33 Enhancements team here.

Now that PR #5035 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

/label tracked/yes

[Urvashi0109]

Hello @xing-yang @deepakkinni @carlory 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[aibarbetta]

Hi @xing-yang @deepakkinni @carlory 👋 -- this is Agustina (@aibarbetta) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

• This introduces some breaking change(s)
• This has significant impacts and/or implications to users
• ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[deepakkinni]

Hi @xing-yang @deepakkinni @carlory 👋 -- this is Agustina (@aibarbetta) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

* This introduces some breaking change(s)

* This has significant impacts and/or implications to users

* ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

* **02:00 UTC Wednesday, 5th March, 2025**: Feature blog PR freeze

* **Monday, 7th April, 2025**: Feature blogs ready for review

* You can find more in the [release document](https://github.com/kubernetes/sig-release/tree/master/releases/release-1.33#timeline)

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Posted a placeholder kubernetes/website#49948

[dipesh-rawat]

Hey again @xing-yang @deepakkinni @carlory 👋, 1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all the implementation(code related) PRs merged as per the issue description:

• promote HonorPVReclaimPolicy to GA kubernetes#129583
• promote HonorPVReclaimPolicy to GA kubernetes-csi/external-provisioner#1328

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

This enhancement is now marked as tracked for code freeze for the 1.33 Code Freeze!

[carlory]

@dipesh-rawat all PR are merged. The remaining task is writing a blog.

[jenshu]

Hi @deepakkinni @xing-yang 👋, 1.34 Enhancements Lead here,

Given that this KEP has graduated to stable, once all the work is completed (including removing feature gates), could you please update the KEP status in kep.yaml to implemented, and then close this issue?

Thanks!

/remove-label lead-opted-in
/remove-label tracked/yes

[carlory]

@jenshu I create a PR to update the kep.yaml. Once it is merged, we can close this issue.