Skip to content

Field status.hostIPs added for Pod #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
12 tasks done
wzshiming opened this issue May 6, 2021 · 89 comments
Closed
12 tasks done

Field status.hostIPs added for Pod #2681

wzshiming opened this issue May 6, 2021 · 89 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@wzshiming
Copy link
Member

wzshiming commented May 6, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 6, 2021
@wzshiming
Copy link
Member Author

/sig node
/sig network

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 6, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 31, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 30, 2021
@wzshiming
Copy link
Member Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 12, 2021
@thockin thockin added this to the v1.24 milestone Jan 6, 2022
@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 17, 2022
@hosseinsalahi
Copy link

hosseinsalahi commented Jan 20, 2022

Hello @wzshiming

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting beta for v1.24, is this correct?

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk. Please update the issue description up-to-date with appropriate stages as well.
Thanks!

@thockin thockin self-assigned this Jan 28, 2022
@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

The Enhancements Freeze is now in effect and this enhancement is removed from the release. Missing PRR for beta stage
Please feel free to file an exception.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Feb 4, 2022
@wojtek-t
Copy link
Member

wojtek-t commented Feb 4, 2022

@gracenng - this isn't targetted for beta, this is targetted for Alpha (so the KEP seem to be ok).

@thockin thockin added this to the v1.24 milestone Feb 16, 2022
@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 6, 2022
@gracenng gracenng removed this from the v1.24 milestone Mar 6, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2022
@wzshiming
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

I have not heard anything on this. The PR is full of conflicts - @wzshiming do you want to try to get code into 1.26?

@wzshiming
Copy link
Member Author

I have not heard anything on this. The PR is full of conflicts - @wzshiming do you want to try to get code into 1.26?

Yes, I rebased the PR, please take a look at it when you have time. Thank you.
#109616

@marosset
Copy link
Contributor

/milestone v1.26
/label lead-opted-in
(I'm doing this on behalf of @ruiwen-zhao / SIG-node)

@kannon92 kannon92 moved this from Considered for release to Tracked in SIG Node 1.32 KEPs planning Oct 3, 2024
@danwinship
Copy link
Contributor

Yeah, this doesn't really need to be tracked, and we probably don't want to update the latest-milestone, though probably we should make a point of going back through old KEPs and making sure the kep.yamls are all correct. (Clearly this should have been updated from implementable to implemented at some point...)

@aojea
Copy link
Member

aojea commented Oct 7, 2024

It seems the work remaining is to remove teh code completely

	PodHostIPs: {
		{Version: version.MustParse("1.28"), Default: false, PreRelease: featuregate.Alpha},
		{Version: version.MustParse("1.29"), Default: true, PreRelease: featuregate.Beta},
		{Version: version.MustParse("1.30"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.32
	},

any volunteers to remove the code and just close this?

@aojea aojea added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Oct 7, 2024
@aojea aojea moved this from Tracked to Implemented in SIG Node 1.32 KEPs planning Oct 7, 2024
@thockin
Copy link
Member

thockin commented Oct 7, 2024 via email

@kannon92
Copy link
Contributor

kannon92 commented Oct 7, 2024

@aojea This is already up: kubernetes/kubernetes#126752

@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

If you would be so kind, can you be sure to update the kep.yaml status to implemented so future enhancements teams do not have questions around this? Thanks!

@tjons tjons moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.32 Enhancements Tracking Oct 11, 2024
@hacktivist123
Copy link

Hello @thockin 👋 1.32 Docs Shadow here.

Does this enhancement work planned for 1.32 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@rytswd
Copy link
Member

rytswd commented Oct 16, 2024

Hi @thockin 👋 -- this is Ryota (@rytswd) from the v1.32 Communications Team!

For the v1.32 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 30th Oct 2024? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 30th Oct: Feature blog PR freeze
  • Monday, 25th Nov: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@hacktivist123
Copy link

Hello, @thockin 👋 1.32 Docs Shadow here.

This is just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs:

The deadline for this is Thursday, Oct 24 at 18:00 PDT.
Thanks! 🚀

@danwinship
Copy link
Contributor

@hacktivist123 There is no docs update needed; this KEP was already completed in 1.30, and the only work that was done in 1.32 was to remove the old feature gate

@hacktivist123
Copy link

Thanks @danwinship

@rytswd
Copy link
Member

rytswd commented Oct 29, 2024

Hi @thockin @danwinship 👋, v1.32 Communications Team here again!

From the nature of the change in v1.32 (thanks to @danwinship's clarification above), I'm assuming there will be no blog write-up planned for this change. But for the completeness of the Release tracking, please bear with me on one last reminder of the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 30th Oct. 🙏

I'll leave the same information just in case this catches anyone's eyes:

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 30th Oct: Feature blog PR freeze
  • Monday, 25th Nov: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@thockin
Copy link
Member

thockin commented Oct 31, 2024

Once 32 goes out, we can close this. Yay!

kep.yaml still indicates "implementable", though

@tjons
Copy link
Contributor

tjons commented Nov 4, 2024

Hey again @haircommander @thockin 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

@tjons tjons moved this from Tracked for enhancements freeze to At risk for code freeze in 1.32 Enhancements Tracking Nov 4, 2024
@thockin
Copy link
Member

thockin commented Nov 7, 2024

@thockin
Copy link
Member

thockin commented Nov 7, 2024

Gate has been removed. Hooray

@thockin thockin closed this as completed Nov 7, 2024
@github-project-automation github-project-automation bot moved this from Implemented to Done in SIG Node 1.32 KEPs planning Nov 7, 2024
@dipesh-rawat dipesh-rawat moved this from At risk for code freeze to Tracked for code freeze in 1.32 Enhancements Tracking Nov 8, 2024
@thockin thockin moved this from GA to Done in SIG Network KEPs Dec 13, 2024
@dipesh-rawat dipesh-rawat removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Done
Status: Net New
Status: Removed From Milestone
Status: Tracked
Status: Tracked for Code Freeze
Status: Tracked for Doc Freeze
Status: Tracked for code freeze
Status: Done
Development

No branches or pull requests