Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod Priority Based Node Graceful Shutdown #2712

Closed
4 tasks done
mrunalp opened this issue May 11, 2021 · 42 comments
Closed
4 tasks done

Pod Priority Based Node Graceful Shutdown #2712

mrunalp opened this issue May 11, 2021 · 42 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@mrunalp
Copy link
Contributor

mrunalp commented May 11, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 11, 2021
@mrunalp
Copy link
Contributor Author

mrunalp commented May 11, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2021
@ehashman
Copy link
Member

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 11, 2021
@JamesLaverack JamesLaverack added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 11, 2021
@jrsapi
Copy link

jrsapi commented May 13, 2021

Greetings @mrunalp!
1.22 Enhancement shadow checking in. After reviewing the KEP and PRR this KEP will be marked tracked. A reminder that the enhancement freeze starts 5/13 23:59:59 PST.

Thanks!

@PI-Victor
Copy link
Member

Hello @mrunalp 👋, 1.22 Docs release lead here.
This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@jrsapi
Copy link

jrsapi commented Jun 24, 2021

Greetings @mrunalp,
Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you confirm if the following k/k PR is all that is needed for the implementation of this enhancement for the 1.22 milestone?

Thanks!

@jrsapi
Copy link

jrsapi commented Jul 6, 2021

Greetings @mrunalp,
A reminder that this Thursday, July 8th is code freeze, and all PR's must be code complete and merged. This KEP is marked "At Risk" for the 1.22 milestone.

Also this Friday, July 9th is the Docs placeholder deadline and to open a PR follow the instructions above.

Thanks!

@jrsapi
Copy link

jrsapi commented Jul 8, 2021

Greetings @mrunalp,
Sending a reminder that we have just one more day to get all open PRs merged before the code freeze deadline tomorrow Thursday, July 8th at 18:00 Pacific Time.

@mrunalp
Copy link
Contributor Author

mrunalp commented Jul 8, 2021

kubernetes/kubernetes#102915 is open for the implementation.

@JamesLaverack
Copy link
Member

Hi, v1.22 Enhancements Lead here. Unfortunately this enhancement has not met the requirements for code freeze as kubernetes/kubernetes#102915 is unmerged and unapproved.

If you still wish to progress this enhancement in v1.22, then please file an exception request.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone Jul 9, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 9, 2021
@mrunalp
Copy link
Contributor Author

mrunalp commented Jul 9, 2021

We requested an exception for this.

@salaxander
Copy link
Contributor

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 31, 2021
@salaxander salaxander added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 31, 2021
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Sep 7, 2021

Hi @mrunalp! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need the following to update:

Thank you!

@mrunalp
Copy link
Contributor Author

mrunalp commented Sep 7, 2021

@Priyankasaggu11929 I have opened a PR to update the milestone for the KEP.

@Priyankasaggu11929
Copy link
Member

@mrunalp, thank you so much for the PR.

Could you please update this issue description as well with the latest Enhancement target. Would be really helpful to track the enhancement for the team. Thanks once again! :)

@Priyankasaggu11929
Copy link
Member

Thanks so much for the changes, @mrunalp. With the KEP PR merged now, this enhancement is ready for the 1.23 enhancements freeze. :)

@rhockenbury
Copy link

Let me know if there are any updates on whether this is planned for beta for v1.24.

@mrunalp
Copy link
Contributor Author

mrunalp commented Jan 27, 2022 via email

@mrunalp
Copy link
Contributor Author

mrunalp commented Jan 27, 2022

I opened a PR: #3194

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 28, 2022
@rhockenbury
Copy link

Thanks, please plan to merge #3194 before enhancements freeze at 18:00pm PT on Thursday Feb 3rd.

@rhockenbury
Copy link

I've moved this KEP to tracked for enhancement freeze. Thanks!

@PI-Victor
Copy link
Member

Hi @mrunalp 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@valaparthvi
Copy link

Hi @mrunalp 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@rhockenbury
Copy link

Hi @mrunalp

I'm checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this KEP, it looks like k/k#102915 has been merged. Are there any other PRs that you think we should be tracking that would be subject to the 1.24 code freeze?

Let me know if you have any questions.

@ehashman
Copy link
Member

That PR merged in 1.23. The PR for 1.24 is kubernetes/kubernetes#107986

@rhockenbury
Copy link

Got it. Thanks for the clarification.

@PI-Victor
Copy link
Member

hi @mrunalp, the docs PR placeholder deadline is on the 31st of March, please open a docs placeholder Pr for these changes by then, thank you!

@nate-double-u
Copy link

@mrunalp Reminder that tomorrow (April 5th) is the deadline for 1.24 Docs Ready for Review.

Please open a PR, push your docs content for this enhancement, and remove the work-in-progress label when ready for review.

We have a tight turnaround to getting docs reviewed and approved for the release, and we’re hoping to have all docs in for review by tomorrow. Thank you!

@mrunalp
Copy link
Contributor Author

mrunalp commented Apr 5, 2022

I have opened kubernetes/website#32771

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@pacoxu
Copy link
Member

pacoxu commented Aug 26, 2022

/remove-lifecycle stale
There seems to be no feedback about this feature yet.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 24, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests