Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe #2727

Open
4 tasks
bowei opened this issue May 12, 2021 · 56 comments
Open
4 tasks

Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe #2727

bowei opened this issue May 12, 2021 · 56 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@bowei
Copy link
Member

bowei commented May 12, 2021

Enhancement Description

Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 12, 2021
@bowei
Copy link
Member Author

bowei commented May 12, 2021

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2021
@bowei
Copy link
Member Author

bowei commented May 12, 2021

/assign

@bowei
Copy link
Member Author

bowei commented May 12, 2021

@PxyUp

@bowei
Copy link
Member Author

bowei commented May 12, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 12, 2021
bowei added a commit to bowei/enhancements that referenced this issue May 12, 2021
bowei added a commit to bowei/enhancements that referenced this issue May 12, 2021
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented May 12, 2021

@ehashman
Copy link
Member

ehashman commented May 13, 2021

@bowei can you start filing an exception request if you want this in 1.22? It seems very unlikely this feature will make the deadline of tomorrow given that it has not been opted in to the release, is missing PRR, etc.

@JamesLaverack
Copy link
Member

JamesLaverack commented May 13, 2021

/milestone v1.22
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 13, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 13, 2021
bowei added a commit to bowei/enhancements that referenced this issue May 13, 2021
bowei added a commit to bowei/enhancements that referenced this issue May 13, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 14, 2021

Hi @bowei, 1.22 Enhancements Lead here. We're not removing this from 1.22, but can you address John's comment about updating your kep.yaml metadata to match your KEP README?

@yuzhiquan
Copy link
Member

yuzhiquan commented May 14, 2021

/cc

@bowei
Copy link
Member Author

bowei commented May 14, 2021

Got it, updating.

@bowei
Copy link
Member Author

bowei commented May 14, 2021

@ehashman do we need an exception request?

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented May 14, 2021

@ehashman do we need an exception request?

It is in the tracking document: https://docs.google.com/spreadsheets/d/1mlui0brYypOAsgS2D13fvcs3At1uMq4i1gWfneq-jxY/edit#gid=1954476102 and was merged in time. Also @ehashman counted it in the Slack message =).

We generally not encouraging last minute KEPs so we have a proper planning and be respectful for reviewers time. I think this one is not controversial and it is great that it got merged in time.

@PxyUp
Copy link

PxyUp commented May 14, 2021

@bowei thanks for leading that, sadly i haven't time to finish my proposal. I did MR for prober long time ago may be commits will be also useful:

kubernetes/kubernetes#89832

If you need it, i will rebase and update MR

@yuzhiquan
Copy link
Member

yuzhiquan commented May 18, 2021

@bowei do you working on this now?

If not, i would like to take this from here, and base on @PxyUp work kubernetes/kubernetes#89832.

@yuzhiquan yuzhiquan removed their assignment May 18, 2021
@valaparthvi
Copy link

valaparthvi commented Mar 29, 2022

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

How do I sign up? I don't seem to have permissiosn to edit?

I am so sorry I missed out on this, @SergeyKanzhelev. Thanks, @reylejano, for clearing that up.

I see that the feature has been added to the tracking sheet, @SergeyKanzhelev. Now what we need is to add a placeholder PR for this. Can you please open one by March 30 which is our extended deadline for feature blog freeze?

Example of a feature blog PR: kubernetes/website#30538
Example of a feature blog: https://github.com/kubernetes/website/blob/main/content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Mar 30, 2022

Created the placeholder PR for grpc

@thockin thockin moved this from Alpha gated (code is merged) to Beta gated (merged) in SIG-Network KEPs Mar 31, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@thockin
Copy link
Member

thockin commented Jun 20, 2022

Just to confirm - I am NOT adding this to 1.25 sheet

@thockin thockin added this to the v1.26 milestone Aug 4, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Candidate for GA in 1.26

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 29, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 30, 2022

/label tracked/yes
/remove-label tracked/no
/stage stable

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 30, 2022
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 3, 2022

/label lead-opted-in

tracked in sig-node sheet.

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Oct 3, 2022

This feature is in beta and enabled by default. Unfortunately there is not much adoption of it yet.

I presented it on gRPC meetup and received positive feedback. [Video])(https://www.youtube.com/watch?v=-ruuY5F-rE8) and slides. However there was very little feedback from end users yet. I'd suggest to postpone the GA of the feature to 1.27 and I will keep track of the adoption.

@bowei
Copy link
Member Author

bowei commented Oct 3, 2022

Ok -- let's wait for some more feedback -- but I don't recommend waiting much longer -- there is no negative feedback per se.

@thockin thockin removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 3, 2022
@thockin thockin modified the milestones: v1.26, v1.27 Oct 3, 2022
@thockin
Copy link
Member

thockin commented Oct 3, 2022

Moving to 1.27

@rhockenbury
Copy link

rhockenbury commented Oct 3, 2022

/label tracked/no
/remove-label tracked/yes

@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 3, 2022
@dgnemo
Copy link

dgnemo commented Nov 29, 2022

@SergeyKanzhelev just wanted to share some feedback. My team loves the introduction of this feature! Unfortunately we could not fully adopt it yet because it's not supported by the terraform provider that we are using.
hashicorp/terraform-provider-kubernetes#1908

This to say that I would not worry too much about adoption for this useful feature, as that is a catch-22 with the feature being GA :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
SIG-Network KEPs
Beta gated (merged)
Development

No branches or pull requests