Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSR Duration #2784

Closed
17 tasks done
enj opened this issue Jun 15, 2021 · 20 comments
Closed
17 tasks done

CSR Duration #2784

enj opened this issue Jun 15, 2021 · 20 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Milestone

Comments

@enj
Copy link
Member

enj commented Jun 15, 2021

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 15, 2021
@enj enj self-assigned this Jun 17, 2021
@enj enj added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 17, 2021
@kubernetes kubernetes deleted a comment from k8s-ci-robot Jun 17, 2021
@enj enj added this to Needs Triage in SIG Auth via automation Jun 17, 2021
@enj enj moved this from Needs Triage to In Progress (v1.22) in SIG Auth Jun 17, 2021
@enj enj added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. labels Jun 17, 2021
@enj enj added this to the v1.22 milestone Jun 17, 2021
@enj enj changed the title [WIP] Please ignore CSR Duration Jun 17, 2021
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 17, 2021

As this is being submitted well after the enhancments freeze author has submitted an exception request:
https://groups.google.com/g/kubernetes-sig-release/c/UZUQAIfizkY/m/0g3TxofwAwAJ

removing from milestone until it is evaluated.

@kikisdeliveryservice kikisdeliveryservice removed this from the v1.22 milestone Jun 17, 2021
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 18, 2021

As per a comment here:
kubernetes/kubernetes#99412 (comment)

kubernetes/kubernetes#99412 is a bug fix (and prereq for this KEP) that will go into the 1.22 release regardless of whether or not this KEP (and other associate work) is included in the 1.22 release.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 22, 2021

The exception request to the enhancements freeze for this KEP has been approved: https://groups.google.com/g/kubernetes-sig-release/c/UZUQAIfizkY/m/PIyu2HBZBQAJ

@JamesLaverack can you please ensure the KEP is tracked?

Once the KEP is finished/merged, we can remove the holds from the implementation PRs.

@supriya-premkumar supriya-premkumar added this to the v1.22 milestone Jun 22, 2021
@supriya-premkumar supriya-premkumar added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 22, 2021
@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Jun 22, 2021

Thank you @kikisdeliveryservice! This is now being tracked.

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Jun 22, 2021

Hi @enj 👋🏽. This is Supriya, 1.22 Enhancements Shadow here.

Code Freeze is on July 8th, 2021 at EOD PST. After your KEP is approved and merged, all implementation PRs must be code complete and merged before the deadline. If PRs are not merged by code freeze, they will be removed from the 1.22 milestone.

Please keep us in the loop if anything changes. Thank you.

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Jul 2, 2021

Hi @enj, just a reminder that we are one week away from the code freeze(July 8th, 2021) and I see that the PR is yet to be merged, due to this the issue will still be marked as atRisk for 1.22 Release.

@enj
Copy link
Member Author

enj commented Jul 2, 2021

Hi @enj, just a reminder that we are one week away from the code freeze(July 8th, 2021) and I see that the PR is yet to be merged, due to this the issue will still be marked as atRisk for 1.22 Release.

@supriya-premkumar kubernetes/kubernetes#99494 is merged now.

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Jul 2, 2021

That's awesome. Thank you @enj
This is now on track for the 1.22 code freeze 🎉

@enj
Copy link
Member Author

enj commented Jul 23, 2021

All items for beta are complete.

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@enj
Copy link
Member Author

enj commented Nov 17, 2021

/remove-lifecycle stale
/milestone v1.24

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.24 Nov 17, 2021
@liggitt liggitt added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Jan 19, 2022
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 20, 2022
@gracenng
Copy link
Member

gracenng commented Jan 20, 2022

Hi @enj ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting stable for 1.24
Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release with latest-milestone: 1.24
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as `at risk
Thanks!

@enj
Copy link
Member Author

enj commented Jan 28, 2022

@gracenng I have opened #3197 to address the missing items for 1.24. Let me know if I need to do anything else.

@gracenng
Copy link
Member

gracenng commented Jan 30, 2022

The status for 1.24 Enhancementsis now tracked 🥳

@chrisnegus
Copy link

chrisnegus commented Feb 11, 2022

Hi @enj 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@katcosgrove
Copy link

katcosgrove commented Feb 24, 2022

Hey there! Comms shadow here. Would y'all like to have this included in the deprecations and removal blog for 1.24? Here's what it looked like for 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

@enj
Copy link
Member Author

enj commented Mar 7, 2022

Hey there! Comms shadow here. Would y'all like to have this included in the deprecations and removal blog for 1.24? Here's what it looked like for 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

We are not deprecating or removing anything from the CSR API with this KEP so I do not believe it needs to be included. Thanks!

@gracenng
Copy link
Member

gracenng commented Mar 16, 2022

Hi @enj 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

@katcosgrove
Copy link

katcosgrove commented Mar 21, 2022

Hey y'all! It's me again, comms shadow. We're approaching last call for feature blogs, as the freeze is Wednesday, March 23. If you would like to have a feature blog for this, please add it to the tracking sheet and reach out to me if you have any questions. Thank you!

@enj
Copy link
Member Author

enj commented Mar 23, 2022

@gracenng @chrisnegus all code, docs, etc for this KEP are complete and it is marked as implemented. I believe we can close this tracking issue 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
SIG Auth
Closed / Done
Development

No branches or pull requests