Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify Windows pods at API admission level authoritatively #2802

Closed
26 tasks done
ravisantoshgudimetla opened this issue Jun 28, 2021 · 29 comments
Closed
26 tasks done
Assignees
Labels
sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented Jun 28, 2021

Enhancement Description

Identifying Windows pods at the API admission level authoritatively is crucial to apply appropriate security constraints to the pod. We rely on kubelet to strip certain security constraints when the pod lands on the node. While this is workable solution identifying all the valid scenarios during kubelet admission time is hard and not scalable. Having the identification done during the API admission would also help the other admission controllers like PodSecurityAdmission to authoritatively apply security constraints.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 28, 2021
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Jun 28, 2021

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 28, 2021
@immuzz immuzz added this to Backlog (v 1.23) in SIG-Windows Jul 1, 2021
@salaxander
Copy link

salaxander commented Aug 31, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 31, 2021
@salaxander salaxander added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 31, 2021
@salaxander
Copy link

salaxander commented Sep 1, 2021

Hi @ravisantoshgudimetla! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date gradution criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Starting with 1.23, we have implented a soft freeze on production readiness reviews beginning on Thursday 09/02. If your enhancement needs a PRR, please make sure to try and complete it by that date!

Thanks!

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Sep 9, 2021

Hi @ravisantoshgudimetla! 1.23 Enhancements shadow here👋🏽

Just following up as we are approaching the enhancements freeze on Thursday 09/09.

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date gradution criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like this issue is all set for the Enhancement Freeze 🎉
I will update the tracking sheet accordingly.

Thank you!

@mehabhalodiya
Copy link

mehabhalodiya commented Sep 18, 2021

Hi @ravisantoshgudimetla 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@sftim
Copy link
Contributor

sftim commented Sep 29, 2021

Do we have a list of recognised operating system names / intend to have a list like that?

If so, we should aim to document what that list of names consists of. These might be borrowed from elsewhere; that's OK, and we can document where to look.

@marosset
Copy link
Contributor

marosset commented Nov 5, 2021

Linking some implementation PRs
kubernetes/kubernetes#104693
kubernetes/kubernetes#104613

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Nov 9, 2021

Hi @ravisantoshgudimetla! 1.23 Enhancements shadow here👋🏽
Just checking on the PRs status for this issue as we are approaching code freeze deadline on Tuesday, November 16 at 6:00 pm PST

I see that the two PRs are merged. Are there any open PRs that need to be linked to this issue?
Marking this as tracked in the tracking sheet. Please let me know if there are any updates.

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Nov 10, 2021

@supriya-premkumar - All the needed PRs merged. Will open a docs PR shortly

@marosset marosset moved this from Backlog (v 1.23) to In Progress (v1.24) in SIG-Windows Dec 20, 2021
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 9, 2022
@gracenng gracenng modified the milestones: v1.23, v1.24 Jan 14, 2022
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 14, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@marosset
Copy link
Contributor

marosset commented May 11, 2022

/milestone v1.25

We are hoping to GA this enhancement in 1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 11, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 3, 2022
@rhockenbury rhockenbury added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 4, 2022
@rhockenbury
Copy link

rhockenbury commented Jun 4, 2022

👋 Hello @ravisantoshgudimetla,

1.25 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we need to merge #3303 which includes everything to meet all requirements for enhancements freeze.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Jun 6, 2022

Hi @rhockenbury KEP has updated test plan - Can you take a look. I can ask folks from prod readiness to review it then.

@rhockenbury
Copy link

rhockenbury commented Jun 7, 2022

@ravisantoshgudimetla Yes, it looks like all requirements for enhancement freeze will be met once #3303 is merged.

@rhockenbury
Copy link

rhockenbury commented Jun 15, 2022

With #3303 merged, I have this marked as tracked for the v1.25 cycle.

@jasonbraganza
Copy link
Member

jasonbraganza commented Jul 25, 2022

Hi @ravisantoshgudimetla 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.
Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.
Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

@sftim
Copy link
Contributor

sftim commented Jul 26, 2022

We should document podOS outside of https://kubernetes.io/docs/concepts/windows/user-guide/

(Windows is one supported podOS, but it's not the only game in town)

When we add that documentation, consider updating the release note for kubernetes/kubernetes#111229

@cathchu
Copy link

cathchu commented Jul 27, 2022

Hi @ravisantoshgudimetla 👋

1.25 Release Docs Shadow here. Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before August 4.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@jasonbraganza
Copy link
Member

jasonbraganza commented Jul 29, 2022

Hello @ravisantoshgudimetla 👋

With the k/k code PRs, now merged, the enhancement is ready for the 1.25 code freeze

The status of this enhancement is currently marked as tracked

Thank you.

@sftim
Copy link
Contributor

sftim commented Aug 15, 2022

I recommend mentioning kubernetes/website#35985 in the KEP issue description.

@marosset
Copy link
Contributor

marosset commented Aug 15, 2022

I recommend mentioning kubernetes/website#35985 in the KEP issue description.

done!

@marosset marosset removed this from In Progress (v1.25) in SIG-Windows Aug 18, 2022
@marosset
Copy link
Contributor

marosset commented Aug 25, 2022

This is merged.
Let's do a final KEP update then we close this issue.

@marosset
Copy link
Contributor

marosset commented Sep 1, 2022

/close

Thanks @ravisantoshgudimetla for all of your contributions here!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 1, 2022

@marosset: Closing this issue.

In response to this:

/close

Thanks @ravisantoshgudimetla for all of your contributions here!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhockenbury rhockenbury removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Development

No branches or pull requests