Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Kubelet Configuration #281

Closed
27 tasks done
mtaufen opened this issue Apr 26, 2017 · 125 comments
Closed
27 tasks done

Dynamic Kubelet Configuration #281

mtaufen opened this issue Apr 26, 2017 · 125 comments
Assignees
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@mtaufen
Copy link
Contributor

mtaufen commented Apr 26, 2017

Dynamic Kubelet Configuration

@mtaufen mtaufen added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 26, 2017
@mtaufen mtaufen added this to the v1.7 milestone Apr 26, 2017
@mtaufen mtaufen self-assigned this Apr 26, 2017
@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 3, 2017
@idvoretskyi idvoretskyi added this to In Progress in Kubernetes 1.7 features May 3, 2017
@mtaufen
Copy link
Contributor Author

mtaufen commented May 23, 2017

Alpha PR: kubernetes/kubernetes#46254

@dchen1107
Copy link
Member

dchen1107 commented Jun 14, 2017

Punt this to v1.8.

@calebamiles calebamiles modified the milestones: 1.8, next-milestone Jul 25, 2017
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Aug 9, 2017
Automatic merge from submit-queue (batch tested with PRs 50016, 49583, 49930, 46254, 50337)

Alpha Dynamic Kubelet Configuration

Feature: kubernetes/enhancements#281

This proposal contains the alpha implementation of the Dynamic Kubelet Configuration feature proposed in ~#29459~ [community/contributors/design-proposals/dynamic-kubelet-configuration.md](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/dynamic-kubelet-configuration.md). 

Please note:
- ~The proposal doc is not yet up to date with this implementation, there are some subtle differences and some more significant ones. I will update the proposal doc to match by tomorrow afternoon.~
- ~This obviously needs more tests. I plan to write several O(soon). Since it's alpha and feature-gated, I'm decoupling this review from the review of the tests.~ I've beefed up the unit tests, though there is still plenty of testing to be done.
- ~I'm temporarily holding off on updating the generated docs, api specs, etc, for the sake of my reviewers 😄~ these files now live in a separate commit; the first commit is the one to review.

/cc @dchen1107 @vishh @bgrant0607 @thockin @derekwaynecarr 

```release-note
Adds (alpha feature) the ability to dynamically configure Kubelets by enabling the DynamicKubeletConfig feature gate, posting a ConfigMap to the API server, and setting the spec.configSource field on Node objects. See the proposal at https://github.com/kubernetes/community/blob/master/contributors/design-proposals/dynamic-kubelet-configuration.md for details.
```
@mtaufen mtaufen added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 31, 2017
@luxas
Copy link
Member

luxas commented Sep 12, 2017

@mtaufen Any user/admin-facing docs ready for this feature?

@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 12, 2017

No, I really need to write something to teach people how to play with the alpha. What's the preferred place for these docs again?

@luxas
Copy link
Member

luxas commented Sep 13, 2017

@mtaufen https://kubernetes.io/docs (https://github.com/kubernetes/kubernetes.github.io)
I'll definitely read what it came to look like finally

@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 18, 2017

@idvoretskyi
Copy link
Member

idvoretskyi commented Sep 19, 2017

@mtaufen can you update the features tracking board with the relevant data?

Thanks.

@idvoretskyi idvoretskyi added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 19, 2017
@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 19, 2017

Done

@idvoretskyi idvoretskyi removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 20, 2017
@pipejakob
Copy link
Contributor

pipejakob commented Sep 27, 2017

Looks like the proposal has moved to:

https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/dynamic-kubelet-configuration.md

@mtaufen Want to update the link in the description?

@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 27, 2017

Done, thanks!

@luxas luxas added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Oct 12, 2017
akhilerm pushed a commit to akhilerm/apimachinery that referenced this issue Sep 20, 2022
Automatic merge from submit-queue (batch tested with PRs 50016, 49583, 49930, 46254, 50337)

Alpha Dynamic Kubelet Configuration

Feature: kubernetes/enhancements#281

This proposal contains the alpha implementation of the Dynamic Kubelet Configuration feature proposed in ~#29459~ [community/contributors/design-proposals/dynamic-kubelet-configuration.md](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/dynamic-kubelet-configuration.md). 

Please note:
- ~The proposal doc is not yet up to date with this implementation, there are some subtle differences and some more significant ones. I will update the proposal doc to match by tomorrow afternoon.~
- ~This obviously needs more tests. I plan to write several O(soon). Since it's alpha and feature-gated, I'm decoupling this review from the review of the tests.~ I've beefed up the unit tests, though there is still plenty of testing to be done.
- ~I'm temporarily holding off on updating the generated docs, api specs, etc, for the sake of my reviewers 😄~ these files now live in a separate commit; the first commit is the one to review.

/cc @dchen1107 @vishh @bgrant0607 @thockin @derekwaynecarr 

```release-note
Adds (alpha feature) the ability to dynamically configure Kubelets by enabling the DynamicKubeletConfig feature gate, posting a ConfigMap to the API server, and setting the spec.configSource field on Node objects. See the proposal at https://github.com/kubernetes/community/blob/master/contributors/design-proposals/dynamic-kubelet-configuration.md for details.
```

Kubernetes-commit: 458cc04330a11ec958403ebc7ef5f4dca86a728f
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 7, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 7, 2022

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Oct 8, 2022

Hello @SergeyKanzhelev wave, 1.25 Enhancements team here.

This feature was deprecated in K8s version 1.24.

Could you please confirm whether the kep.yaml file require any status updates and following that, close this issue?

This would help accurate tracking in the v1.25 cycle. Thank you so much! slightly_smiling_face

https://github.com/kubernetes/enhancements/blob/2cd758cc6ab617a93f578b40e97728261ab886ed/keps/sig-node/281-dynamic-kubelet-configuration/kep.yaml states that the feature was removed.

@sftim
Copy link
Contributor

sftim commented Oct 8, 2022

https://github.com/kubernetes/enhancements/tree/2cd758cc6ab617a93f578b40e97728261ab886ed/keps/sig-node/281-dynamic-kubelet-configuration states that the removal from the API server happens in Kubernetes v1.26

That makes me think we should reopen and track this.
/reopen

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 8, 2022

@sftim: Reopened this issue.

In response to this:

https://github.com/kubernetes/enhancements/tree/2cd758cc6ab617a93f578b40e97728261ab886ed/keps/sig-node/281-dynamic-kubelet-configuration states that the removal from the API server happens in Kubernetes v1.26

That makes me think we should reopen and track this.
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Oct 8, 2022
@pacoxu
Copy link
Member

pacoxu commented Oct 9, 2022

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Oct 10, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 10, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 10, 2022

See kubernetes/kubernetes#112643 (comment) for the approved exception request for v1.26.

@leonardpahlke
Copy link
Member

leonardpahlke commented Oct 10, 2022

/label lead-opted-in
/label tracked/yes
/milestone v1.26

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.24, v1.26 Oct 10, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 10, 2022

@leonardpahlke: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in
/label tracked/yes
/milestone v1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 10, 2022
@gracenng
Copy link
Member

gracenng commented Oct 10, 2022

let me see if i have perm haha
/label lead-opted-in

@gracenng gracenng added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 10, 2022
@leonardpahlke
Copy link
Member

leonardpahlke commented Oct 10, 2022

:D whatt, I guess we can add release-team-leads to the list

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 10, 2022

@gracenng: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

let me see if i have perm haha
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhockenbury
Copy link

rhockenbury commented Oct 29, 2022

Hi @mtaufen and @SergeyKanzhelev 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).

For the deprecation, please let me know if we should tracking any PRs beyond #3605. I have this marked as tracked.

As always, we are here to help should questions come up. Thanks!

@krol3
Copy link

krol3 commented Nov 7, 2022

Hello @mtaufen 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@mtaufen
Copy link
Contributor Author

mtaufen commented Nov 10, 2022

Closing this issue since this feature has been on the deprecation track for a while. kubernetes/kubernetes#102966

@mtaufen mtaufen closed this as completed Nov 10, 2022
@mtaufen
Copy link
Contributor Author

mtaufen commented Nov 10, 2022

@SergeyKanzhelev FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Deprecation
Development

No branches or pull requests