Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet OpenTelemetry Tracing #2831

Open
4 tasks done
sallyom opened this issue Jul 21, 2021 · 32 comments
Open
4 tasks done

Kubelet OpenTelemetry Tracing #2831

sallyom opened this issue Jul 21, 2021 · 32 comments
Assignees
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@sallyom
Copy link
Contributor

sallyom commented Jul 21, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 21, 2021
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 26, 2021

@sallyom can you please add the mandatory discussion link to this issue?

@ehashman
Copy link
Member

ehashman commented Sep 8, 2021

/sig node instrumentation

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2021
@liggitt liggitt modified the milestone: v1.24 Oct 28, 2021
@logicalhan
Copy link
Contributor

logicalhan commented Oct 28, 2021

/assign

@shivanshu1333
Copy link
Member

shivanshu1333 commented Oct 28, 2021

/cc

2 similar comments
@yangjunmyfm192085
Copy link

yangjunmyfm192085 commented Jan 14, 2022

/cc

@249043822
Copy link
Member

249043822 commented Jan 14, 2022

/cc

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 17, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 17, 2022
@hosseinsalahi
Copy link

hosseinsalahi commented Jan 20, 2022

Hello @sallyom

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
    - KEP file PR is pending.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date for release v1.24.
Thanks!

@sallyom
Copy link
Contributor Author

sallyom commented Jan 20, 2022

@encodeflush thanks for the check-in - I'm not sure what the production readiness review is edit: found it, will add the questionnaire, I don't see it on the enhancements README can you point me to the steps to get that done? Thanks again. Also, am I meant to check those off as they are done or are they for someone else to decide?

@hosseinsalahi
Copy link

hosseinsalahi commented Jan 28, 2022

@sallyom Thanks for the update. Those criterion should be fulfilled form your side. From enhancements team point of view, we go through them and check if your KEP meets the requirements.

@chrisnegus
Copy link

chrisnegus commented Feb 11, 2022

Hi @sallyom 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@valaparthvi
Copy link

valaparthvi commented Mar 21, 2022

Hi @sallyom 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@hosseinsalahi
Copy link

hosseinsalahi commented Mar 21, 2022

Hello @sallyom

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

@ddebroy
Copy link
Member

ddebroy commented Mar 22, 2022

#3087 is not directly related to the overall OpenTelemetry enhancements.

@sallyom
Copy link
Contributor Author

sallyom commented Mar 23, 2022

kubernetes/kubernetes#105126 is the initial implementation for this enhancement

@valaparthvi
Copy link

valaparthvi commented Mar 29, 2022

Hi @sallyom 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

Hey @sallyom, can you please add a placeholder PR for this feature in https://github.com/kubernetes/website by March 30, that is our extended deadline for feature blog freeze?

Example of a feature blog PR: kubernetes/website#30538
Example of a feature blog: https://github.com/kubernetes/website/blob/main/content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md

@gracenng
Copy link
Member

gracenng commented Mar 30, 2022

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline
Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 30, 2022
@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 30, 2022
@gracenng gracenng added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 30, 2022
@wondywang
Copy link

wondywang commented Apr 20, 2022

Hi @sallyom
a question about Kubelet Tracing. Is there any trace information about the PLEG of the kubelet itself?

@logicalhan
Copy link
Contributor

logicalhan commented May 12, 2022

KEP will need to be updated with the new release versions since 1.24 was missed.

@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 10, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jun 10, 2022
@marosset marosset added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 10, 2022
@marosset
Copy link
Contributor

marosset commented Jun 10, 2022

Hello @sallyom 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@sallyom
Copy link
Contributor Author

sallyom commented Jun 16, 2022

Hello @marosset please see the PR to KEP-2831 #3404, where I've updated

  • implentation history
  • testing plan
  • milestones

Thank you!

@marosset
Copy link
Contributor

marosset commented Jun 17, 2022

Hi @sallyom #3404 has everything required to track this enhancement for v1.25.

Please note that enhancement freeze is on 18:00 PST on Thursday June 23, 2022

Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 21, 2022

Hello 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

The Open PR #3404 is waiting on a SIG approval/lgtm.

Please plan to get the PR merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT (which is just over 3 days away from now)

For note, the current status of the enhancement is atat-risk. Thank you!

@marosset
Copy link
Contributor

marosset commented Jun 22, 2022

Hello @somalley, @husky-parul 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@sethmccombs
Copy link

sethmccombs commented Jul 12, 2022

Hello @sallyom and @husky-parul! 👋,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@jasonbraganza
Copy link
Member

jasonbraganza commented Jul 25, 2022

Hi @sallyom, @husky-parul 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.
Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.
Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

@husky-parul
Copy link
Contributor

husky-parul commented Jul 25, 2022

Hi @jasonbraganza

@sallyom has a PR WIP for this. She is on PTO but will close this before the said deadline. Thank you for following up with us. :)

@jasonbraganza
Copy link
Member

jasonbraganza commented Aug 2, 2022

Hello @sallyom, @husky-parul 👋🏿

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022, tomorrow.

Please plan to get the open k/k PRs merged by then

The status of this enhancement is currently marked as at risk

Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 3, 2022

With k/k PR kubernetes/kubernetes#105126 merged now, this enhancement is marked as tracked for 1.25 code freeze. Thank you so much @sallyom @husky-parul.

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@logicalhan
Copy link
Contributor

logicalhan commented Sep 22, 2022

/assign @dashpole

@saschagrunert
Copy link
Member

saschagrunert commented Nov 15, 2022

@sallyom @dashpole I have to speak about our internal priorities for 1.27 but I may be able to pick this up.

Do you already have plans to graduate the feature in 1.27?

@dashpole
Copy link
Contributor

dashpole commented Nov 15, 2022

@saschagrunert I don't personally have plans to drive this in 1.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests