Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove klog specific command line arguments from Kubernetes components #2845

Open
15 tasks done
serathius opened this issue Jul 30, 2021 · 38 comments
Open
15 tasks done
Assignees
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.

Comments

@serathius
Copy link
Contributor

serathius commented Jul 30, 2021

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 30, 2021
@serathius
Copy link
Contributor Author

serathius commented Jul 30, 2021

/sig arch
/sig instrumentation
/wg structured-logging

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 30, 2021

@serathius: The label(s) sig/arch cannot be applied, because the repository doesn't have them.

In response to this:

/sig arch
/sig instrumentation
/wg structured-logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 30, 2021
@serathius
Copy link
Contributor Author

serathius commented Jul 30, 2021

/sig architecture
/milestone v1.23

@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jul 30, 2021
serathius added a commit to serathius/enhancements that referenced this issue Sep 2, 2021
@kevindelgado
Copy link
Contributor

kevindelgado commented Sep 3, 2021

Hi @serathius! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo (PR Open).
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements (PR Open).

Looks like for this one we would just need the KEP (#2912) merge by enhancements freeze :)

All good now!

Thanks!

@kevindelgado
Copy link
Contributor

kevindelgado commented Sep 3, 2021

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 3, 2021
@kevindelgado
Copy link
Contributor

kevindelgado commented Sep 3, 2021

/tracked yes

serathius added a commit to serathius/enhancements that referenced this issue Sep 7, 2021
@kevindelgado
Copy link
Contributor

kevindelgado commented Sep 8, 2021

Hi @serathius

Ping! As a reminder your PR (#2912 ) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception.

Lmk if you need anything,
Kevin

serathius added a commit to serathius/enhancements that referenced this issue Sep 9, 2021
serathius added a commit to serathius/enhancements that referenced this issue Sep 9, 2021
k8s-ci-robot pushed a commit that referenced this issue Sep 9, 2021
* Move KEP-2845 to implementable

* Add PRR for #2845

* Remove mention of --logtostdout flag in #2845

* KEP #2485: Require splitting stdout/stderr to Json format

* Add pohly as reviewer for KEP 2845

* #2845 Update PRR

* #2845 Add dims as SIG arch approver
ravisantoshgudimetla pushed a commit to ravisantoshgudimetla/enhancements that referenced this issue Sep 9, 2021
* Move KEP-2845 to implementable

* Add PRR for kubernetes#2845

* Remove mention of --logtostdout flag in kubernetes#2845

* KEP kubernetes#2485: Require splitting stdout/stderr to Json format

* Add pohly as reviewer for KEP 2845

* kubernetes#2845 Update PRR

* kubernetes#2845 Add dims as SIG arch approver
@mehabhalodiya
Copy link

mehabhalodiya commented Sep 18, 2021

Hi @serathius 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@serathius
Copy link
Contributor Author

serathius commented Nov 1, 2021

@pohly I have split Alpha work by milestones. I have assigned to you

  • Klog can be configured without registering flags
  • Kubernetes logging configuration drops global state

Please confirm and let me know when you will have PR for them.

@serathius
Copy link
Contributor Author

serathius commented Nov 1, 2021

Marked "Klog can be configured without registering flags" as resolved as technically kubernetes/kubernetes#105076 moved klog flag registration into component-base allowing us to register only flags we want.

@pohly
Copy link
Contributor

pohly commented Nov 1, 2021

@pohly I have split Alpha work by milestones. I have assigned to you

* Klog can be configured without registering flags

* Kubernetes logging configuration drops global state

Please confirm

That's okay. As discussed in https://kubernetes.slack.com/archives/C020CCMUEAX/p1635445845031900, both will be solved by adding fields for -v and -vmodule to LoggingConfiguration. Those two fields then can be set without having to use command line flags (first line item) and the configuration can be passed around before being applied (second line item).

@pohly
Copy link
Contributor

pohly commented Nov 2, 2021

/assign

@pohly
Copy link
Contributor

pohly commented Jan 21, 2022

#3170 bumps the milestone.

rikatz pushed a commit to rikatz/enhancements that referenced this issue Feb 1, 2022
* Move KEP-2845 to implementable

* Add PRR for kubernetes#2845

* Remove mention of --logtostdout flag in kubernetes#2845

* KEP kubernetes#2485: Require splitting stdout/stderr to Json format

* Add pohly as reviewer for KEP 2845

* kubernetes#2845 Update PRR

* kubernetes#2845 Add dims as SIG arch approver
@chrisnegus
Copy link

chrisnegus commented Feb 11, 2022

Hi @pohly and @serathius 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@ehashman
Copy link
Member

ehashman commented Mar 17, 2022

The beta docs requirement was:

Documentation on migrating off klog flags is publicly available

@pohly has done this and will add a link to the issue here.

@pohly
Copy link
Contributor

pohly commented Mar 17, 2022

Current documentation: https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/cluster-administration/system-logs.md#klog

I don't think we need anything beyond that for 1.24.

@chrisnegus
Copy link

chrisnegus commented Mar 19, 2022

Thanks @pohly ! I'll note that on our project board. Thanks!

@valaparthvi
Copy link

valaparthvi commented Mar 21, 2022

Hi @serathius and @pohly 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@hosseinsalahi
Copy link

hosseinsalahi commented Mar 21, 2022

Hello @serathius @pohly

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

@serathius
Copy link
Contributor Author

serathius commented Mar 22, 2022

Could you please confirm if following PR is part of the implementation for this enhancement?

@encodeflush all the work for Beta is done, I don't think this is a PR.

@hosseinsalahi
Copy link

hosseinsalahi commented Mar 23, 2022

Hello @serathius @pohly

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as tracked.

Could you please confirm if following PR is part of the implementation for this enhancement?
- #1602

Thank you!

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 8, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@pohly
Copy link
Contributor

pohly commented Aug 8, 2022

/remove-lifecycle stale

The goal is to complete the deprecation in 1.26.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 6, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022
@dgrisonnet
Copy link
Member

dgrisonnet commented Nov 8, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2022
@dgrisonnet
Copy link
Member

dgrisonnet commented Nov 8, 2022

@pohly should this be graduated to stable now that the flags have been removed in k/k?

@pohly
Copy link
Contributor

pohly commented Nov 8, 2022

Yes, I think we could do that.

@logicalhan
Copy link
Contributor

logicalhan commented Nov 8, 2022

Yes, I think we could do that.

#3650

@sftim
Copy link
Contributor

sftim commented Nov 17, 2022

Could we change the issue title to "Remove klog specific command line arguments from Kubernetes components"?
(currently: "Deprecate klog specific flags in Kubernetes components", but we in fact plan to remove them as well)

@serathius serathius changed the title Deprecate klog specific flags in Kubernetes components Remove klog specific command line arguments from Kubernetes components Nov 17, 2022
@pohly
Copy link
Contributor

pohly commented Nov 17, 2022

/title Remove klog specific command line arguments from Kubernetes components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Development

No branches or pull requests