Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD Validation Expression Language #2876

Open
19 of 21 tasks
jpbetz opened this issue Aug 18, 2021 · 89 comments
Open
19 of 21 tasks

CRD Validation Expression Language #2876

jpbetz opened this issue Aug 18, 2021 · 89 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Aug 18, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 18, 2021
@mysunshine92
Copy link

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 25, 2021
@kevindelgado
Copy link
Contributor

kevindelgado commented Sep 3, 2021

Hi @jpbetz and @cici37! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo (PR Open).
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria (Only has criteria for beta).
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

If you can, please add a test plan and alpha graduation criteria to the KEP and be sure the KEP PR merges by enhancements freeze :)

Thanks!

@kevindelgado
Copy link
Contributor

/milestone 1.23
/stage alpha

@k8s-ci-robot
Copy link
Contributor

@kevindelgado: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.23
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 3, 2021
@kevindelgado
Copy link
Contributor

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 3, 2021
@kevindelgado kevindelgado added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 3, 2021
@kevindelgado
Copy link
Contributor

Hi @cici37

Ping! As a reminder your PR (#2877) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception.

Lmk if you need anything,
Kevin

@cici37
Copy link
Contributor

cici37 commented Sep 9, 2021

@kevindelgado PR has been merged. Updated the checkbox. Thanks^^

@mehabhalodiya
Copy link

Hi @jpbetz 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@kevindelgado
Copy link
Contributor

Hi @cici37 and @jpbetz 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

@kikisdeliveryservice
Copy link
Member

Related: #3039

@cici37
Copy link
Contributor

cici37 commented Nov 16, 2021

@kevindelgado @mehabhalodiya
Thanks for the reminder. All PRs to k/k related with this enhancement have been merged and we have a documentation placeholder PR here. Updated the description.

@cici37
Copy link
Contributor

cici37 commented Nov 24, 2021

I have updated the documentation PR to kubernetes/website#30626. Sorry for any inconvenient.

@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 9, 2022
@gracenng gracenng removed this from the v1.23 milestone Jan 9, 2022
@liggitt liggitt added this to the v1.24 milestone Jan 19, 2022
@deads2k
Copy link
Contributor

deads2k commented Jan 21, 2022

related enhancement #3160

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 22, 2022
@hosseinsalahi
Copy link

hosseinsalahi commented Jan 28, 2022

Hello @jpbetz

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting beta for v1.24, is this correct?

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

In the kep.yaml latest-milestone should point to the correct release.

The status of this enhancement is marked as at risk. Please update the merged kep.yaml to reflect the stage as current release cycle 1.24.
Thanks!

@VibhorChinda
Copy link

Hello @jpbetz @cici37 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

@carlory
Copy link
Member

carlory commented Aug 4, 2023

please update the beta in 1.28 section of the description with the pr kubernetes/website#42120

@npolshakova
Copy link

Hello 👋, 1.29 Enhancements Lead here.

If you wish to progress this enhancement in v1.29, please have the SIG lead opt-in your enhancement by adding the lead-opt-in and milestone v1.29 labels before the Production Readiness Review Freeze.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@cici37
Copy link
Contributor

cici37 commented Sep 20, 2023

@npolshakova Thanks for confirming. We do wanna to promote this feature to GA in 1.29. I will add the label shortly.

/milestone v1.29
/label lead-opted-in
/stage stable

@k8s-ci-robot k8s-ci-robot removed the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.28, v1.29 Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

@cici37: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

@npolshakova Thanks for confirming. We do wanna to promote this feature to GA in 1.29. I will add the label shortly.

/milestone v1.29
/label lead-opted-in
/stage stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npolshakova
Copy link

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 22, 2023
@apelisse
Copy link
Member

apelisse commented Oct 2, 2023

cc @alexzielenski

@salehsedghpour
Copy link

Hello @cici37 & @jpbetz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implemented for latest-milestone: 1.29.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to add/update the following:

  • KEP readme using the latest template has been merged into the k/enhancements repo. Please check the graduation criteria and and production readiness review questionnaire.
  • The kep.yaml file based on the recent changes

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@liggitt
Copy link
Member

liggitt commented Oct 3, 2023

We don't mark KEPs as implemented until they actually land in the release

@cici37
Copy link
Contributor

cici37 commented Oct 4, 2023

@salehsedghpour Thanks for the reply. It is tricky for the long existing KEP to adopt the latest template. I have raised the PR to adopt the latest PRR section. Please feel free to let me know if I missed anything else.
For KEP status, I currently have it marked as implementable which should be better reflecting the status.
And I have up-to-date graduation criteria in current KEP readme.

Thank you

@salehsedghpour
Copy link

@liggitt and @cici37, I'm sorry for the confusion. Yes, the status should be marked as implemented after the code PRs are merged.

And thank you for updating the PR. The only thing that is left, is the updated graduation criteria.

@liggitt
Copy link
Member

liggitt commented Oct 4, 2023

The only thing that is left, is the updated graduation criteria.

can you clarify what you are looking for here? the merged KEP has GA graduation criteria

@salehsedghpour
Copy link

You're right it has. My main concern was that it has been added in 1.27, I thought that it should be updated at this point. If there is no need to update it, then this KEP can be considered as tracked for the enhancement freeze.

@cici37
Copy link
Contributor

cici37 commented Oct 5, 2023

@salehsedghpour The graduation criteria has been updated before this release cycle begins so it is up to date. Thanks!

@taniaduggal
Copy link

Hey there @jpbetz ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 11, 2023

^ @cici37

I don't know exactly what's missing, but we've added some new fields recently and some CEL features are newly enabled by default in this release.

@cici37
Copy link
Contributor

cici37 commented Oct 11, 2023

I will open a placeholder PR later. The newly added fields have already been added into the doc. We mainly have to update the feature status and cel changes.

@salehsedghpour
Copy link

Hey again @cici37 and @jpbetz 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please make sure to update the status in kep.yaml to implemented after all PRs are merged.

With this, the status of this KEP is at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@a-mccarthy
Copy link

Hi @cici37 @jpbetz, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@salehsedghpour
Copy link

Hi @cici37 and @jpbetz,
As the following PR is now merged the status of this PR can now be marked with tracked for the code freeze.
kubernetes/kubernetes#121373

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked
Status: Tracked
Status: Tracked for Code Freeze
Development

No branches or pull requests