Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Side Unknown Field Validation #2885

Open
17 of 19 tasks
kevindelgado opened this issue Aug 20, 2021 · 26 comments
Open
17 of 19 tasks

Server Side Unknown Field Validation #2885

kevindelgado opened this issue Aug 20, 2021 · 26 comments
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/api-expression Categorizes an issue or PR as relevant to WG API Expression.
Milestone

Comments

@kevindelgado
Copy link
Contributor

kevindelgado commented Aug 20, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 20, 2021
@kevindelgado
Copy link
Contributor Author

kevindelgado commented Aug 20, 2021

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 20, 2021
@kevindelgado
Copy link
Contributor Author

kevindelgado commented Sep 3, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 3, 2021
@kevindelgado
Copy link
Contributor Author

kevindelgado commented Sep 3, 2021

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 3, 2021
@kevindelgado
Copy link
Contributor Author

kevindelgado commented Sep 3, 2021

/tracked

@kevindelgado kevindelgado added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 3, 2021
@kevindelgado
Copy link
Contributor Author

kevindelgado commented Sep 3, 2021

Hi @kevindelgado! This is @kevindelgado from the 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one we would just need the KEP & the PRR file to merge by enhancements freeze :)

All good now!

Thanks!

@kevindelgado
Copy link
Contributor Author

kevindelgado commented Sep 3, 2021

Thanks for checking in @kevindelgado, I'll be sure to get the KEP and PRR merged in by enhancements freeze!

@kevindelgado
Copy link
Contributor Author

kevindelgado commented Sep 8, 2021

Hi @kevindelgado

Ping! As a reminder your PR (#2886) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception.

Lmk if you need anything,
Kevin

@mehabhalodiya
Copy link

mehabhalodiya commented Sep 18, 2021

Hi @kevindelgado 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@kwiesmueller
Copy link
Member

kwiesmueller commented Sep 28, 2021

/wg api-expression

@kevindelgado
Copy link
Contributor Author

kevindelgado commented Nov 8, 2021

Hi @kevindelgado 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

@salaxander
Copy link

salaxander commented Nov 17, 2021

Hi, 1.23 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

  • All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Nov 17, 2021
@sftim
Copy link
Contributor

sftim commented Nov 17, 2021

@kevindelgado I recommend changing the KEP link in this issue description to that it refers to https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/2885-server-side-unknown-field-validation

@reylejano
Copy link
Member

reylejano commented Nov 17, 2021

The Release Team approve an exception request for 3 additional days after the 1.23 Code Freeze. Please have kubernetes/kubernetes#105916 approved & merged by Friday (Nov 19). If updated or new documentation is required, please create a placeholder PR to the dev-1.23 branch in k/website by tomorrow (Nov 18).
/milestone v1.23

@mehabhalodiya
Copy link

mehabhalodiya commented Feb 12, 2022

Hi @kevindelgado 👋🏻 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@salaxander
Copy link

salaxander commented Mar 21, 2022

Hi @kevindelgado 👋

Checking in once more as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Looks like we might just be waiting on this one? -> kubernetes/kubernetes#108350

As always, we are here to help should questions come up.

Thanks!!

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@liggitt liggitt added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels May 24, 2022
@liggitt liggitt added this to the v1.25 milestone May 24, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 3, 2022
@marosset
Copy link
Contributor

marosset commented Jun 6, 2022

Hello @kevindelgado 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage beta for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@kevindelgado
Copy link
Contributor Author

kevindelgado commented Jun 9, 2022

Hi @marosset, https://github.com/kubernetes/enhancements/pull/3319/files is now merged, everything should be set now for enhancements freeze.

@marosset
Copy link
Contributor

marosset commented Jun 9, 2022

Hi @kevindelgado

Can you update the test plan for this KEP to acknowledge the following from the template?

[ ] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.

This is a new requirement for all enhancements in v1.25 release.
Other than that everything looks good.

Thanks!

@kevindelgado
Copy link
Contributor Author

kevindelgado commented Jun 14, 2022

Hi @kevindelgado

Can you update the test plan for this KEP to acknowledge the following from the template?

[ ] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.

This is a new requirement for all enhancements in v1.25 release. Other than that everything looks good.

Thanks!

Done at #3395

@marosset
Copy link
Contributor

marosset commented Jun 14, 2022

Hello @kevindelgado 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage beta for 1.25 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@didicodes
Copy link

didicodes commented Jul 13, 2022

Hello @kevindelgado 👋, 1.25 Release Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.


Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

@kevindelgado
Copy link
Contributor Author

kevindelgado commented Jul 19, 2022

Thanks for the reminder @didicodes, the issue now points to the docs PR at kubernetes/website#32357

@jasonbraganza
Copy link
Member

jasonbraganza commented Jul 25, 2022

Hi @kevindelgado 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.
Since all listed PRs are merged, the status of the enhancement is currently marked as tracked.
Thank you so much!

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/api-expression Categorizes an issue or PR as relevant to WG API Expression.
Projects
None yet
Development

No branches or pull requests