Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI Enum Types #2887

Closed
7 tasks done
jiahuif opened this issue Aug 20, 2021 · 25 comments
Closed
7 tasks done

OpenAPI Enum Types #2887

jiahuif opened this issue Aug 20, 2021 · 25 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@jiahuif
Copy link
Member

jiahuif commented Aug 20, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 20, 2021
@mysunshine92
Copy link

mysunshine92 commented Aug 25, 2021

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 25, 2021
@jiahuif jiahuif changed the title Enum Type for OpenAPI OpenAPI Enum Types Sep 8, 2021
@Priyankasaggu11929 Priyankasaggu11929 added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 9, 2021
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Sep 9, 2021

/milestone v1.23

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 9, 2021

@Priyankasaggu11929: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Sep 9, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 9, 2021
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Sep 9, 2021

Hello @jiahuif! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Today 09/09/2021 23:59 PT. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just require getting this PR #2888 merged.

Thanks!

@jiahuif
Copy link
Member Author

jiahuif commented Sep 10, 2021

@Priyankasaggu11929 #2888 merged, should be good to go.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Sep 10, 2021

Thank you so much @jiahuif. With the KEP PR merged, this enhancement is ready for the 1.23 enhancements freeze.

@mehabhalodiya
Copy link

mehabhalodiya commented Sep 18, 2021

Hi @jiahuif 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Nov 8, 2021

Hello @jiahuif 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thank you so much! 🙂

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Nov 16, 2021

Hello @jiahuif, just want to confirm on whether the following 2 PRs are also part of the implementation of this enhancements?

If yes, could you please add that in the issue description itself, it would be helpful for tracking. Thank you so much!

@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 9, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 27, 2022

Hello @jiahuif 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, this enhancement is targeting for stage beta for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like, for this one, we would require updating the open KEP PR #3184 & having it merged into k/enhancements, to satisfy all above requirements:

  • update the existing kep.yaml to reflect the latest-milestone & stage.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you so much! 🙂

@Priyankasaggu11929 Priyankasaggu11929 added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 27, 2022
@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 27, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 27, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.23, v1.24 Jan 27, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 31, 2022

Hello @jiahuif, just a quick check-in again, as we approach the 1.24 enhancements freeze.

Please plan to get #3184 merged before enhancements freeze on Thursday, February 3rd at 18:00pm PT.

For note, the current status of the enhancement is at at-risk. Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Feb 4, 2022

With KEP PR #3184 merged now, this enhancement is ready for 1.24 enhancements freeze! 🚀

For note, the status is tracked now in the 1.24 tracking sheet. Thank you!

@mehabhalodiya
Copy link

mehabhalodiya commented Feb 12, 2022

Hi @jiahuif 👋🏻 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @jiahuif 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Could you please link any recent PRs for the enhancements in the issue description (if any)? I wasn't able to identify any related PRs on the Kubernetes/Kubernetes repository, other than the following two (could you also please confirm if they're part of implementation?). Thank you so much!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 27, 2022

@jiahuif, with the following code implementation k/k PRs merged now, the requirements for 1.24 code freeze are met.

For note, the status of this enhancement is now tracked. Thank you!

@jiahuif
Copy link
Member Author

jiahuif commented Mar 28, 2022

This feature needs no documentation updates. Could you remove it from "documentation needed" list?

Thank you!

@tengqm
Copy link

tengqm commented Mar 29, 2022

Docs update PR created.

@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

I opened kubernetes/kubernetes#109177 to track an issue with forward-compatibility of generated clients using language-level enums.

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 10, 2022

/milestone clear

@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 8, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 7, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 7, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 7, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 7, 2022

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

9 participants