kubeadm: replace the legacy kubelet-config-x.y naming

[neolit123]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  Deprecate the legacy naming of ConfigMap and RBAC rules in kubeadm that include a MAJOR.MINOR version. Replace them with naming that do not include a MAJOR.MINOR version.
• Kubernetes Enhancement Proposal: https://git.k8s.io/enhancements/keps/sig-cluster-lifecycle/kubeadm/2915-kubeadm-replace-kubelet-config-x.y
• Discussion Link: kubelet-config-x.y ConfigMap logic improvements kubeadm#1582
• Primary contact (assignee): @neolit123
• Responsible SIGs: sig-cluster-lifecycle
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.24
  • Stable release target (x.y): TODO
• Alpha
  • KEP (k/enhancements) update PR(s):
    KEP-2915: add proposal for replacing the kubelet-config-x.y usage #2916
  • Code (k/k) update PR(s):
    kubeadm: introduce the UnversionedKubeletConfigMap feature gate kubernetes#105741
  • E2e tests:
    kinder: add e2e test for UnversionedKubeletConfigMap (Alpha) kubeadm#2601
  • Docs (k/website) update PR(s):
    not required for ALPHA

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[neolit123]

@ release team.

related to PRR for this proposal, see the following note (it's also in the KEP PR):

While the some of the questions in the PRR could be qualified as relevant to this proposal, KEPs
for kubeadm have been established as "out-of-tree" and the PRR does not apply to them.

not sure if PRR folks have already marked kubeadm as out of scope for PRR in the guides for the release team.
happy to answer more questions about that.

[lauralorenz]

Hi @neolit123! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09. Here's where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo. (using latest template, not merged yet)
• KEP status is marked as implementable (filled out in PR, not merged)
• KEP has a test plan section filled out. (filled out in PR, not merged)
• KEP has up to date graduation criteria. (filled out in PR, not merged)
• KEP has a production readiness review that has been completed and merged into k/enhancements.

I noticed that you purposefully did not fill out the production readiness questionnaire; I asked in #sig-release Slack channel and though there are some more formal improvements for this type of case including some automation improvements upcoming, we do need someone from PRR team to confirm that the questionnaire is unnecessary. In other words we do need a file artifact in prod-readiness/<sig>/<KEP number>.yaml with the Github handle of your PRR approver, even though they will effectively be confirming that you don't need it filled out as opposed to doing a full review. (See directions.)

Thanks!!

[neolit123]

@lauralorenz i have updated the PR to include the PRR file and pinged the slack channel (you are mentioned there).

[lauralorenz]

Thank you! Looks like everything is on track as long as your PR gets merged before enhancements freeze tomorrow, Thursday 09/09 at 11:59pm PST.

[ramrodo]

Hi @neolit123 👋 1.23 Docs shadow here.

This enhancement issue is listed as None required for docs in the tracking sheet. I noticed you mention that this enhancement does not require docs since it is ALPHA, but they require it. If this is an exception, let me know.

Otherwise, please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Thanks!

[neolit123]

@ramrodo hi, docs are indeed not required for the alpha here.

[lauralorenz]

Hi @neolit123, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

• all PRs to the Kubernetes repo related to your enhancement are fully merged by the code freeze deadline
  • (Looks like you already have kubeadm: introduce the UnversionedKubeletConfigMap feature gate kubernetes#105741 merged. 🎉)
• have a documentation placeholder PR open by Thursday, November 18.
  • (Looks like you are not expecting to open one based on the comment above kubeadm: replace the legacy kubelet-config-x.y naming #2915 (comment)).

Looks to me that you are good to go. Thanks!!

[Priyankasaggu11929]

Hello @neolit123 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage beta for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for this release
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

• this enhancement require adding here, a production readiness review (PRR) approval for stage beta.

At the moment, the status of this enhancement is marked as at-risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[neolit123]

Hi. PRR is not required for kubeadm KEPs. You can confirm that with the PRR reviewers and/or enhancement leads.

[Priyankasaggu11929]

@neolit123, thanks for pointing towards the non requirement of PRR questionnaire for this enhancement.

PRR is not required for kubeadm KEPs. You can confirm that with the PRR

For note, supporting discussions here:

• Kubernetes Slack thread
• role-handbook/enhancements/README.md: add note about PRR and kubeadm sig-release#1831

With the PRR bit clarified now, this enhancement is ready for the upcoming 1.24 enhancements freeze. I'll update the status of the enhancement to tracked in the 1.24 tracking sheet. Thanks once again!

[Priyankasaggu11929]

Hello, @neolit123, I'm reaching out again about the PRR requirement for this enhancement.

Following up on the consensus remark at #3171, explicit PRR team approval would be required to ensure that kubeadm KEPs are not subject to PRR.

We're less than a week away from Enhancement Freeze on 18:00pm PT on Thursday Feb 3rd, 2022. Could you please assign a PRR approver for this KEP to have the approval in place? Thank you so much!

For note, the current status of the enhancement is at-risk.

[neolit123]

hi, i have removed this KEP from the enhancement tracking sheet:
https://docs.google.com/spreadsheets/d/1T21mUTvPh70NB2eseHjCyD4LgRjyxWI9Bd1SoP8zAwA/edit#gid=1954476102
please remove the label "tracked/yes" and the milestone 1.24 from this ticket.
thank you.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[neolit123]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[neolit123]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[pacoxu]

/remove-lifecycle stale
Opened kubernetes/kubernetes#113448 to close this issue.