Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: replace the legacy kubelet-config-x.y naming #2915

Closed
5 tasks done
neolit123 opened this issue Aug 30, 2021 · 18 comments · Fixed by kubernetes/kubernetes#113448
Closed
5 tasks done

kubeadm: replace the legacy kubelet-config-x.y naming #2915

neolit123 opened this issue Aug 30, 2021 · 18 comments · Fixed by kubernetes/kubernetes#113448
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@neolit123
Copy link
Member

neolit123 commented Aug 30, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@neolit123 neolit123 added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. labels Aug 30, 2021
@neolit123 neolit123 added this to the v1.23 milestone Aug 30, 2021
@neolit123 neolit123 self-assigned this Aug 30, 2021
@salaxander salaxander added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Aug 31, 2021
@neolit123
Copy link
Member Author

neolit123 commented Sep 2, 2021

@ release team.

related to PRR for this proposal, see the following note (it's also in the KEP PR):

While the some of the questions in the PRR could be qualified as relevant to this proposal, KEPs
for kubeadm have been established as "out-of-tree" and the PRR does not apply to them.

not sure if PRR folks have already marked kubeadm as out of scope for PRR in the guides for the release team.
happy to answer more questions about that.

@lauralorenz
Copy link
Contributor

lauralorenz commented Sep 7, 2021

Hi @neolit123! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09. Here's where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo. (using latest template, not merged yet)
  • KEP status is marked as implementable (filled out in PR, not merged)
  • KEP has a test plan section filled out. (filled out in PR, not merged)
  • KEP has up to date graduation criteria. (filled out in PR, not merged)
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

I noticed that you purposefully did not fill out the production readiness questionnaire; I asked in #sig-release Slack channel and though there are some more formal improvements for this type of case including some automation improvements upcoming, we do need someone from PRR team to confirm that the questionnaire is unnecessary. In other words we do need a file artifact in prod-readiness/<sig>/<KEP number>.yaml with the Github handle of your PRR approver, even though they will effectively be confirming that you don't need it filled out as opposed to doing a full review. (See directions.)

Thanks!!

@neolit123
Copy link
Member Author

neolit123 commented Sep 8, 2021

@lauralorenz i have updated the PR to include the PRR file and pinged the slack channel (you are mentioned there).

@lauralorenz
Copy link
Contributor

lauralorenz commented Sep 8, 2021

Thank you! Looks like everything is on track as long as your PR gets merged before enhancements freeze tomorrow, Thursday 09/09 at 11:59pm PST.

@ramrodo
Copy link
Member

ramrodo commented Sep 22, 2021

Hi @neolit123 👋 1.23 Docs shadow here.

This enhancement issue is listed as None required for docs in the tracking sheet. I noticed you mention that this enhancement does not require docs since it is ALPHA, but they require it. If this is an exception, let me know.

Otherwise, please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Thanks!

@neolit123
Copy link
Member Author

neolit123 commented Sep 22, 2021

@ramrodo hi, docs are indeed not required for the alpha here.

@lauralorenz
Copy link
Contributor

lauralorenz commented Nov 15, 2021

Hi @neolit123, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

Looks to me that you are good to go. Thanks!!

@gracenng gracenng removed this from the v1.23 milestone Jan 9, 2022
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 9, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 12, 2022
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 12, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 17, 2022

Hello @neolit123 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage beta for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

  • this enhancement require adding here, a production readiness review (PRR) approval for stage beta.

At the moment, the status of this enhancement is marked as at-risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@neolit123
Copy link
Member Author

neolit123 commented Jan 17, 2022

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 24, 2022

@neolit123, thanks for pointing towards the non requirement of PRR questionnaire for this enhancement.

PRR is not required for kubeadm KEPs. You can confirm that with the PRR

For note, supporting discussions here:

With the PRR bit clarified now, this enhancement is ready for the upcoming 1.24 enhancements freeze. I'll update the status of the enhancement to tracked in the 1.24 tracking sheet. Thanks once again!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 31, 2022

Hello, @neolit123, I'm reaching out again about the PRR requirement for this enhancement.

Following up on the consensus remark at #3171, explicit PRR team approval would be required to ensure that kubeadm KEPs are not subject to PRR.

We're less than a week away from Enhancement Freeze on 18:00pm PT on Thursday Feb 3rd, 2022. Could you please assign a PRR approver for this KEP to have the approval in place? Thank you so much!

For note, the current status of the enhancement is at-risk.

@neolit123
Copy link
Member Author

neolit123 commented Jan 31, 2022

hi, i have removed this KEP from the enhancement tracking sheet:
https://docs.google.com/spreadsheets/d/1T21mUTvPh70NB2eseHjCyD4LgRjyxWI9Bd1SoP8zAwA/edit#gid=1954476102
please remove the label "tracked/yes" and the milestone 1.24 from this ticket.
thank you.

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 1, 2022
@gracenng gracenng removed this from the v1.24 milestone Feb 1, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 2, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2022
@neolit123
Copy link
Member Author

neolit123 commented May 2, 2022

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 31, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2022
@neolit123
Copy link
Member Author

neolit123 commented Jul 31, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 29, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2022
@neolit123 neolit123 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2022
@pacoxu
Copy link
Member

pacoxu commented Oct 30, 2022

/remove-lifecycle stale
Opened kubernetes/kubernetes#113448 to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

9 participants