Min domains in PodTopologySpread

[sanposhiho]

Enhancement Description

• One-line enhancement description (can be used as a release note): support tuning the number of domains in PodTopologySpread
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3022-min-domains-in-pod-topology-spread
• Discussion Link:
  • Tuning the number of domains in PodTopologySpread kubernetes#105291
  • ( topologySpreadConstraint doesn't work fine when only one worker node is eligible for workload kubernetes#105072 )
• Primary contact (assignee): @sanposhiho
• Responsible SIGs: scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.24
  • Beta release target (x.y): 1.25
  • Stable release target (x.y): 1.29
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3022: Min domains in PodTopologySpread #3030
  • Code (k/k) update PR(s):
    • Add MinDomains API to TopologySpreadConstraints field kubernetes#107674
    • Implement MinDomains on Pod Topology Spread kubernetes#108362
  • Docs (k/website) update PR(s):
    • Document the new MinDomainsInPodTopologySpread feature gate website#32340
• Beta
  • KEP (k/enhancements) update PR(s): [KEP-3022] Write the production readiness requirements to graduate to beta #3338
  • Code (k/k) update PR(s): Graduate MinDomains in Pod Topology Spread to beta kubernetes#110388
  • Docs (k/website) update(s): Update the doc for minDomains to graduate minDomains to beta website#35202

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[sanposhiho]

/sig scheduling
/assign

[ahg-g]

/cc @x13n

[alculquicondor]

update the description to link to the merged KEP, instead of linking to the PR that added it.

[ahg-g]

/milestone v1.24

[Priyankasaggu11929]

Hello @sanposhiho 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for this release
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[PI-Victor]

Hi @alculquicondor 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[Priyankasaggu11929]

Hello @alculquicondor 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Add MinDomains API to TopologySpreadConstraints field kubernetes#107674
• Have a documentation placeholder PR open by Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

[alculquicondor]

@sanposhiho can you work on the documentation as well?

[sanposhiho]

Sure, I will update doc and kep this weekend.

[alculquicondor]

There is no need to update the KEP.

[mehabhalodiya]

@sanposhiho I see already opened up PR: kubernetes/website/pull/32340

[sanposhiho]

Hm, looks like other person updated the doc instead of me. Thanks for informing @mehabhalodiya.

[mehabhalodiya]

Hm, looks like other person updated the doc instead of me. Thanks for informing @mehabhalodiya.

Will you please update the issue description?
Thanks!

[sanposhiho]

@alculquicondor
Isn't the following change for kep needed? (If not needed, I'll close this)
#3245

[Priyankasaggu11929]

@sanposhiho @alculquicondor, thank you so much.

With the Docs PR kubernetes/website#32340 open now, all requirements for Code Freeze are finished. The status is now tracked.

[alculquicondor]

added to the tracking sheet too

[sanposhiho]

Thanks

[jasonbraganza]

Hello @sanposhiho 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage beta for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the open KEP PR #3338 & get it merged by the Enhancements Freeze:

• update the KEP README.md to add more details in the Test Plan section, in furtherance of the goal of increasing reliability across the project.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[jasonbraganza]

Hello @sanposhiho. Just checking in, as we are four days away from the enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

Kindly ensure PR #3338 is merged before then.

Please note: the current status of the enhancement is at-risk.
Thank you.

[sanposhiho]

@jasonbraganza We merged #3338 👍

[Priyankasaggu11929]

Thanks so much @sanposhiho. With KEP PR #3338 merged, the enhancement is ready for the 1.25 Enhancements Freeze. For note, the status is now marked as tracked.

[alculquicondor]

Can you update the description with the PRs for beta?

[sanposhiho]

sure, updated

[jasonbraganza]

Hi @sanposhiho 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.
  • Graduate MinDomains in Pod Topology Spread to beta kubernetes#110388

Please verify, if there are any additional k/k PRs besides the ones listed above.
Since all listed PRs are merged, the status of the enhancement is currently marked as tracked.
Thank you so much!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sanposhiho]

/remove-lifecycle stale

[alculquicondor]

@sanposhiho can you graduate to GA in 1.27? The enhancements freeze is set to February 10th.

[sanposhiho]

@alculquicondor
I have the bandwidth to work on it, but I'm wondering if we should wait one more release or not. because actually we don't enable it by default in 1.25 and 1.26 (by mistake 😢 kubernetes/kubernetes#114445) and probably not so many users have used it.
What do you think?

[alculquicondor]

Oh, we should wait until 1.29 then.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[ahg-g]

/remove-lifecycle stale