Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min domains in PodTopologySpread #3022

Open
8 tasks done
sanposhiho opened this issue Oct 28, 2021 · 42 comments
Open
8 tasks done

Min domains in PodTopologySpread #3022

sanposhiho opened this issue Oct 28, 2021 · 42 comments
Assignees
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Oct 28, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 28, 2021
@sanposhiho
Copy link
Member Author

/sig scheduling
/assign

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 28, 2021
@sanposhiho sanposhiho changed the title Tuning the number of domains in PodTopologySpread Min domains in PodTopologySpread Nov 8, 2021
@ahg-g
Copy link
Member

ahg-g commented Dec 14, 2021

/cc @x13n

@alculquicondor
Copy link
Member

update the description to link to the merged KEP, instead of linking to the PR that added it.

@ahg-g
Copy link
Member

ahg-g commented Jan 26, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 26, 2022
@Priyankasaggu11929 Priyankasaggu11929 added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 27, 2022
@Priyankasaggu11929
Copy link
Member

Hello @sanposhiho 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@PI-Victor
Copy link
Member

Hi @alculquicondor 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@Priyankasaggu11929
Copy link
Member

Hello @alculquicondor 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

@alculquicondor
Copy link
Member

@sanposhiho can you work on the documentation as well?

@sanposhiho
Copy link
Member Author

Sure, I will update doc and kep this weekend.

@alculquicondor
Copy link
Member

There is no need to update the KEP.

@mehabhalodiya
Copy link

@sanposhiho I see already opened up PR: kubernetes/website/pull/32340

@sanposhiho
Copy link
Member Author

Hm, looks like other person updated the doc instead of me. Thanks for informing @mehabhalodiya.

@mehabhalodiya
Copy link

Hm, looks like other person updated the doc instead of me. Thanks for informing @mehabhalodiya.

Will you please update the issue description?
Thanks!

@sanposhiho
Copy link
Member Author

@alculquicondor
Isn't the following change for kep needed? (If not needed, I'll close this)
#3245

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 21, 2022

@sanposhiho @alculquicondor, thank you so much.

With the Docs PR kubernetes/website#32340 open now, all requirements for Code Freeze are finished. The status is now tracked.

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@alculquicondor
Copy link
Member

added to the tracking sheet too

@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 16, 2022
@sanposhiho
Copy link
Member Author

Thanks

@jasonbraganza
Copy link
Member

Hello @sanposhiho 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage beta for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the open KEP PR #3338 & get it merged by the Enhancements Freeze:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jasonbraganza
Copy link
Member

Hello @sanposhiho. Just checking in, as we are four days away from the enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

Kindly ensure PR #3338 is merged before then.

Please note: the current status of the enhancement is at-risk.
Thank you.

@sanposhiho
Copy link
Member Author

@jasonbraganza We merged #3338 👍

@Priyankasaggu11929
Copy link
Member

Thanks so much @sanposhiho. With KEP PR #3338 merged, the enhancement is ready for the 1.25 Enhancements Freeze. For note, the status is now marked as tracked.

@alculquicondor
Copy link
Member

Can you update the description with the PRs for beta?

@sanposhiho
Copy link
Member Author

sure, updated

@jasonbraganza
Copy link
Member

Hi @sanposhiho 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.
Since all listed PRs are merged, the status of the enhancement is currently marked as tracked.
Thank you so much!

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2022
@sanposhiho
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2022
@alculquicondor
Copy link
Member

@sanposhiho can you graduate to GA in 1.27? The enhancements freeze is set to February 10th.

@sanposhiho
Copy link
Member Author

sanposhiho commented Jan 10, 2023

@alculquicondor
I have the bandwidth to work on it, but I'm wondering if we should wait one more release or not. because actually we don't enable it by default in 1.25 and 1.26 (by mistake 😢 kubernetes/kubernetes#114445) and probably not so many users have used it.
What do you think?

@alculquicondor
Copy link
Member

Oh, we should wait until 1.29 then.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2023
@ahg-g
Copy link
Member

ahg-g commented Apr 10, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2023
@Atharva-Shinde Atharva-Shinde removed this from the v1.25 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests