Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing Release Artifacts #3031

Open
7 tasks done
saschagrunert opened this issue Nov 2, 2021 · 30 comments
Open
7 tasks done

Signing Release Artifacts #3031

saschagrunert opened this issue Nov 2, 2021 · 30 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject lead-opted-in Denotes that an issue has been opted in to a release sig/release Categorizes an issue or PR as relevant to SIG Release. sig/security Categorizes an issue or PR as relevant to SIG Security. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@saschagrunert
Copy link
Member

saschagrunert commented Nov 2, 2021

Enhancement Description

/area release-eng
/sig release
/cc @kubernetes/sig-release-leads @kubernetes/release-managers @kubernetes/release-engineering
refers to kubernetes/sig-release#1724
depends on #3027

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 2, 2021
@saschagrunert saschagrunert self-assigned this Nov 2, 2021
@sftim
Copy link
Contributor

sftim commented Nov 16, 2021

Is this also relevant to SIG Security?

@PushkarJ
Copy link
Member

PushkarJ commented Nov 18, 2021

Yes I have my 👀 on this :)
/sig security

@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Nov 18, 2021
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 19, 2021

Waiting a bit more for alignment on #3051, then I'll push out the KEP PR.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jan 10, 2022

The KEP got merged, we will now define an MVP and integrate it into our release process. I'm following-up with a dedicated issue on that.

@gracenng gracenng added this to the v1.24 milestone Jan 26, 2022
@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 26, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 26, 2022

Hello @saschagrunert 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would require updating the existing KEP proposal to reflect the following:

  • update the kep.yaml to have an implementable status.
  • update the KEP README.md file to add a Test plan section.
  • add a production readiness review (PRR) for the KEP for stage alpha

At the moment, the status of this enhancement is marked as at-risk. Please keep the issue description up-to-date with appropriate stages, for release team tracking purpose. Thank you so much! 🙂

@rhockenbury
Copy link

rhockenbury commented Feb 3, 2022

With #3191 merged, I've updated the status to tracked for enhancement freeze. Thanks!

saschagrunert added a commit to saschagrunert/website that referenced this issue Feb 3, 2022
This patch outlines basic documentation about how container image
signing works and which images are signed for official Kubernetes
releases.

Refers to kubernetes/enhancements#3031

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/website that referenced this issue Feb 3, 2022
This patch outlines basic documentation about how container image
signing works and which images are signed for official Kubernetes
releases.

Refers to kubernetes/enhancements#3031

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/website that referenced this issue Feb 3, 2022
This patch outlines basic documentation about how container image
signing works and which images are signed for official Kubernetes
releases.

Refers to kubernetes/enhancements#3031

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/website that referenced this issue Feb 3, 2022
This patch outlines basic documentation about how container image
signing works and which images are signed for official Kubernetes
releases.

Refers to kubernetes/enhancements#3031

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/website that referenced this issue Feb 3, 2022
This patch outlines basic documentation about how container image
signing works and which images are signed for official Kubernetes
releases.

Refers to kubernetes/enhancements#3031

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@chrisnegus
Copy link

chrisnegus commented Feb 11, 2022

Hi @saschagrunert 👋 1.24 Docs shadow here.

Thanks for getting the docs placeholder PR for this KEP created so early in the process! The next deadline for 1.24 is to have the PR ready for review by Tuesday April 5, 11:59 PM PDT.

Thanks!

@salaxander
Copy link

salaxander commented Mar 21, 2022

Hi @saschagrunert 👋

Checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

For this KEP, it looks like there aren't any K/K PRs. Are there any other PRs that you think we should be tracking that would be subject to the 1.24 code freeze?

Thanks!!

@saschagrunert
Copy link
Member Author

saschagrunert commented Mar 22, 2022

For this KEP, it looks like there aren't any K/K PRs. Are there any other PRs that you think we should be tracking that would be subject to the 1.24 code freeze?

Hey @salaxander, no we do not require any k/k code changes for this enhancement. 👍

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 1, 2022

Hello @saschagrunert, could you please confirm that there will be no k/k code PRs for the implementation of this enhancement?

And all code will be merged either in the k/release & k-sigs/release-sdk & other release engineering repos?

If that would be the case, the enhancement team will mark this enhancement as tracked for the 1.25 code freeze. Thank you!

@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 1, 2022

Hey @Priyankasaggu11929, there will be no k/k PRs. Nevertheless the scope of the KEP has changed a bit and would require an update. Therefore I tend to move the enhancement to v1.26 to release the pressure especially from the docs perspective.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 1, 2022

Thanks for the prompt update, @saschagrunert. 🙂

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 1, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Aug 1, 2022
@saschagrunert saschagrunert added lead-opted-in Denotes that an issue has been opted in to a release stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 22, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 22, 2022

/label tracked/yes
/remove-label tracked/no
/milestone v1.26

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 22, 2022

@rhockenbury: Those labels are not set on the issue: tracked/no

In response to this:

/label tracked/yes
/remove-label tracked/no
/milestone v1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 22, 2022
@parul5sahoo
Copy link
Member

parul5sahoo commented Sep 25, 2022

Hello @saschagrunert 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 1, 2022

Feature blog post placeholder: kubernetes/website#37639

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 1, 2022

Hi @saschagrunert 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any open k/k PRs. Please plan to get PRs out for all k/k code and the open PRs mentioned above in the issue, so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked for code freeze.

As always, we are here to help should questions come up. Thanks!

@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 1, 2022

@parul5sahoo thank you for the notice. Our code changes will live out of k/k so we should be already good to go for both tasks mentioned in your comment.

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 1, 2022

@saschagrunert great then the enhancement is good to go for code freeze.

@krol3
Copy link

krol3 commented Nov 7, 2022

Hello @saschagrunert 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 8, 2022

Hello @saschagrunert wave, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@Verolop do you wanna take care of this? 🙃

@krol3
Copy link

krol3 commented Nov 14, 2022

Hi @saschagrunert ! Thank you for the docs PR here

@krol3
Copy link

krol3 commented Nov 14, 2022

Hello @saschagrunert 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

@saschagrunert saschagrunert changed the title Signing release artifacts Signing Release Artifacts Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject lead-opted-in Denotes that an issue has been opted in to a release sig/release Categorizes an issue or PR as relevant to SIG Release. sig/security Categorizes an issue or PR as relevant to SIG Security. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests