New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize support for FlexVolume #304

Open
xingzhou opened this Issue Jun 9, 2017 · 47 comments

Comments

@xingzhou

xingzhou commented Jun 9, 2017

Feature Description

  • One-line feature description (can be used as a release note): Add resize call support for FlexVolume to support volume resizing like LVM expansion
  • Primary contact (assignee): Tom Xing(@xingzhou)
  • Responsible SIGs: sig-storage
  • Design proposal link (community repo): kubernetes/community#1700
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @gnufied & @chakri-nelluri
  • Approver (likely from SIG/area to which feature belongs): TBD
  • Feature target (which target equals to which milestone):
    • Alpha release target 1.13
    • Beta release target TBD
    • Stable release target TBD
@xingzhou

This comment has been minimized.

xingzhou commented Jun 9, 2017

According to the discussion in kubernetes/community#657, we want to add volume resize support for FlexVolume, including:
• Improve FlexVolume to support volume resizing call
• Support LVM volume expansion
/cc @gnufied, this feature request depends on #284

@gnufied

This comment has been minimized.

Member

gnufied commented Jun 9, 2017

Also we would want @chakri-nelluri as reviewer. Because he is primary author of flex.

@fejta-bot

This comment has been minimized.

fejta-bot commented Dec 27, 2017

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@xingzhou

This comment has been minimized.

xingzhou commented Jan 4, 2018

We are starting to write a proposal doc first at:
https://docs.google.com/document/d/1dwom9xQ3Fg5F_jJrybr0slp-QsO3_CKiisxzNRoMhec/edit?usp=sharing

will update the progress then

@chakri-nelluri

This comment has been minimized.

chakri-nelluri commented Jan 17, 2018

Thanks @xingzhou.
Reviewed and added comments.

@xingzhou

This comment has been minimized.

xingzhou commented Jan 18, 2018

Thanks @chakri-nelluri for the review, have responded with my answers, please take a look.

@saad-ali and @idvoretskyi, we are planning this feature for v1.10, would you please help to add this ticket to this milestone? thanks

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.10 Jan 22, 2018

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

/remove-lifecycle stale

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

@chakri-nelluri

This comment has been minimized.

chakri-nelluri commented Jan 22, 2018

@xingzhou Added few more comments. PTAL when you get a chance.

@gnufied

This comment has been minimized.

Member

gnufied commented Jan 22, 2018

@xingzhou it might be a good time today to move the proposal to community repository . I am not sure if everyone has seen the proposal on Google doc.

@xingzhou

This comment has been minimized.

xingzhou commented Jan 25, 2018

@gnufied, yes, I'll update the doc on async call and ExpandFS part, later will move the proposal to community repo

xingzhou added a commit to xingzhou/community that referenced this issue Jan 29, 2018

Proposal for growing FlexVolume size.
Proposal for growing FlexVolume size, the feature ticket is at:
kubernetes/enhancements#304

The original google doc for this proposal is at:
https://docs.google.com/document/d/1dwom9xQ3Fg5F_jJrybr0slp-QsO3_CKiisxzNRoMhec/edit?usp=sharing
@xingzhou

This comment has been minimized.

xingzhou commented Jan 29, 2018

have moved the proposal doc to community repo, please take a look, thanks.

@gnufied

This comment has been minimized.

Member

gnufied commented Feb 1, 2018

@xingzhou can you link the design proposal in this feature description?

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Aug 22, 2018

@brahmaroutu thanks. We would need more than that - we'd need an example of how to support expand for flex. I will update the PR

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 25, 2018

@brahmaroutu Could you link the PR here when you have a sec? Please and thank you!

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Aug 26, 2018

@zparnold - kubernetes/kubernetes#67851 is the PR for this feature.

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 26, 2018

Hi @aniket-s-kulkarni I'm sorry I was actually looking for the PR against kubernetes/website (the documentation repo) for the docs on this feature. Apologies for the ambiguity

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Aug 27, 2018

@zparnold I see. Sure. I have asked @brahmaroutu to make some changes and we will add that PR in here soon.

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 27, 2018

@brahmaroutu

This comment has been minimized.

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 27, 2018

justaugustus pushed a commit to justaugustus/features that referenced this issue Sep 3, 2018

Proposal for growing FlexVolume size.
Proposal for growing FlexVolume size, the feature ticket is at:
kubernetes#304

The original google doc for this proposal is at:
https://docs.google.com/document/d/1dwom9xQ3Fg5F_jJrybr0slp-QsO3_CKiisxzNRoMhec/edit?usp=sharing
@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@xingzhou @aniket-s-kulkarni @brahmaroutu --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Sep 6, 2018

@justaugustus I'm still in the process of making changes based on latest review comments. I will update the PR once I'm done.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 6, 2018

Thanks for the update!

@saad-ali

This comment has been minimized.

Member

saad-ali commented Sep 7, 2018

This feature did not make it in to 1.12. Per this thread, moving to next milestone.

@guineveresaenger

This comment has been minimized.

guineveresaenger commented Oct 22, 2018

Hi @aniket-s-kulkarni! There has been no communication on the status but I see activity on the related PR. These still seem to be a lot of debates on implementation details. Are we confident this is going to make the v1.13 milestone? Enhancement freeze is tomorrow COB. If there is no communication or update on the PR, this is going to be pulled from the milestone as it doesn't fit with our "stability" theme. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me or @kacole2 know where we stand. Thanks!

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Oct 22, 2018

@guineveresaenger @kacole2 - We trying our best to get this in. There were some late coming review comments that have dragged this PR out.

The discussions currently underway are around relatively small portions of the code, the main code as well as e2e tests added have been completed and successful. I remain confident that this PR would be completed by the 11/15 code freeze.

@guineveresaenger

This comment has been minimized.

guineveresaenger commented Oct 22, 2018

Thank you for the update @aniket-s-kulkarni!

@claurence

This comment has been minimized.

claurence commented Nov 5, 2018

Hi @aniket-s-kulkarni - I'm an enhancements shadow checking in on how this issue is tracking. Code slush is on 11/9 and code freeze is coming up on 11/15 do you have a status update on the likelihood that this will make the the code freeze date?

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Nov 5, 2018

@claurence the PR was merged in last week. There is a documentation PR open that I will comment on today so that would be on its way as well.

@AishSundar

This comment has been minimized.

AishSundar commented Nov 12, 2018

@aniket-s-kulkarni I assume this enhancement is done (except pending docs?)

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Nov 12, 2018

@AishSundar yes that's correct. I think we can close this.

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Nov 12, 2018

/close

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 12, 2018

@aniket-s-kulkarni: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AishSundar

This comment has been minimized.

AishSundar commented Nov 12, 2018

/reopen

@aniket-s-kulkarni thanks for conforming all work pertaining to Alpha in 1.13 is done. But we would like to keep this enhancement issue open for tracking through Beta and GA in future milestones.

@aniket-s-kulkarni

This comment has been minimized.

aniket-s-kulkarni commented Nov 12, 2018

@AishSundar OK I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment