Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature, NodeConformance, NodeFeature, and Feature Gate labels cleanup #3041

Open
SergeyKanzhelev opened this issue Nov 8, 2021 · 20 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Nov 8, 2021

Enhancement Description

  • One-line enhancement description (can be used as a release note):

NodeConformance, NodeFeature, and Feature Gate labels cleanup

  • Kubernetes Enhancement Proposal:

#3042

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 8, 2021
SergeyKanzhelev added a commit to SergeyKanzhelev/enhancements that referenced this issue Nov 8, 2021
@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented Nov 8, 2021

/sig node
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Feb 6, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Mar 8, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 8, 2022
@ehashman
Copy link
Member

ehashman commented Mar 17, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 17, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jun 16, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 16, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 16, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 16, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 15, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 15, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Aug 26, 2022

/remove-lifecycle rotten
/reopen
#3042 still being discussed

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 26, 2022

@spiffxp: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen
#3042 still being discussed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Aug 26, 2022
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 26, 2022
@BenTheElder BenTheElder added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 7, 2022
@BenTheElder BenTheElder added this to the v1.26 milestone Oct 7, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

This is really late to opt in since enhancements freeze is in a few minutes. I took a quick look at it looks like it does not meet all the requirements for enhancements freeze.

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

@rhockenbury rhockenbury added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 7, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 7, 2022
@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented Oct 7, 2022

@rhockenbury I apologize for the last minute KEP added to be tracked. The KEP was in reviews for a long time and we lost track whether it has all the proper labels.

This KEP is not a product change, just an alignment of test tags in k8s. It doesn't really have stages like alpha/beta/GA nor requires a test plan. The KEP process was suggested mostly for visibility across SIGs and scheduling of work.

I sent a PR to update the status to implementable: #3602

Would it be ok to ignore other requirements and return it back to the milestone?

@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented Oct 7, 2022

I sent a PR to update the status to implementable: #3602

hm, implementable status forces prod readiness review. Since it is not a product change, I don't think we need to spend time on this. Can we make an exception for this KEP?

@BenTheElder
Copy link
Member

BenTheElder commented Oct 7, 2022

e2e.test is technically a binary artifact in the release (which, definitely gets usage, consider the conformance program for example), so it's a bit iffy IMHO

EDIT: to be clear I lean towards yes this is fine, but I'm not certain.

@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

@SergeyKanzhelev, we'll get you answer from the PRR reviewers on Slack - https://kubernetes.slack.com/archives/CPNHUMN74/p1665177817264029

@rhockenbury
Copy link

rhockenbury commented Oct 8, 2022

Based on feedback from the discussion on Slack and with #3602 merged, we have this marked as Tracked for "beta".

/label lead-opted-in
/milestone v1.26
/label tracked/yes
/stage beta
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status lead-opted-in Denotes that an issue has been opted in to a release labels Oct 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 8, 2022
@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 8, 2022
@ruheenaansari34
Copy link

ruheenaansari34 commented Nov 2, 2022

Hi @SergeyKanzhelev 👋,

Checking in once more as we approach the 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any k/k PRs. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue.

As always, we are here to help should questions come up. Thanks!

@Rishit-dagli
Copy link
Member

Rishit-dagli commented Nov 8, 2022

Hello @SergeyKanzhelev 👋 1.26 Release Docs shadow here!

This enhancement is marked as ‘Needs Docs’ for 1.26 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests

9 participants