Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take taints/tolerations into consideration when calculating PodTopologySpread skew #3094

Open
8 tasks done
kerthcet opened this issue Dec 22, 2021 · 43 comments
Open
8 tasks done
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@kerthcet
Copy link
Member

kerthcet commented Dec 22, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 22, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Dec 22, 2021

/sig scheduling
/cc @Huang-Wei @alculquicondor @ahg-g

The milestone should still be discussed about.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 22, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Dec 22, 2021

/assign

@ahg-g
Copy link
Member

ahg-g commented Jan 26, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 26, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Jan 27, 2022

Tip: When we time to graduate this to Beta, don't forget this advices. @kerthcet #3105 (comment)

@Priyankasaggu11929 Priyankasaggu11929 added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 27, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 27, 2022

Hello @kerthcet 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@alculquicondor
Copy link
Member

alculquicondor commented Feb 17, 2022

Hi, is there any progress on the implementation PR?

@kerthcet
Copy link
Member Author

kerthcet commented Feb 18, 2022

Hi, is there any progress on the implementation PR?

Yes, but I'm waiting for this kubernetes/kubernetes#107421 merged first for some potential conflicts.

@PI-Victor
Copy link
Member

PI-Victor commented Feb 19, 2022

Hi @kerthcet 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@kerthcet
Copy link
Member Author

kerthcet commented Mar 4, 2022

Hi all, the api part of this kep has been finished in kubernetes/kubernetes#108492, please take a look if you guys have time.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @kerthcet 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

@kerthcet
Copy link
Member Author

kerthcet commented Mar 18, 2022

Thanks @Priyankasaggu11929 , no PR missed. I'll focus on this kep these days.

@gracenng
Copy link
Member

gracenng commented Mar 30, 2022

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline
Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 30, 2022
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Mar 30, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Apr 1, 2022

Exception was rejected and I'd like to merge this one to release 1.25 then.

@rhockenbury rhockenbury added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Sep 11, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Sep 13, 2022

I'd like to upgrade this to beta in v1.26.

@alculquicondor
Copy link
Member

alculquicondor commented Sep 13, 2022

/label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 13, 2022

@alculquicondor: Can not set label lead-opted-in: Must be member in one of these teams: [sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahg-g
Copy link
Member

ahg-g commented Sep 13, 2022

/label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 13, 2022

@ahg-g: Can not set label lead-opted-in: Must be member in one of these teams: [sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

alculquicondor commented Sep 14, 2022

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 14, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 19, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.25, v1.26 Sep 19, 2022
@rhockenbury rhockenbury added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 20, 2022
@Atharva-Shinde
Copy link

Atharva-Shinde commented Sep 21, 2022

Hey @kerthcet 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to:

  • The KEP needs updating it's Test Plan Section to incorporate details as stated in the updated detailed test plan
  • We also need to include the acknowledgement which is missing in this enhancements Test Plan
  • Update the kep.yaml to reflect up-to-date milestone information
  • Update the production readiness review with latest stage information
  • Include the new updated PR of this KEP in the Issue Description and get it merged before Enhancements Freeze to make this enhancement eligible for 1.26 release.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you :)

@Atharva-Shinde
Copy link

Atharva-Shinde commented Oct 5, 2022

Hello @kerthcet 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the action items mentioned in my comment above done before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

@kerthcet
Copy link
Member Author

kerthcet commented Oct 5, 2022

Thanks @Atharva-Shinde , it's on the way #3539

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

With #3539 merged, we have this marked as tracked for v1.26.

@mickeyboxell
Copy link

mickeyboxell commented Oct 20, 2022

@kerthcet Are docs required for this KEP? If so, who will be opening the docs PR for k/website?

@kerthcet
Copy link
Member Author

kerthcet commented Oct 21, 2022

I will be responsible for this document update about alpha -> beta.

@marosset
Copy link
Contributor

marosset commented Oct 31, 2022

Hi @kerthcet 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I do not see any code PRs linked to this issue.
Please plan to get PRs out for all k/k code so it can be merged up by code freeze.
If you do have k/k PRs open, please link them to this issue (and include them in the initial issue description).

As always, we are here to help should questions come up. Thanks!

@kerthcet
Copy link
Member Author

kerthcet commented Nov 1, 2022

New PR here: kubernetes/kubernetes#113500

@mickeyboxell
Copy link

mickeyboxell commented Nov 2, 2022

Hi @kerthcet 👋 Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time. It must be created by November 9. For more information, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

@marosset
Copy link
Contributor

marosset commented Nov 7, 2022

Hi @kerthcet 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

As always, we are here to help should questions come up. Thanks!

@kerthcet
Copy link
Member Author

kerthcet commented Nov 8, 2022

Thanks @marosset , all code related PRs are merged right now. One website PR is left for approval.

@marosset
Copy link
Contributor

marosset commented Nov 8, 2022

All of the code PRs have merged into k/k so I'm marking this enhancement as Tracked for v1.26.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests