Take taints/tolerations into consideration when calculating PodTopologySpread skew

[kerthcet]

Enhancement Description

• One-line enhancement description (can be used as a release note): Take taints/tolerations into consideration when calculating PodTopologySpread skew
• Kubernetes Enhancement Proposal: KEP-3094: take toleration/taints into considering when computing skew #3105
• Discussion Link: Take taints/tolerations into consideration when calculating PodTopologySpread skew kubernetes#106127
• Primary contact (assignee): @kerthcet
• Responsible SIGs: sig-scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.25
  • Beta release target (x.y): 1.26
  • Stable release target (x.y): TBD
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-3094: take toleration/taints into considering when computing skew #3105
  • Code (k/k) update PR(s): Add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec kubernetes#108492 feat: implement node inclusion policy in scheduler kubernetes#108884
  • Docs (k/website) update PR(s): Document the new NodeInclusionPolicyInPodTopologySpread feature gate website#35044
• Beta
  • KEP (k/enhancements) update PR(s): KEP-3094: Graduate NodeInclusionPolicy to Beta in v1.26 #3539
  • Code (k/k) update PR(s):
    • Graduate kube-scheduler NodeInclusionPolicy to beta kubernetes#113500
    • Add nodeInclusionPolicy benchmark tests to scheduler_perf kubernetes#113615
  • Docs (k/website) update(s): Graduate scheduler nodeInclusionPolicy to beta website#37688
• Stable
  • KEP (k/enhancements) update PR(s): KEP-3094: Graduate NodeInclusionPolicyInPodTopologySpread to GA #4912
  • Code (k/k) update PR(s): KEP-3094: Promote NodeInclusionPolicyInPodTopologySpread to Stable kubernetes#130920
  • Docs (k/website) update(s): [Scheduler] Graduate NodeInclusionPolicy to GA website#49927

[kerthcet]

/sig scheduling
/cc @Huang-Wei @alculquicondor @ahg-g

The milestone should still be discussed about.

[kerthcet]

/assign

[ahg-g]

/milestone v1.24

[kerthcet]

Tip: When we time to graduate this to Beta, don't forget this advices. @kerthcet #3105 (comment)

[Priyankasaggu11929]

Hello @kerthcet 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for this release
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[alculquicondor]

Hi, is there any progress on the implementation PR?

[kerthcet]

Hi, is there any progress on the implementation PR?

Yes, but I'm waiting for this kubernetes/kubernetes#107421 merged first for some potential conflicts.

[PI-Victor]

Hi @kerthcet 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[kerthcet]

Hi all, the api part of this kep has been finished in kubernetes/kubernetes#108492, please take a look if you guys have time.

[Priyankasaggu11929]

Hello @kerthcet 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec kubernetes#108492
• Have a documentation placeholder PR open by Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

[kerthcet]

Thanks @Priyankasaggu11929 , no PR missed. I'll focus on this kep these days.

[gracenng]

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline
Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[kerthcet]

Exception was rejected and I'd like to merge this one to release 1.25 then.

[dipesh-rawat]

Hello @kerthcet 👋, v1.33 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.33, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

[kerthcet]

Hi @dipesh-rawat sorry missed your message, I just submitted a pr #5172 to add the necessary part, does this need a exception considering it's already approved and only a bit few changes. Thanks.

[kerthcet]

/reopen

[k8s-ci-robot]

@kerthcet: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dipesh-rawat]

@kerthcet Unfortunately, the enhancement freeze deadline has passed, and this issue was removed from milestone.

I see PR #5172 is merged post deadline fixing the outstanding items. But to move forward, we’ll need a short exception request filed. Once the exception request is raised and then approved by the release team, this can be added back to the milestone.

If you still wish to progress this enhancement in v1.33, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

[kerthcet]

@kerthcet Unfortunately, the enhancement freeze deadline has passed, and this issue was removed from milestone.

I see PR #5172 is merged post deadline fixing the outstanding items. But to move forward, we’ll need a short exception request filed. Once the exception request is raised and then approved by the release team, this can be added back to the milestone.

If you still wish to progress this enhancement in v1.33, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

Thanks @dipesh-rawat already submitted the Exception, thanks for your time, PTAL.

[dipesh-rawat]

@kerthcet Since the release team has APPROVED the exception request here. This will be considered to be added to the milestone for v1.33 release.

[dipesh-rawat]

@kerthcet Now that PRs #4912 #5172 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
(cc: @fykaa)

/milestone v1.33
/label tracked/yes

[rayandas]

Hello @kerthcet 👋, v1.33 Docs Lead here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[rayandas]

Hi @kerthcet 👋 v1.33 Docs Lead here.

The deadline to raise a placeholder Docs PR is Thursday 27th February 2025 18:00 PDT.
If this enhancement work requires any new docs or modification to existing docs, please create a placeholder PR (it can be a draft PR for now) before the deadline.

Thanks!

[kerthcet]

created here: kubernetes/website#49927, will polish

[rayandas]

Thanks @kerthcet

[fykaa]

Hey again @kerthcet 👋, v1.33 Enhancements team here,

Just checking in as we approach Code Freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I couldn’t find any PR listed in the GitHub issue, neither can I find any associated PRs in kubernetes/kubernetes--could you please share the list of PRs that need tracking?

1. Please list the PRs that need to be merged before code freeze
2. Please Update the Issue description to include all the related PRs of this KEP

If you anticipate missing code freeze, you can file an exception request in advance.
Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

The status of this enhancement is marked as at risk for code freeze.

As always, we are here to help if any questions come up. Thanks!

[aakankshabhende]

Hi @kerthcet 👋 -- this is Aakanksha (@aakankshabhende ) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

• This introduces some breaking change(s)
• This has significant impacts and/or implications to users
• ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[aakankshabhende]

Hi @kerthcet 👋 -- this is Aakanksha (@aakankshabhende ) from 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[dipesh-rawat]

Hi @kerthcet 👋, v1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #3094 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!