Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce nodeExpandSecret in CSI PV source #3107

Open
4 tasks
humblec opened this issue Jan 5, 2022 · 24 comments
Open
4 tasks

Introduce nodeExpandSecret in CSI PV source #3107

humblec opened this issue Jan 5, 2022 · 24 comments
Assignees
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@humblec
Copy link
Contributor

humblec commented Jan 5, 2022

Enhancement Description

CSI spec 1.5 enhanced the spec to add optional secrets field to
NodeExpandVolumeRequest. To support this, we need to have NodeExpandSecret to the
CSI PV source and also derive the expansion secret in csiclient to
send it out as part of the nodeexpand request.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 5, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 5, 2022

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 5, 2022

@humblec
Copy link
Contributor Author

humblec commented Jan 5, 2022

Cc @zhucan

@xing-yang
Copy link
Contributor

xing-yang commented Jan 5, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 5, 2022
@msau42
Copy link
Member

msau42 commented Jan 11, 2022

@humblec do you plan to put together a kep for this?

@humblec
Copy link
Contributor Author

humblec commented Jan 11, 2022

@humblec do you plan to put together a kep for this?

Yeah, thats the plan @msau42 .

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 12, 2022
@rhockenbury
Copy link

rhockenbury commented Jan 20, 2022

Hi @humblec! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting alpha for 1.24.

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.24
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Please plan to submit a KEP and PRR to satisfy this list of requirements. The status of this enhancement is at risk. Thanks!

humblec added a commit to humblec/enhancements that referenced this issue Jan 21, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 21, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 21, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 24, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 24, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 24, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 24, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 3, 2022
@Atharva-Shinde
Copy link

Atharva-Shinde commented Jun 6, 2022

Hello @humblec 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 release

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest milestone: 1.25
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

So it looks like for this one, we would just need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@humblec
Copy link
Contributor Author

humblec commented Jun 7, 2022

@Atharva-Shinde ok, let me update the test plan section ,that should be it

humblec added a commit to humblec/enhancements that referenced this issue Jun 8, 2022
- One-line PR description: update the test plan for NodeExpansionSecret

- Issue link: kubernetes#3107

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jun 13, 2022
- One-line PR description: update the test plan for NodeExpansionSecret

- Issue link: kubernetes#3107

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@Atharva-Shinde
Copy link

Atharva-Shinde commented Jun 13, 2022

Hello @humblec 👋, just a quick check-in again.

The enhancements freeze for 1.25 starts on this Thursday, June 16, 2022 at 18:00 PM PT.

Currently the status of the Pull Request #3359 is-

Now you just need to get the pull request #3359 merged before the enhancements freeze commence :)

Note: For now the current status of the enhancement is still marked at-risk.

@humblec
Copy link
Contributor Author

humblec commented Jun 14, 2022

Its done!

@Atharva-Shinde
Copy link

Atharva-Shinde commented Jun 14, 2022

Hey @humblec

With the KEP PR #3359 merged, this enhancement is all set for the 1.25 Enhancements Freeze! (which is now extended to next week till Thursday June 23, 2022)

The status of the enhancement is now marked as tracked.🥳

@krol3
Copy link

krol3 commented Jul 13, 2022

Hello @humblec 👋, 1.25 Release Docs shadow here.
This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jul 25, 2022

Hi @humblec 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Since, the above listed PRs are merged, the status of the enhancement is currently marked as tracked. Thank you so much!

@krol3
Copy link

krol3 commented Aug 4, 2022

@humblec It was added this PR about documentation dev-1.25 release. kubernetes/website#35334

@humblec
Copy link
Contributor Author

humblec commented Aug 5, 2022

@humblec It was added this PR about documentation dev-1.25 release. kubernetes/website#35334

Thanks @krol3 , hope nothing is pending on this feature for 1.25.
I also have a blog PR for this feature kubernetes/website#33979

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2022
@xing-yang xing-yang modified the milestones: v1.25, v1.26 Sep 16, 2022
@rhockenbury rhockenbury added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 20, 2022
@Atharva-Shinde
Copy link

Atharva-Shinde commented Sep 22, 2022

Hey @humblec 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to:

  • Update the kep.yaml to reflect the current stage information
  • Update the production readiness review with latest information
  • Include the new updated PR of this KEP in the Issue Description and get it merged before Enhancements Freeze to make this enhancement eligible for 1.26 release.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you :)

@Atharva-Shinde
Copy link

Atharva-Shinde commented Oct 5, 2022

Hello @humblec 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the action items mentioned in my comment above done before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests