Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce nodeExpandSecret in CSI PV source #3107

Open
12 tasks done
humblec opened this issue Jan 5, 2022 · 57 comments
Open
12 tasks done

Introduce nodeExpandSecret in CSI PV source #3107

humblec opened this issue Jan 5, 2022 · 57 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@humblec
Copy link
Contributor

humblec commented Jan 5, 2022

Enhancement Description

CSI spec 1.5 enhanced the spec to add optional secrets field to
NodeExpandVolumeRequest. To support this, we need to have NodeExpandSecret to the
CSI PV source and also derive the expansion secret in csiclient to
send it out as part of the nodeexpand request.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 5, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 5, 2022

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 5, 2022

@humblec
Copy link
Contributor Author

humblec commented Jan 5, 2022

Cc @zhucan

@xing-yang
Copy link
Contributor

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 5, 2022
@msau42
Copy link
Member

msau42 commented Jan 11, 2022

@humblec do you plan to put together a kep for this?

@humblec
Copy link
Contributor Author

humblec commented Jan 11, 2022

@humblec do you plan to put together a kep for this?

Yeah, thats the plan @msau42 .

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 12, 2022
@rhockenbury
Copy link

rhockenbury commented Jan 20, 2022

Hi @humblec! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting alpha for 1.24.

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.24
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Please plan to submit a KEP and PRR to satisfy this list of requirements. The status of this enhancement is at risk. Thanks!

humblec added a commit to humblec/enhancements that referenced this issue Jan 21, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 21, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 21, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 24, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 24, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 24, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 24, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/enhancements that referenced this issue Jan 25, 2022
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@xing-yang xing-yang added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status lead-opted-in Denotes that an issue has been opted in to a release labels Sep 24, 2023
@xing-yang
Copy link
Contributor

/milestone v1.29

@sreeram-venkitesh
Copy link
Member

sreeram-venkitesh commented Sep 27, 2023

Hello @humblec 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP #4239 takes care of all the updates necessary to mark the KEP as tracked for the enhancement freeze. Please make sure that your PR is merged in time before the enhancement freeze deadline.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@sreeram-venkitesh
Copy link
Member

Also, we had featured this KEP in this week's LWKD newsletter 🎉

@humblec
Copy link
Contributor Author

humblec commented Sep 27, 2023

Yeah, the information in the previous comment convey the state. Also thanks for listing the KEP in the LWKD newsletter
👍

@sreeram-venkitesh
Copy link
Member

#4239 has been merged and the KEP has been marked as Tracked for enhancements freeze 🎉

@Princesso
Copy link

Hey there @humblec ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@humblec
Copy link
Contributor Author

humblec commented Oct 17, 2023

Hey there @humblec ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@Princesso kubernetes/website#43535 should cover the k/website part.

@kcmartin
Copy link

Hi @humblec! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@humblec
Copy link
Contributor Author

humblec commented Oct 21, 2023

Yes, I am planning to publish blog for this feature. I will get a blog draft soon on the repo.

@sreeram-venkitesh
Copy link
Member

Hey again @humblec 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

The status of this KEP is currently at risk for Code Freeze. I can see the following k/k PR for promoting this feature to stable:

Please update the issue description to include all the related PRs of this KEP under a new stable section in the Github issue description.

As always, we are here to help if any questions come up. Thanks!

@xing-yang
Copy link
Contributor

@sreeram-venkitesh This PR kubernetes/kubernetes#121303 has got "lgtm" and "approved" label. It needs a rebase before it can be merged. Due to the time zone difference, the PR author won't be able to rebase it until tomorrow.

@npolshakova
Copy link

Hi @humblec, @xing-yang, 1.29 Enhancements lead here. This KEP is currently still at risk for code freeze. Once kubernetes/kubernetes#121303 is rebased and merged we can mark this KEP as tracked for code freeze. Let me know if you have any questions!

@humblec
Copy link
Contributor Author

humblec commented Nov 1, 2023

@npolshakova rebase is in progress and will be back to merge queue soon.

@humblec
Copy link
Contributor Author

humblec commented Nov 1, 2023

@npolshakova Its merged.. 🎉 . please mark it for code freeze.

@sreeram-venkitesh
Copy link
Member

Marked as tracked for code freeze 🎉

@kcmartin
Copy link

@humblec @xing-yang Are you still planning to publish a blog for this feature? If so, we need the draft PR opened by tomorrow, Nov. 14. Thanks, from the 1.29 Release Communications team.

@humblec
Copy link
Contributor Author

humblec commented Nov 13, 2023

@kcmartin sure. I have filed (kubernetes/website#43921) . Thanks

humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 14, 2023
KEP#kubernetes/enhancements#3107

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 16, 2023
KEP#kubernetes/enhancements#3107

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 20, 2023
KEP#kubernetes/enhancements#3107

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 20, 2023
KEP#kubernetes/enhancements#3107

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 20, 2023
KEP#kubernetes/enhancements#3107

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
jpbetz added a commit to jpbetz/enhancements that referenced this issue Nov 22, 2023
Shadow contributions:
- 1.27 shadow reviews: 6
- 1.28 shadow reviews: 9
- 1.29 - did not shadow due to time constraints with new SIG API Machinery TL role

Planned contributions:
- 1.30+ contribute to PRR, able to review roughly 12 KEPs per release.  I am happy to PRR more than 12 so long as they are SIG API Machinery KEPs, since I'll be reviewing those anyway..

Shadow reviewer promotion criteria:

Transitions from new to alpha

- kubernetes#3983
- kubernetes#3751

Transitions from alpha to beta

- kubernetes#3107
- kubernetes#2485

Transitions from beta to GA

- kubernetes#2268

Three enhancements that require coordination between multiple components.

- kubernetes#3751
- kubernetes#2485
- kubernetes#3107

Three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.

- kubernetes#2268 (component skew)
- kubernetes#2485 (component skew)
- kubernetes#3751 (HA skew - feature gated fields, component skew)
kubernetes#2268 (HA skew of controller considered)

Three enhancements that are outside your primary domain.

- kubernetes#3983 (SIG Node)
- kubernetes#3751 (SIG Storage)
- kubernetes#2268 (SIG Node)
- kubernetes#3107 (SIG Storage)

Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.

- Yes. E.g. kubernetes#2268 (ability to analyze cluster in aggregate considered, rescheduling considered)

Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.

- Yes. E.g. kubernetes#3751 (new API call, volume of calls considered)
humblec added a commit to humblec/kubernetes.github.io that referenced this issue Dec 4, 2023
KEP#kubernetes/enhancements#3107

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Graduating
Status: Tracked
Status: Tracked for Code Freeze
Development

No branches or pull requests