Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeZone support in CronJob #3140

Open
8 tasks done
soltysh opened this issue Jan 14, 2022 · 20 comments
Open
8 tasks done

TimeZone support in CronJob #3140

soltysh opened this issue Jan 14, 2022 · 20 comments
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@soltysh
Copy link
Contributor

soltysh commented Jan 14, 2022

TimeZone support in CronJob

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 14, 2022
@soltysh
Copy link
Contributor Author

soltysh commented Jan 14, 2022

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2022
@soltysh soltysh changed the title TimeZone support in CronJobs TimeZone support in CronJob Jan 14, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 22, 2022
@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 22, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 24, 2022

Hello @soltysh 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just require having this KEP PR #3143 merged & that will mark all the above requirements.

At the moment, the status of this enhancement is marked as at-risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@soltysh
Copy link
Contributor Author

soltysh commented Feb 2, 2022

@Priyankasaggu11929 #3143 just merged, so I hope that satisfies all the requirements for inclusion.

@rhockenbury
Copy link

rhockenbury commented Feb 3, 2022

Thanks! I've moved this to tracked. All set for enhancement freeze. 👍

@rhockenbury rhockenbury added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 3, 2022
@mehabhalodiya
Copy link

mehabhalodiya commented Feb 12, 2022

Hi @soltysh 👋🏻 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@salaxander
Copy link

salaxander commented Mar 21, 2022

Hi @soltysh 👋

Checking in once more as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

It looks like we're waiting on this one to merge? -> kubernetes/kubernetes#108032

As always, we are here to help should questions come up.

Thanks!!

@soltysh
Copy link
Contributor Author

soltysh commented Mar 24, 2022

It looks like we're waiting on this one to merge? -> kubernetes/kubernetes#108032

correct, that's the only one we need.

@soltysh
Copy link
Contributor Author

soltysh commented Mar 28, 2022

docs placeholder opened in kubernetes/website#32577

@sftim
Copy link
Contributor

sftim commented Mar 29, 2022

When we document this, #3143 (comment) strongly suggests to me that we should document how to manage a custom timezone database (via a hostPath volume mount or similar), and we should do that unless we have a strong commitment from SIG Release about providing official container images for the controller manager that have the timezone data kept very current.

@knight42
Copy link
Member

knight42 commented Apr 7, 2022

@soltysh Hi! Have you been working on this? If not, I am interested in this feature and I would like to implement it!

@soltysh
Copy link
Contributor Author

soltysh commented Apr 8, 2022

@knight42 this merged as alpha in 1.24 see kubernetes/kubernetes#108032 and kubernetes/website#32577 We're planning to promote this further in the next releases.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 10, 2022

/milestone clear
/tracked no

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@soltysh
Copy link
Contributor Author

soltysh commented Jun 8, 2022

/milestone v1.25
/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 8, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 9, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 11, 2022

Hello @soltysh 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage beta for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands: (updated on June 9, 2022)

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to get the open KEP PR #3375 merged by the Enhancements Freeze.

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 17, 2022

With KEP PR #3375 merged, the enhancement is ready for the upcoming enhancements freeze.

For note, the status is now tracked in the enhancements tracking sheet. Thank you!

@kcmartin
Copy link

kcmartin commented Jul 12, 2022

Hello @soltysh 👋, 1.25 Release Docs Lead here.
This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jul 25, 2022

Hi @soltysh 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

I was not able to find any recent k/k PRs related to this KEP. Could you please point me to them, if there are any, OR if you're planning to open any k/k PRs, kindly please link them in the issue. Thank you so much.

The status of this enhancement is marked at at-risk.

@soltysh
Copy link
Contributor Author

soltysh commented Jul 26, 2022

@Priyankasaggu11929 updated description with links to code (kubernetes/kubernetes#111435) and docs (kubernetes/website#35400) changes.

@parul5sahoo
Copy link
Member

parul5sahoo commented Aug 1, 2022

Hey @soltysh 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022, which is tomorrow.

Please ensure that the following PR(s) merged before the code freeze which is in 1 day.

So, that we can mark this as tracked.
Thanks

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 3, 2022

With k/k code PR kubernetes/kubernetes#111435 merged now, this enhancement is marked as tracked for 1.25 code freeze. Thank you so much @soltysh.

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests